-
Notifications
You must be signed in to change notification settings - Fork 52
Open
Description
Description
The codebase contains several unwrap() and expect() calls that can cause unexpected panics in production. Replace them all with proper ? propagation or meaningful error types.
Requirements
- Run
grep -rn "\.unwrap()" src/to find all instances - Replace each with
?,ok_or(...), or a handled match - For
expect()calls: either remove or convert to a real error with context - Add context strings to errors using
.context()fromanyhow - All existing tests must still pass
Suggested Execution
- Branch:
git checkout -b fix/remove-unwraps - Find all
unwrap()andexpect()calls - Replace each with proper error propagation
- Run
cargo testto verify - Commit:
fix: replace unwrap() calls with proper error handling
Acceptance Criteria
- Zero
unwrap()calls insrc/(excluding tests) - All errors propagate with meaningful context
- No new panics introduced
- All existing tests pass
Reactions are currently unavailable