Fix Clippy Warnings Across Entire Codebase

[Timi16]

Description

Running cargo clippy -- -D warnings currently produces several warnings across the codebase. Fix all of them so we can enforce clippy as a hard CI gate.

Requirements

• Run cargo clippy -- -D warnings and fix every warning
• Do not suppress warnings with #[allow(...)] unless absolutely necessary — fix the root cause
• Add clippy enforcement to CI so it never regresses
• Categories to fix: needless borrows, redundant clones, unused variables, match simplifications

Suggested Execution

1. Branch: git checkout -b fix/clippy-warnings
2. Run cargo clippy -- -D warnings 2>&1 | tee clippy.txt
3. Fix each warning category by category
4. Re-run until zero warnings
5. Update CI yml to run cargo clippy -- -D warnings
6. Commit: fix: resolve all clippy warnings

Acceptance Criteria

• cargo clippy -- -D warnings exits with code 0
• No #[allow(...)] suppressions added without comment explaining why
• CI updated to enforce clippy
• Zero regressions in existing tests

[drips-wave]

This issue has been added to the Stellar Wave Program and is worth 150 Points.

🧑‍💻 Interested in contributing? Apply to work on this issue on Drips Wave, earn points, and receive rewards.

Warning

Only applications submitted via the apply link above will be considered. Please do not apply by commenting on the issue or opening a PR directly.

🤠 Repo maintainers: You can manage this issue's Points and Complexity on your Maintainer Dashboard here. Please keep an eye on applications and respond quickly 💙

ℹ️ Learn more about Drips Wave

[midenotch]

@midenotch has applied to work on this issue as part of the Stellar Wave Program's 2nd wave.

Kindly assign this to me - i will work perfecty on it

ℹ️ Repo Maintainers: To accept this application, review their application or assign @midenotch to this issue.

[rocknwa]

@rocknwa has applied to work on this issue as part of the Stellar Wave Program's 2nd wave.

Hi team,

I’d like to take on Issue #284 – Fix Clippy Warnings Across Entire Codebase.

Plan:

• Run cargo clippy -- -D warnings and resolve every warning.
• Fix root causes (needless borrows, redundant clones, unused vars, match simplifications, etc.) — no blanket #[allow(...)].
• Re-run until zero warnings remain.
• Update CI to enforce cargo clippy -- -D warnings as a hard gate.
• Ensure all existing tests pass with no regressions.

Deliverables:

• Zero Clippy warnings
• CI updated to enforce Clippy
• Clean, idiomatic Rust codebase

ℹ️ Repo Maintainers: To accept this application, review their application or assign @rocknwa to this issue.

[spartan124]

@spartan124 has applied to work on this issue as part of the Stellar Wave Program's 2nd wave.

Hello Timi, I had my fair share of clippy warnings contributing this week. I would love to help you resolve all warnings cleanly and efficiently.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @spartan124 to this issue.