From 0f74f55b22f9b08c18f35382b258786ca32d4a2b Mon Sep 17 00:00:00 2001 From: Michael Wood Date: Thu, 22 May 2025 12:36:28 +0100 Subject: [PATCH 1/2] tools: coverage360: Add required data dir parameter --- tools/coverage360.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/coverage360.py b/tools/coverage360.py index 92bad53f..3a063dbc 100755 --- a/tools/coverage360.py +++ b/tools/coverage360.py @@ -9,7 +9,7 @@ data_all = json.load(open('data/status.json')) stats = [] -schema_obj = Schema360() +schema_obj = Schema360("data") schema_fields = schema_obj.get_pkg_schema_fields() From 430cf3a6b220cd85d4097dbb12fa07e117ab3c07 Mon Sep 17 00:00:00 2001 From: Michael Wood Date: Thu, 22 May 2025 12:39:08 +0100 Subject: [PATCH 2/2] tools: cove_checks: Update for new lib360dataquality version --- tools/cove_checks.py | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/tools/cove_checks.py b/tools/cove_checks.py index e92a7669..0ea1880a 100755 --- a/tools/cove_checks.py +++ b/tools/cove_checks.py @@ -6,9 +6,8 @@ from lib360dataquality.cove.threesixtygiving import ( common_checks_360, - USEFULNESS_TEST_CLASS, - QUALITY_TEST_CLASS, ) +from lib360dataquality.additional_test import TestType from lib360dataquality.cove.settings import COVE_CONFIG from lib360dataquality.cove.schema import Schema360 @@ -49,7 +48,7 @@ def main(): file_type = args.file_type # TODO Just dealing with one at a time file_path = args.file_path[0] - schema = Schema360() + schema = Schema360(working_dir) if not file_type: file_type = os.path.splitext(file_path)[1][1:].lower() @@ -78,11 +77,11 @@ def main(): if args.usefulness_only and not args.quality_only: common_checks_360( - context, working_dir, data, schema, test_classes=[USEFULNESS_TEST_CLASS] + context, working_dir, data, schema, test_classes=[TestType.USEFULNESS_TEST_CLASS] ) elif args.quality_only and not args.usefulness_only: common_checks_360( - context, working_dir, data, schema, test_classes=[QUALITY_TEST_CLASS] + context, working_dir, data, schema, test_classes=[TestType.QUALITY_TEST_CLASS] ) else: common_checks_360(context, working_dir, data, schema)