`;pu` does not show overwritten suspensions

[jiajieh01]

Current Behaviour

Problems, Frustrations, General Description

;punishments is an EL+ command which displays all mutes, warnings or suspensions associated with the input ID's IGN. However, if the raider is suspended once and resuspended before the first suspension has finished, the ;pu embed will show the initial suspender and the length of time that the second suspender gave. There is no indication that the suspension has been overwritten and the identity of the second suspender is not deducible from the embed alone.

How to Reproduce

Suspend a player, then suspend them again for a longer period of time whilst they are still suspended.

Wanted/Expected Behaviour

Improvements, Additions, Changes

• Overwritten suspensions should be separated from previous suspensions but state that it was overwritten.

Reasoning

• Settled in an Officer vote.
• The exact scenario depicted in the example below happened twice during December. Due to the experienced nature of the Security team at the time it was dealt with well in each case. The current security wave might not be as fortunate.

Tasks

• Re-write ;pu so that if a raider is already suspended, make a separate field in the embed for the superseding suspension.

Things to Do

Example

1. Tubs suspends Iamrlycool for 2 d for crashing. ;suspend iamrlycool 2 d Crashing
2. Wiggby suspends Iamrlycool for 7 d for crashing whilst suspended. ;suspend iamrlycool 7 d Crashing whilst suspended.
3. Any time ;pu is executed at this point, the bot will return:

Suspensions for @*Iamrlycool🏅 
Suspensions (1)
  1 By @#Tubs in 7 days at 6 January 2024 23:07
Crashing

Wiggby's suspension is nowhere to be seen. It appears on the system that Tubs has suspended Iamrlycool for 7 day and without using the search bar there would be no easy way to show that Wiggby was the most recent suspender.

4. Iamrlycool modmails in asking for appeal. He is incorrectly directed by security, who have used ;pu, to Tubs.