[Feat]: Make landscape non-camera source in portrait orientation FIT instead of CROP

[dimadesu]

Version

3.1.0

Environment that reproduces the issue

I think all devices

Use case description

I've noticed after updating to 3.1.0 for this case preview does FIT, but output surface does CROP.

Proposed solution

Not sure if it's a feature or a bug.
I personally prefer FIT. Maybe some people like CROP in this case.
In any case, it's confusing when preview doesn't match output.

Alternative solutions

I did this change to fix on my fork dimadesu/StreamPack@4aea201...615e632

I am doing testing, seems to work okay.

[ThibaultBee]

The reason the output stream crops is too avoid having pillar box or letter box (with black lines or column of pixels).

[dimadesu]

Ah no worries then. It's how you like it. Okay.
I like letterboxing for this case for external sources, for built-in cameras I added one more commit to exclude them. I think that's roughly how it worked before dimadesu@48e4f73
Happy to close this Git issue then.

[ThibaultBee]

Also, I would rather not use viewport as it requires an implementation in the SurfaceProcessor and this is a customisable component.
I think it is possible to put that in the SurfaceOutput with a new parameter FIT, ...