-
Notifications
You must be signed in to change notification settings - Fork 52
Open
Description
Tech Debt
Wildcard Imports Pattern:
- Issue: Extensive use of wildcard imports (
from .module import *) across tool packages creates implicit exports and name shadowing risks - Files:
src/teradata_mcp_server/tools/tmpl/__init__.py,src/teradata_mcp_server/tools/chat/__init__.py,src/teradata_mcp_server/tools/dba/__init__.py,src/teradata_mcp_server/tools/sql_opt/__init__.py,src/teradata_mcp_server/tools/rag/__init__.py,src/teradata_mcp_server/tools/plot/__init__.py,src/teradata_mcp_server/tools/sec/__init__.py - Impact: Makes it difficult to track which functions are exported, obscures dependencies, complicates refactoring
- Fix approach: Replace wildcard imports with explicit exports list in each
__init__.py, maintain__all__variable listing all public functions
Exception Suppression with contextlib.suppress:
- Issue: Bare exception suppression without logging in critical teradataml initialization path
- Files:
src/teradata_mcp_server/app.pyline 266 - Impact: Silent failures in feature store context creation can mask configuration issues during deployment, making debugging difficult
- Fix approach: Replace
contextlib.suppress(Exception)with explicit try/except block that logs suppressed exceptions at DEBUG level
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels