Minimum secondary mass

[ilyamandel]

We don't want to stop on a failed check against minimum secondary mass (which should just be used for a sampling range) when the user provides binary parameters explicitly; we should only check against MINIMUM_INITIAL_MASS .

Meanwhile, the MINIMUM_MASS_SECONDARY constants is not used and should be removed altogether.

[jeffriley]

@ilyamandel Working on this.

Will change name of option "--minimum-secondary-mass" to "--minimum-sampled-secondary-mass".

How should the minimum secondary mass interact with "--initial-mass-min", and "--initial-mass-max"?

(And maybe we should change the names of those options to "--initial-sampled-mass-min", and "--initial-sampled-mass-max"?)

[ilyamandel]

--initial-mass-min and --initial-mass-max refer to the stellar mass for SSE and the primary mass ranges for BSE; --minimum-secondary-mass refers to the secondary mass range for BSE.

[jeffriley]

Yeah, sorry, I should have made myself more clear. My point is that all three options are currently only used when sampling - they are not referenced when the user supplies a value for mass (either SSE or primary in BSE). Should it stay that way (and we add "-sampled" to their names, and document that they are only used when sampling), or should they play a role in putting bounds on the supplied masses (SSE, and primary and secondary in BSE)?

[ilyamandel]

They should only be used when sampling, not to set bounds on user-supplied values; at the moment, --minimum-secondary-mass is used to set bounds on user-supplied values, and we should remove that functionality.