Releasing version 2.2.0 with support for notifying started and failed builds.

Author: jasonconnery

.gitignore

@@ -4,3 +4,4 @@ build/
 .gradle/
 .idea/
 out/
+.gradletasknamecache

LICENSE.txt

@@ -0,0 +1,21 @@
+The MIT License (MIT)
+
+Copyright (c) 2014 Tapadoo Limited
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.

README.markdown

@@ -2,7 +2,7 @@
 
 A plugin for [TeamCity](http://www.jetbrains.com/teamcity/) to post notifications to [slack](https://slack.com/)
 
-It works by registering as a server listener, and posts to slack on successful builds finishing.
+It works by registering as a server listener, and posts to slack on build events like successful builds (optionally also builds starting and failing)
 
 #Build Plugin
 
@@ -30,10 +30,11 @@ Add a new webhook integration. Make a note of the Token.
 ###In TeamCity
 
 Edit the main config file, usually `.BuildServer/config/main-config.xml` and add an element like so:
+
 ```
 <server rootURL="http://localhost:8111">
   ...
-  <slackNotifier>
+  <slackNotifier postSuccessful="true" postFailed="false" postStarted="false" >
     <slackWebToken>testToken2</slackWebToken>
     <slackDefaultChannel>#general</slackDefaultChannel>
     <slackPostUrl>https://tapadoo.slack.com/services/hooks/incoming-webhook?token=</slackPostUrl>
@@ -43,6 +44,8 @@ Edit the main config file, usually `.BuildServer/config/main-config.xml` and add
   ...
 ```
 
+You can set the attributes on slackNotifier element (postSuccessful,postFailed,postStarted) to decide that notifications you would like posted.
+
 Replace the web token with the token from slack. Change the postUrl also to point to the right slack team. The url can be found in the webhook integraton page, just remove the token from the end. Change the logo url whatever you want.
 
 This by default will post all builds to slack. you can tweak these on a project level though
@@ -62,10 +65,15 @@ Edit the plugin specific xml config, `plugin-settings.xml` probably somewhere in
 
 #Note on TeamCity version support
 
-I'm still using **TeamCity 7.1** , but a quick test on the free version of TeamCity 8 went ok
+I'm still using **TeamCity 7.1** , but a few tests on the free version of TeamCity 8 went fine, and it seems to work there also.
 
 ###Issues
 
 * all xml config - needs web ui extensions for updating settings from GUI. Considering it.
 * channel can be changed per-project either by environmental variable (SLACK_CHANNEL) or by changing the project specific xml in the data directory. This could also use web ui extension UI for editing.
 * All or nothing notifications. By default, all builds are posted. It can be disabled per project, but not currently by build config.
+
+
+# License
+
+MIT License.

build.gradle

@@ -7,7 +7,7 @@ apply plugin: 'java'
 
 
 sourceCompatibility = 1.5
-version = '2.1.2'
+version = '2.2.0'
 
 configurations {
     deploy

src/main/java/com/tapadoo/slacknotifier/SlackConfigProcessor.java

@@ -1,6 +1,8 @@
 package com.tapadoo.slacknotifier;
 
 import jetbrains.buildServer.serverSide.MainConfigProcessor;
+import org.jdom.Attribute;
+import org.jdom.DataConversionException;
 import org.jdom.Element;
 
 /**
@@ -15,11 +17,20 @@ public class SlackConfigProcessor implements MainConfigProcessor {
 
     private static final java.lang.String PREF_CHILD_ELEMENT = "slackNotifier";
 
+    private static final java.lang.String ATTR_NAME_POST_SUCCESSFUL = "postSuccessful" ;
+    private static final java.lang.String ATTR_NAME_POST_STARTED = "postStarted" ;
+    private static final java.lang.String ATTR_NAME_POST_FAILED = "postFailed" ;
+
+
     private String token = "invalidToken";
     private String defaultChannel = "#general";
     private String postUrl;
     private String logoUrl;
 
+    private boolean postSuccessful = true ;
+    private boolean postStarted = false ;
+    private boolean postFailed = false ;
+
     public SlackConfigProcessor()
     {
 
@@ -30,6 +41,21 @@ public void init()
 
     }
 
+    public boolean postSuccessful()
+    {
+        return postSuccessful ;
+    }
+
+    public boolean postFailed()
+    {
+        return postFailed ;
+    }
+
+    public boolean postStarted()
+    {
+        return postStarted ;
+    }
+
     public String getToken() {
         return token;
     }
@@ -65,10 +91,55 @@ public void setLogoUrl(String logoUrl) {
     public void readFrom(org.jdom.Element element) {
         Element mainConfigElement = element.getChild(PREF_CHILD_ELEMENT);
 
+        if( mainConfigElement == null )
+        {
+            token = "" ;
+            postUrl = "http://localhost/?token=" ;
+            return ;
+        }
+
         token = mainConfigElement.getChildText(PREF_KEY_SLACK_WEB_TOKEN);
         defaultChannel = mainConfigElement.getChildText(PREF_KEY_SLACK_DEF_CHANNEL);
         postUrl = mainConfigElement.getChildText(PREF_KEY_SLACK_POSTURL);
         logoUrl = mainConfigElement.getChildText(PREF_KEY_SLACK_LOGOURL);
+
+        Attribute postSuccessfulAttr = mainConfigElement.getAttribute(ATTR_NAME_POST_SUCCESSFUL);
+        Attribute postStartedAttr = mainConfigElement.getAttribute(ATTR_NAME_POST_STARTED);
+        Attribute postFailedAttr = mainConfigElement.getAttribute(ATTR_NAME_POST_FAILED);
+
+        if( postSuccessfulAttr != null )
+        {
+            try {
+                postSuccessful = postSuccessfulAttr.getBooleanValue();
+            }
+            catch( DataConversionException ex )
+            {
+                postSuccessful = true ;
+            }
+        }
+
+        if( postStartedAttr != null )
+        {
+            try {
+                postStarted = postStartedAttr.getBooleanValue();
+            }
+            catch( DataConversionException ex )
+            {
+                postStarted = false ;
+            }
+        }
+
+        if( postFailedAttr != null )
+        {
+            try {
+                postFailed = postFailedAttr.getBooleanValue();
+            }
+            catch( DataConversionException ex )
+            {
+                postFailed = false ;
+            }
+        }
+
     }
 
     public void writeTo(org.jdom.Element element) {
@@ -87,7 +158,7 @@ public void writeTo(org.jdom.Element element) {
         mainConfigElement.addContent(postUrlElement);
         mainConfigElement.addContent(logoUrlElement);
 
-        element.addContent(webTokenElement);
+        element.addContent(mainConfigElement);
 
 
     }