fix: address review — remove orphaned xcstring, atomic icon preservation, clarify columns

Author: datlechin

TablePro/Core/Plugins/PluginManager.swift

@@ -265,9 +265,9 @@ final class PluginManager {
                     from: driverType,
                     isDownloadable: driverType.isDownloadable
                 )
-                PluginMetadataRegistry.shared.register(snapshot: snapshot, forTypeId: typeId)
+                PluginMetadataRegistry.shared.register(snapshot: snapshot, forTypeId: typeId, preserveIcon: true)
                 for additionalId in driverType.additionalDatabaseTypeIds {
-                    PluginMetadataRegistry.shared.register(snapshot: snapshot, forTypeId: additionalId)
+                    PluginMetadataRegistry.shared.register(snapshot: snapshot, forTypeId: additionalId, preserveIcon: true)
                     PluginMetadataRegistry.shared.registerTypeAlias(additionalId, primaryTypeId: typeId)
                 }
 

TablePro/Core/Plugins/PluginMetadataRegistry.swift

@@ -117,6 +117,22 @@ struct PluginMetadataSnapshot: Sendable {
             additionalConnectionFields: []
         )
     }
+
+    func withIconName(_ newIconName: String) -> PluginMetadataSnapshot {
+        PluginMetadataSnapshot(
+            displayName: displayName, iconName: newIconName, defaultPort: defaultPort,
+            requiresAuthentication: requiresAuthentication, supportsForeignKeys: supportsForeignKeys,
+            supportsSchemaEditing: supportsSchemaEditing, isDownloadable: isDownloadable,
+            primaryUrlScheme: primaryUrlScheme, parameterStyle: parameterStyle,
+            navigationModel: navigationModel, explainVariants: explainVariants,
+            pathFieldRole: pathFieldRole, supportsHealthMonitor: supportsHealthMonitor,
+            urlSchemes: urlSchemes, postConnectActions: postConnectActions,
+            brandColorHex: brandColorHex, queryLanguageName: queryLanguageName,
+            editorLanguage: editorLanguage, connectionMode: connectionMode,
+            supportsDatabaseSwitching: supportsDatabaseSwitching,
+            capabilities: capabilities, schema: schema, editor: editor, connection: connection
+        )
+    }
 }
 
 final class PluginMetadataRegistry: @unchecked Sendable {
@@ -513,11 +529,15 @@ final class PluginMetadataRegistry: @unchecked Sendable {
         reverseTypeIndex["ScyllaDB"] = "Cassandra"
     }
 
-    func register(snapshot: PluginMetadataSnapshot, forTypeId typeId: String) {
+    func register(snapshot: PluginMetadataSnapshot, forTypeId typeId: String, preserveIcon: Bool = false) {
         lock.lock()
         defer { lock.unlock() }
-        snapshots[typeId] = snapshot
-        for scheme in snapshot.urlSchemes {
+        var resolved = snapshot
+        if preserveIcon, let existingIcon = snapshots[typeId]?.iconName {
+            resolved = snapshot.withIconName(existingIcon)
+        }
+        snapshots[typeId] = resolved
+        for scheme in resolved.urlSchemes {
             schemeIndex[scheme.lowercased()] = typeId
         }
     }
@@ -594,15 +614,9 @@ final class PluginMetadataRegistry: @unchecked Sendable {
         let schemes = driverType.urlSchemes
         let primaryScheme = schemes.first ?? driverType.databaseTypeId.lowercased()
 
-        // Prefer the registry default's custom icon (e.g. "mysql-icon") over the
-        // plugin's generic SF Symbol (e.g. "cylinder.fill"). The registry defaults
-        // have curated SVG icons in the asset catalog.
-        let existingIcon = snapshot(forTypeId: driverType.databaseTypeId)?.iconName
-        let iconName = existingIcon ?? driverType.iconName
-
         return PluginMetadataSnapshot(
             displayName: driverType.databaseDisplayName,
-            iconName: iconName,
+            iconName: driverType.iconName,
             defaultPort: driverType.defaultPort,
             requiresAuthentication: driverType.requiresAuthentication,
             supportsForeignKeys: driverType.supportsForeignKeys,

TablePro/Resources/Localizable.xcstrings

@@ -13360,16 +13360,6 @@
         }
       }
     },
-    "Plugin was built with PluginKit version %lld, but version %lld or later is required. Please update the plugin." : {
-      "localizations" : {
-        "en" : {
-          "stringUnit" : {
-            "state" : "new",
-            "value" : "Plugin was built with PluginKit version %1$lld, but version %2$lld or later is required. Please update the plugin."
-          }
-        }
-      }
-    },
     "Plugins" : {
       "localizations" : {
         "vi" : {

TablePro/Views/Main/MainContentView.swift

@@ -491,10 +491,11 @@ struct MainContentView: View {
                            let tableName = selectedTab.tableName,
                            let tabIndex = tabManager.selectedTabIndex
                         {
+                            // columns is [] on initial load — buildFilteredQuery uses SELECT *
                             let filteredQuery = coordinator.queryBuilder.buildFilteredQuery(
                                 tableName: tableName,
                                 filters: selectedTab.filterState.appliedFilters,
-                                columns: selectedTab.resultColumns,
+                                columns: [],
                                 limit: selectedTab.pagination.pageSize,
                                 offset: selectedTab.pagination.currentOffset
                             )