fix: call editor destroy from coordinator teardown since onDisappear doesn't fire on window close

Author: datlechin

TablePro/Views/Editor/QueryEditorView.swift

@@ -29,6 +29,7 @@ struct QueryEditorView: View {
     var onAIExplain: ((String) -> Void)?
     var onAIOptimize: ((String) -> Void)?
     var onSaveAsFavorite: ((String) -> Void)?
+    var onEditorCoordinatorReady: ((SQLEditorCoordinator) -> Void)?
 
     @State private var vimMode: VimMode = .normal
 
@@ -54,7 +55,8 @@ struct QueryEditorView: View {
                 onExecuteQuery: onExecuteQuery,
                 onAIExplain: onAIExplain,
                 onAIOptimize: onAIOptimize,
-                onSaveAsFavorite: onSaveAsFavorite
+                onSaveAsFavorite: onSaveAsFavorite,
+                onEditorCoordinatorReady: onEditorCoordinatorReady
             )
             .frame(minHeight: 100)
             .clipped()

TablePro/Views/Editor/SQLEditorView.swift

@@ -26,6 +26,8 @@ struct SQLEditorView: View {
     var onAIExplain: ((String) -> Void)?
     var onAIOptimize: ((String) -> Void)?
     var onSaveAsFavorite: ((String) -> Void)?
+    /// Called when the editor coordinator is ready — allows parent to store a reference for teardown.
+    var onEditorCoordinatorReady: ((SQLEditorCoordinator) -> Void)?
 
     @State private var editorState = SourceEditorState()
     @State private var completionAdapter: SQLCompletionAdapter?
@@ -104,6 +106,7 @@ struct SQLEditorView: View {
                 coordinator.onAIExplain = onAIExplain
                 coordinator.onAIOptimize = onAIOptimize
                 coordinator.onSaveAsFavorite = onSaveAsFavorite
+                onEditorCoordinatorReady?(coordinator)
                 setupFavoritesObserver()
             }
         } else {

TablePro/Views/Main/Child/MainEditorContentView.swift

@@ -212,6 +212,9 @@ struct MainEditorContentView: View {
                     onSaveAsFavorite: { text in
                         guard !text.isEmpty else { return }
                         favoriteDialogQuery = FavoriteDialogQuery(query: text)
+                    },
+                    onEditorCoordinatorReady: { editorCoord in
+                        coordinator.editorCoordinator = editorCoord
                     }
                 )
             }

TablePro/Views/Main/MainContentCoordinator.swift

@@ -128,6 +128,10 @@ final class MainContentCoordinator {
     /// Called during teardown to let the view layer release cached row providers and sort data.
     @ObservationIgnored var onTeardown: (() -> Void)?
 
+    /// Weak reference to the active SQL editor coordinator for teardown cleanup.
+    /// Set by SQLEditorCoordinator during prepareCoordinator.
+    @ObservationIgnored weak var editorCoordinator: SQLEditorCoordinator?
+
     /// True while a database switch is in progress. Guards against
     /// side-effect window creation during the switch cascade.
     var isSwitchingDatabase = false
@@ -369,6 +373,12 @@ final class MainContentCoordinator {
         onTeardown?()
         onTeardown = nil
 
+        // Release editor heavy state (tree-sitter, highlighter, text storage) —
+        // SQLEditorView.onDisappear does NOT fire when an NSWindow closes,
+        // so we must do it here explicitly.
+        editorCoordinator?.destroy()
+        editorCoordinator = nil
+
         // Release heavy data so memory drops even if SwiftUI delays deallocation
         for tab in tabManager.tabs {
             tab.rowBuffer.evict()