fix: move delete tombstone after persistence, log encoding failures

Author: datlechin

TablePro/Core/Sync/SyncRecordMapper.swift

@@ -79,15 +79,25 @@ struct SyncRecordMapper {
         }
 
         // Encode complex structs as JSON Data
-        if let sshData = try? encoder.encode(connection.sshConfig) {
+        do {
+            let sshData = try encoder.encode(connection.sshConfig)
             record["sshConfigJson"] = sshData as CKRecordValue
+        } catch {
+            logger.warning("Failed to encode SSH config for sync: \(error.localizedDescription)")
         }
-        if let sslData = try? encoder.encode(connection.sslConfig) {
+        do {
+            let sslData = try encoder.encode(connection.sslConfig)
             record["sslConfigJson"] = sslData as CKRecordValue
+        } catch {
+            logger.warning("Failed to encode SSL config for sync: \(error.localizedDescription)")
         }
-        if !connection.additionalFields.isEmpty,
-           let fieldsData = try? encoder.encode(connection.additionalFields) {
-            record["additionalFieldsJson"] = fieldsData as CKRecordValue
+        if !connection.additionalFields.isEmpty {
+            do {
+                let fieldsData = try encoder.encode(connection.additionalFields)
+                record["additionalFieldsJson"] = fieldsData as CKRecordValue
+            } catch {
+                logger.warning("Failed to encode additional fields for sync: \(error.localizedDescription)")
+            }
         }
 
         return record

TablePro/Views/Connection/ConnectionFormView.swift

@@ -1042,10 +1042,13 @@ struct ConnectionFormView: View { // swiftlint:disable:this type_body_length
 
     private func deleteConnection() {
         guard let id = connectionId else { return }
-        SyncChangeTracker.shared.markDeleted(.connection, id: id.uuidString)
         var savedConnections = storage.loadConnections()
+        let hadConnection = savedConnections.contains { $0.id == id }
         savedConnections.removeAll { $0.id == id }
         storage.saveConnections(savedConnections)
+        if hadConnection {
+            SyncChangeTracker.shared.markDeleted(.connection, id: id.uuidString)
+        }
         NSApplication.shared.closeWindows(withId: "connection-form")
         NotificationCenter.default.post(name: .connectionUpdated, object: nil)
     }