fix: favorites UX — full query fallback, search includes query text, hit testing, scope default

Author: datlechin

TablePro/ViewModels/FavoritesSidebarViewModel.swift

@@ -182,7 +182,8 @@ final class FavoritesSidebarViewModel {
             switch item {
             case .favorite(let fav):
                 if fav.name.localizedCaseInsensitiveContains(searchText) ||
-                    (fav.keyword?.localizedCaseInsensitiveContains(searchText) == true) {
+                    (fav.keyword?.localizedCaseInsensitiveContains(searchText) == true) ||
+                    fav.query.localizedCaseInsensitiveContains(searchText) {
                     return item
                 }
                 return nil

TablePro/Views/Editor/AIEditorContextMenu.swift

@@ -12,6 +12,7 @@ final class AIEditorContextMenu: NSMenu, NSMenuDelegate {
     /// Closure provided by the coordinator to check if text is selected
     var hasSelection: (() -> Bool)?
     var selectedText: (() -> String?)?
+    var fullText: (() -> String?)?
     var onExplainWithAI: ((String) -> Void)?
     var onOptimizeWithAI: ((String) -> Void)?
     var onSaveAsFavorite: ((String) -> Void)?
@@ -55,6 +56,7 @@ final class AIEditorContextMenu: NSMenu, NSMenuDelegate {
         )
         saveAsFavItem.target = self
         saveAsFavItem.image = NSImage(systemSymbolName: "star", accessibilityDescription: nil)
+        saveAsFavItem.isEnabled = (fullText?()?.isEmpty == false)
         menu.addItem(saveAsFavItem)
 
         // AI items — only when text is selected
@@ -96,8 +98,8 @@ final class AIEditorContextMenu: NSMenu, NSMenuDelegate {
     @objc private func handleSaveAsFavorite() {
         if let text = selectedText?(), !text.isEmpty {
             onSaveAsFavorite?(text)
-        } else {
-            onSaveAsFavorite?("")
+        } else if let text = fullText?(), !text.isEmpty {
+            onSaveAsFavorite?(text)
         }
     }
 }

TablePro/Views/Editor/SQLEditorCoordinator.swift

@@ -165,6 +165,9 @@ final class SQLEditorCoordinator: TextViewCoordinator {
             guard range.length > 0 else { return nil }
             return (textView.string as NSString).substring(with: range)
         }
+        menu.fullText = { [weak controller] in
+            controller?.textView?.string
+        }
         menu.onExplainWithAI = { [weak self] text in self?.onAIExplain?(text) }
         menu.onOptimizeWithAI = { [weak self] text in self?.onAIOptimize?(text) }
         menu.onSaveAsFavorite = { [weak self] text in self?.onSaveAsFavorite?(text) }

TablePro/Views/Sidebar/FavoriteEditDialog.swift

@@ -107,7 +107,7 @@ struct FavoriteEditDialog: View {
                 keyword = fav.keyword ?? ""
                 isGlobal = forceGlobal || fav.connectionId == nil
             } else {
-                isGlobal = true
+                isGlobal = forceGlobal
                 if let q = initialQuery {
                     query = q
                 }

TablePro/Views/Sidebar/SidebarView.swift

@@ -82,6 +82,7 @@ struct SidebarView: View {
                 .opacity(sidebarState.selectedSidebarTab == .tables ? 1 : 0)
                 .frame(maxHeight: sidebarState.selectedSidebarTab == .tables ? .infinity : 0)
                 .clipped()
+                .allowsHitTesting(sidebarState.selectedSidebarTab == .tables)
 
             FavoritesTabView(
                 connectionId: connectionId,
@@ -91,6 +92,7 @@ struct SidebarView: View {
             .opacity(sidebarState.selectedSidebarTab == .favorites ? 1 : 0)
             .frame(maxHeight: sidebarState.selectedSidebarTab == .favorites ? .infinity : 0)
             .clipped()
+            .allowsHitTesting(sidebarState.selectedSidebarTab == .favorites)
         }
         .animation(.easeInOut(duration: 0.18), value: sidebarState.selectedSidebarTab)
         .safeAreaInset(edge: .top, spacing: 0) {