fix: address PR review findings for Cloudflare D1 plugin

Author: datlechin

Plugins/CloudflareD1DriverPlugin/CloudflareD1PluginDriver.swift

@@ -139,12 +139,7 @@ final class CloudflareD1PluginDriver: PluginDatabaseDriver, @unchecked Sendable
 
         let startTime = Date()
         let trimmed = query.trimmingCharacters(in: .whitespacesAndNewlines)
-        let anyParams: [Any?] = parameters.map { param -> Any? in
-            guard let value = param else { return nil }
-            return value
-        }
-
-        let payload = try await client.executeRaw(sql: trimmed, params: anyParams)
+        let payload = try await client.executeRaw(sql: trimmed, params: parameters)
         let executionTime = Date().timeIntervalSince(startTime)
         return mapRawResult(payload, executionTime: executionTime)
     }
@@ -220,7 +215,7 @@ final class CloudflareD1PluginDriver: PluginDatabaseDriver, @unchecked Sendable
         let query = """
             SELECT m.name AS tbl, p.cid, p.name, p.type, p."notnull", p.dflt_value, p.pk
             FROM sqlite_master m, pragma_table_info(m.name) p
-            WHERE m.type = 'table' AND m.name NOT LIKE 'sqlite_%' AND m.name NOT LIKE '_cf_%'
+            WHERE m.type = 'table' AND m.name NOT LIKE 'sqlite_%' AND m.name NOT GLOB '_cf_*'
             ORDER BY m.name, p.cid
             """
         let result = try await execute(query: query)
@@ -259,7 +254,7 @@ final class CloudflareD1PluginDriver: PluginDatabaseDriver, @unchecked Sendable
                    p."from" AS column_name, p."to" AS referenced_column,
                    p.on_update, p.on_delete
             FROM sqlite_master m, pragma_foreign_key_list(m.name) p
-            WHERE m.type = 'table' AND m.name NOT LIKE 'sqlite_%' AND m.name NOT LIKE '_cf_%'
+            WHERE m.type = 'table' AND m.name NOT LIKE 'sqlite_%' AND m.name NOT GLOB '_cf_*'
             ORDER BY m.name, p.id, p.seq
             """
         let result = try await execute(query: query)
@@ -569,9 +564,17 @@ final class CloudflareD1PluginDriver: PluginDatabaseDriver, @unchecked Sendable
 
     // MARK: - Transactions
 
-    func beginTransaction() async throws {}
-    func commitTransaction() async throws {}
-    func rollbackTransaction() async throws {}
+    func beginTransaction() async throws {
+        throw CloudflareD1Error(message: String(localized: "Transactions are not supported by Cloudflare D1"))
+    }
+
+    func commitTransaction() async throws {
+        throw CloudflareD1Error(message: String(localized: "Transactions are not supported by Cloudflare D1"))
+    }
+
+    func rollbackTransaction() async throws {
+        throw CloudflareD1Error(message: String(localized: "Transactions are not supported by Cloudflare D1"))
+    }
 
     // MARK: - Private Helpers
 

Plugins/CloudflareD1DriverPlugin/D1HttpClient.swift

@@ -363,11 +363,17 @@ final class D1HttpClient: @unchecked Sendable {
                 message: String(localized: "Authentication failed. Check your API token and Account ID.")
             )
         case 429:
-            let retryAfter = response.value(forHTTPHeaderField: "Retry-After") ?? "unknown"
-            Self.logger.warning("D1 rate limited. Retry-After: \(retryAfter)")
-            throw D1HttpError(
-                message: String(localized: "Rate limited by Cloudflare. Retry after \(retryAfter) seconds.")
-            )
+            let retryAfter = response.value(forHTTPHeaderField: "Retry-After")
+            Self.logger.warning("D1 rate limited. Retry-After: \(retryAfter ?? "not specified")")
+            if let seconds = retryAfter {
+                throw D1HttpError(
+                    message: String(localized: "Rate limited by Cloudflare. Retry after \(seconds) seconds.")
+                )
+            } else {
+                throw D1HttpError(
+                    message: String(localized: "Rate limited by Cloudflare. Please try again later.")
+                )
+            }
         default:
             if let errorResponse = try? JSONDecoder().decode(
                 D1ApiResponse<D1RawResultPayload>.self, from: data

TablePro/Views/Connection/ConnectionFormView.swift

@@ -874,7 +874,13 @@ struct ConnectionFormView: View { // swiftlint:disable:this type_body_length
         // Host and port can be empty (will use defaults: localhost and default port)
         let mode = PluginManager.shared.connectionMode(for: type)
         let requiresDatabase = mode == .fileBased || mode == .apiOnly
-        let basicValid = !name.isEmpty && (requiresDatabase ? !database.isEmpty : true)
+        var basicValid = !name.isEmpty && (requiresDatabase ? !database.isEmpty : true)
+        if mode == .apiOnly {
+            let hasRequiredFields = authSectionFields
+                .filter(\.isRequired)
+                .allSatisfy { !(additionalFieldValues[$0.id] ?? "").isEmpty }
+            basicValid = basicValid && hasRequiredFields && !password.isEmpty
+        }
         if sshEnabled {
             let sshPortValid = sshPort.isEmpty || (Int(sshPort).map { (1...65_535).contains($0) } ?? false)
             let sshValid = !sshHost.isEmpty && !sshUsername.isEmpty && sshPortValid