fix: address CodeRabbit review feedback

- Remove force-unwrap in SQLFormatterService majorKeywordRegex match
- Add explicit internal access control on TableReference
- Cap DDL highlight regex to 10k characters for large DDL safety
- Fix CRLF double-counting in CellOverlayEditor newline counter
- Invalidate queryBuildingDriverCache on plugin register/uninstall
- Use DispatchQueue.main.async for isUpdatingColumnLayout flag reset

Author: datlechin

TablePro/Core/Autocomplete/SQLContextAnalyzer.swift

@@ -41,7 +41,7 @@ enum SQLClauseType {
 }
 
 /// Represents a table reference with optional alias
-struct TableReference: Hashable, Sendable {
+internal struct TableReference: Hashable, Sendable {
     let tableName: String
     let alias: String?
 

TablePro/Core/Plugins/PluginManager.swift

@@ -209,6 +209,8 @@ final class PluginManager {
 
             Self.logger.info("Loaded plugin '\(entry.name)' v\(entry.version) [\(item.source == .builtIn ? "built-in" : "user")]")
         }
+
+        queryBuildingDriverCache.removeAll()
     }
 
     private func discoverAllPlugins() {
@@ -249,6 +251,7 @@ final class PluginManager {
             }
         }
 
+        queryBuildingDriverCache.removeAll()
         hasFinishedInitialLoad = true
         validateDependencies()
         Self.logger.info("Loaded \(self.plugins.count) plugin(s): \(self.driverPlugins.count) driver(s), \(self.exportPlugins.count) export format(s), \(self.importPlugins.count) import format(s)")
@@ -627,15 +630,19 @@ final class PluginManager {
         let typeId = databaseType.pluginTypeId
         if let cached = queryBuildingDriverCache[typeId] { return cached }
         guard let plugin = driverPlugin(for: databaseType) else {
-            queryBuildingDriverCache[typeId] = .some(nil)
+            if hasFinishedInitialLoad {
+                queryBuildingDriverCache[typeId] = .some(nil)
+            }
             return nil
         }
         let config = DriverConnectionConfig(host: "", port: 0, username: "", password: "", database: "")
         let driver = plugin.createDriver(config: config)
         let result: (any PluginDatabaseDriver)? =
             driver.buildBrowseQuery(table: "_probe", sortColumns: [], columns: [], limit: 1, offset: 0) != nil
             ? driver : nil
-        queryBuildingDriverCache[typeId] = .some(result)
+        if hasFinishedInitialLoad {
+            queryBuildingDriverCache[typeId] = .some(result)
+        }
         return result
     }
 
@@ -1013,6 +1020,8 @@ final class PluginManager {
         disabled.remove(id)
         disabledPluginIds = disabled
 
+        queryBuildingDriverCache.removeAll()
+
         Self.logger.info("Uninstalled plugin '\(id)'")
         _needsRestart = true
     }

TablePro/Core/Services/Formatting/SQLFormatterService.swift

@@ -480,8 +480,9 @@ struct SQLFormatterService: SQLFormatterProtocol {
         let searchNSRange = NSRange(searchStart..<sql.endIndex, in: sql)
         var endIndex = sql.endIndex
 
-        if let match = Self.majorKeywordRegex.firstMatch(in: sql, range: searchNSRange) {
-            endIndex = Range(match.range, in: sql)!.lowerBound
+        if let match = Self.majorKeywordRegex.firstMatch(in: sql, range: searchNSRange),
+           let matchRange = Range(match.range, in: sql) {
+            endIndex = matchRange.lowerBound
         }
 
         // Fix #3: Work with immutable substring

TablePro/Views/Main/Child/MainEditorContentView.swift

@@ -454,10 +454,12 @@ struct MainEditorContentView: View {
             get: { tab.columnLayout },
             set: { newValue in
                 coordinator.isUpdatingColumnLayout = true
-                defer { coordinator.isUpdatingColumnLayout = false }
                 if let index = tabManager.selectedTabIndex {
                     tabManager.tabs[index].columnLayout = newValue
                 }
+                DispatchQueue.main.async {
+                    coordinator.isUpdatingColumnLayout = false
+                }
             }
         )
     }

TablePro/Views/Results/CellOverlayEditor.swift

@@ -58,8 +58,8 @@ final class CellOverlayEditor: NSObject, NSTextViewDelegate {
         // Determine overlay height — at least the cell height, up to 120pt
         let lineHeight: CGFloat = ThemeEngine.shared.dataGridFonts.regular.boundingRectForFont.height + 4
         var newlineCount = 0
-        for scalar in value.unicodeScalars {
-            if CharacterSet.newlines.contains(scalar) { newlineCount += 1 }
+        for scalar in value.unicodeScalars where scalar == "\n" {
+            newlineCount += 1
         }
         let lineCount = CGFloat(newlineCount + 1)
         let contentHeight = max(lineCount * lineHeight + 8, cellRect.height)

TablePro/Views/Structure/DDLTextView.swift

@@ -105,10 +105,12 @@ struct DDLTextView: NSViewRepresentable {
         textStorage.addAttribute(.font, value: font, range: fullRange)
         textStorage.addAttribute(.foregroundColor, value: NSColor.labelColor, range: fullRange)
 
-        // Apply pre-compiled patterns
+        // Apply pre-compiled patterns (cap to 10k chars for large DDL safety)
         let text = textStorage.string
+        let highlightLength = min(textStorage.length, 10_000)
+        let highlightRange = NSRange(location: 0, length: highlightLength)
         for (regex, color) in Self.syntaxPatterns {
-            let matches = regex.matches(in: text, options: [], range: fullRange)
+            let matches = regex.matches(in: text, options: [], range: highlightRange)
             for match in matches {
                 textStorage.addAttribute(.foregroundColor, value: color, range: match.range)
             }