fix: address second round of PR review feedback

Author: datlechin

Plugins/EtcdDriverPlugin/EtcdCommandParser.swift

@@ -80,7 +80,7 @@ extension EtcdParseError: PluginDriverError {
 }
 
 struct EtcdCommandParser {
-    private static let logger = Logger(subsystem: "com.TablePro.EtcdDriver", category: "EtcdCommandParser")
+    private static let logger = Logger(subsystem: "com.TablePro", category: "EtcdCommandParser")
 
     // MARK: - Public API
 

Plugins/EtcdDriverPlugin/EtcdHttpClient.swift

@@ -314,7 +314,7 @@ final class EtcdHttpClient: @unchecked Sendable {
     private var authToken: String?
     private var _isAuthenticating = false
 
-    private static let logger = Logger(subsystem: "com.TablePro.EtcdDriver", category: "EtcdHttpClient")
+    private static let logger = Logger(subsystem: "com.TablePro", category: "EtcdHttpClient")
 
     init(config: DriverConnectionConfig) {
         self.config = config
@@ -903,6 +903,7 @@ final class EtcdHttpClient: @unchecked Sendable {
 
             if !verifyHostname {
                 // VerifyCA mode: validate the CA chain but skip hostname check
+                Self.logger.debug("TLS: skipping hostname verification (VerifyCA mode)")
                 let policy = SecPolicyCreateBasicX509()
                 SecTrustSetPolicies(serverTrust, policy)
             }

Plugins/EtcdDriverPlugin/EtcdPluginDriver.swift

@@ -21,7 +21,7 @@ final class EtcdPluginDriver: PluginDatabaseDriver, @unchecked Sendable {
         lock.withLock { _httpClient }
     }
 
-    private static let logger = Logger(subsystem: "com.TablePro.EtcdDriver", category: "EtcdPluginDriver")
+    private static let logger = Logger(subsystem: "com.TablePro", category: "EtcdPluginDriver")
     private static let maxKeys = PluginRowLimits.defaultMax
 
 
@@ -213,7 +213,7 @@ final class EtcdPluginDriver: PluginDatabaseDriver, @unchecked Sendable {
 
             // Skip leading "/" when finding the first segment
             let searchStart: String.Index
-            if relative.hasPrefix("/") && relative.count > 1 {
+            if relative.hasPrefix("/"), relative.index(after: relative.startIndex) < relative.endIndex {
                 searchStart = relative.index(after: relative.startIndex)
             } else {
                 searchStart = relative.startIndex
@@ -919,8 +919,8 @@ final class EtcdPluginDriver: PluginDatabaseDriver, @unchecked Sendable {
     /// Empty prefix uses null byte (\0) as key to mean "all keys".
     private static func allKeysRange(for prefix: String) -> (key: String, rangeEnd: String) {
         if prefix.isEmpty {
-            // \0 as key = start from beginning, \0 as range_end = all keys
-            let b64Key = EtcdHttpClient.base64Encode("\0")
+            // Empty key = start from beginning, \0 as range_end = all keys
+            let b64Key = EtcdHttpClient.base64Encode("")
             let b64RangeEnd = EtcdHttpClient.base64Encode("\0")
             return (b64Key, b64RangeEnd)
         }

Plugins/EtcdDriverPlugin/EtcdStatementGenerator.swift

@@ -10,7 +10,7 @@ import os
 import TableProPluginKit
 
 struct EtcdStatementGenerator {
-    private static let logger = Logger(subsystem: "com.TablePro.EtcdDriver", category: "EtcdStatementGenerator")
+    private static let logger = Logger(subsystem: "com.TablePro", category: "EtcdStatementGenerator")
 
     let prefix: String
     let columns: [String]

TableProTests/Plugins/EtcdHttpClientUtilityTests.swift

@@ -116,21 +116,19 @@ struct EtcdPrefixRangeEndTests {
 
     @Test("All 0xFF bytes returns null byte")
     func allMaxBytes() {
-        // Build a string where all bytes are 0xFF
-        let bytes: [UInt8] = [0xFF, 0xFF, 0xFF]
-        let input = String(bytes: bytes, encoding: .utf8) ?? ""
-        // If input can't be created as valid UTF-8, test that the function handles it
-        if !input.isEmpty {
-            let result = TestEtcdPrefixRange.rangeEnd(for: input)
-            #expect(result == "\0")
-        }
+        // 0xFF bytes aren't valid UTF-8; test with lossy decoding to exercise the all-max-byte path
+        let input = String(decoding: [0xFF, 0xFF, 0xFF] as [UInt8], as: UTF8.self)
+        let result = TestEtcdPrefixRange.rangeEnd(for: input)
+        #expect(result == "\0")
     }
 
-    @Test("Prefix with trailing 0xFF bytes rolls back correctly")
-    func trailingMaxBytes() {
-        // "a" followed by nothing special: just increment last byte
-        let result = TestEtcdPrefixRange.rangeEnd(for: "a")
-        #expect(result == "b")
+    @Test("Prefix ending with high-value byte rolls back correctly")
+    func trailingHighBytes() {
+        // "a" + 0xFE (high but not max) should increment 0xFE to 0xFF, truncate to "a\xFF"
+        // But since 0xFE isn't valid UTF-8 continuation, test with valid multi-byte:
+        // Use "z" which is 0x7A — incrementing gives 0x7B = "{"
+        let result = TestEtcdPrefixRange.rangeEnd(for: "az")
+        #expect(result == "a{")
     }
 }