fix: address PR review findings from CodeRabbit

Author: datlechin

LocalPackages/CodeEditSourceEditor/Sources/CodeEditSourceEditor/CodeSuggestion/Window/SuggestionController.swift

@@ -147,7 +147,8 @@ public final class SuggestionController: NSWindowController {
                 }
                 if textView.view.window == nil {
                     self.close()
-                } else if let firstResponder = window.firstResponder as? NSView,
+                } else if textView.view.window === window,
+                          let firstResponder = window.firstResponder as? NSView,
                           !firstResponder.isDescendant(of: textView.view) {
                     self.close()
                 }

TablePro/ContentView.swift

@@ -18,6 +18,7 @@ struct ContentView: View {
     let payload: EditorTabPayload?
 
     @State private var currentSession: ConnectionSession?
+    @State private var closingSessionId: UUID?
     @State private var columnVisibility: NavigationSplitViewVisibility = .all
     @State private var showNewConnectionSheet = false
     @State private var showEditConnectionSheet = false
@@ -70,6 +71,7 @@ struct ContentView: View {
             // Right sidebar toggle is handled by MainContentView (has the binding)
             // Left sidebar toggle uses native NSSplitViewController.toggleSidebar via responder chain
             .onChange(of: DatabaseManager.shared.currentSessionId, initial: true) { _, newSessionId in
+                guard closingSessionId == nil else { return }
                 let ourConnectionId = payload?.connectionId
                 if ourConnectionId != nil {
                     guard newSessionId == ourConnectionId else { return }
@@ -331,6 +333,7 @@ struct ContentView: View {
     // MARK: - Connection Status
 
     private func handleConnectionStatusChange() {
+        guard closingSessionId == nil else { return }
         let sessions = DatabaseManager.shared.activeSessions
         let connectionId = payload?.connectionId ?? currentSession?.id ?? DatabaseManager.shared.currentSessionId
         guard let sid = connectionId else {
@@ -339,6 +342,7 @@ struct ContentView: View {
         }
         guard let newSession = sessions[sid] else {
             if currentSession?.id == sid {
+                closingSessionId = sid
                 rightPanelState?.teardown()
                 rightPanelState = nil
                 sessionState?.coordinator.teardown()

TablePro/Core/Services/Formatting/SQLFormatterService.swift

@@ -108,20 +108,13 @@ struct SQLFormatterService: SQLFormatterProtocol {
     /// Get or create the keyword uppercasing regex for a given database type
     private static func keywordRegex(for dialect: DatabaseType) -> NSRegularExpression? {
         keywordRegexLock.lock()
-        defer { keywordRegexLock.unlock() }
-
         if let cached = keywordRegexCache[dialect] {
+            keywordRegexLock.unlock()
             return cached
         }
+        keywordRegexLock.unlock()
 
-        let provider: SQLDialectProvider
-        if Thread.isMainThread {
-            provider = MainActor.assumeIsolated { SQLDialectFactory.createDialect(for: dialect) }
-        } else {
-            provider = DispatchQueue.main.sync {
-                MainActor.assumeIsolated { SQLDialectFactory.createDialect(for: dialect) }
-            }
-        }
+        let provider = resolveDialectProvider(for: dialect)
         let allKeywords = provider.keywords.union(provider.functions).union(provider.dataTypes)
         let escapedKeywords = allKeywords.map { NSRegularExpression.escapedPattern(for: $0) }
         let pattern = "\\b(\(escapedKeywords.joined(separator: "|")))\\b"
@@ -130,10 +123,24 @@ struct SQLFormatterService: SQLFormatterProtocol {
             return nil
         }
 
+        keywordRegexLock.lock()
+        defer { keywordRegexLock.unlock() }
+        if let cached = keywordRegexCache[dialect] {
+            return cached
+        }
         keywordRegexCache[dialect] = regex
         return regex
     }
 
+    private static func resolveDialectProvider(for dialect: DatabaseType) -> SQLDialectProvider {
+        if Thread.isMainThread {
+            return MainActor.assumeIsolated { SQLDialectFactory.createDialect(for: dialect) }
+        }
+        return DispatchQueue.main.sync {
+            MainActor.assumeIsolated { SQLDialectFactory.createDialect(for: dialect) }
+        }
+    }
+
     // MARK: - Public API
 
     func format(
@@ -159,15 +166,7 @@ struct SQLFormatterService: SQLFormatterProtocol {
             throw SQLFormatterError.invalidCursorPosition(cursor, max: sqlLength)
         }
 
-        // Get dialect provider
-        let dialectProvider: SQLDialectProvider
-        if Thread.isMainThread {
-            dialectProvider = MainActor.assumeIsolated { SQLDialectFactory.createDialect(for: dialect) }
-        } else {
-            dialectProvider = DispatchQueue.main.sync {
-                MainActor.assumeIsolated { SQLDialectFactory.createDialect(for: dialect) }
-            }
-        }
+        let dialectProvider = Self.resolveDialectProvider(for: dialect)
 
         // Format the SQL
         let formatted = formatSQL(sql, dialect: dialectProvider, databaseType: dialect, options: options)

TablePro/Extensions/String+HexDump.swift

@@ -8,11 +8,6 @@
 import Foundation
 
 extension String {
-    private static let hexDumpNumberFormatter: NumberFormatter = {
-        let formatter = NumberFormatter()
-        formatter.numberStyle = .decimal
-        return formatter
-    }()
 
     /// Returns a classic hex dump representation of this string's bytes, or nil if empty.
     ///
@@ -70,7 +65,7 @@ extension String {
         }
 
         if totalCount > maxBytes {
-            let formattedTotal = Self.hexDumpNumberFormatter.string(from: NSNumber(value: totalCount)) ?? "\(totalCount)"
+            let formattedTotal = totalCount.formatted(.number)
             lines.append("... (truncated, \(formattedTotal) bytes total)")
         }
 

TablePro/Views/AIChat/AIChatPanelView.swift

@@ -45,7 +45,6 @@ struct AIChatPanelView: View {
         }
         .onAppear {
             viewModel.connection = connection
-            viewModel.tables = tables
         }
         .task(id: tables) {
             viewModel.tables = tables

TablePro/Views/Editor/HistoryPanelView.swift

@@ -303,7 +303,8 @@ private extension HistoryPanelView {
     }()
 
     func buildSecondaryMetadata(_ entry: QueryHistoryEntry) -> String {
-        var text = "Executed: \(Self.metadataDateFormatter.string(from: entry.executedAt))"
+        let executedAt = Self.metadataDateFormatter.string(from: entry.executedAt)
+        var text = String(localized: "Executed: \(executedAt)")
 
         if !entry.wasSuccessful, let error = entry.errorMessage {
             text += "\nError: \(error)"

TablePro/Views/Main/MainContentView.swift

@@ -785,7 +785,9 @@ struct MainContentView: View {
         let sessions = DatabaseManager.shared.activeSessions
         guard let session = sessions[connection.id] else { return }
         if session.isConnected && coordinator.needsLazyLoad {
-            guard !changeManager.hasChanges else { return }
+            let hasPendingEdits = changeManager.hasChanges
+                || (tabManager.selectedTab?.pendingChanges.hasChanges ?? false)
+            guard !hasPendingEdits else { return }
             coordinator.needsLazyLoad = false
             if let selectedTab = tabManager.selectedTab,
                !selectedTab.databaseName.isEmpty,