fix: address code review findings from PR #473

Author: datlechin

TablePro/AppDelegate+FileOpen.swift

@@ -210,8 +210,8 @@ extension AppDelegate {
 
     private func handleConnectionShareFile(_ url: URL) {
         openWelcomeWindow()
-        // Delay to ensure WelcomeWindowView's .onReceive is registered after window appears
-        DispatchQueue.main.async {
+        // Delay to ensure WelcomeWindowView's .onReceive is registered after window renders
+        DispatchQueue.main.asyncAfter(deadline: .now() + 0.3) {
             NotificationCenter.default.post(name: .connectionShareFileOpened, object: url)
         }
     }

TablePro/Core/Services/Export/ConnectionExportService.swift

@@ -155,16 +155,20 @@ enum ConnectionExportService {
             let aiPolicy: String? = connection.aiPolicy?.rawValue
 
             // Filter secure fields from additionalFields
-            var filteredFields = connection.additionalFields
-            let secureFieldIds = PluginMetadataRegistry.shared
-                .snapshot(forTypeId: connection.type.pluginTypeId)?
-                .connection.additionalConnectionFields
-                .filter(\.isSecure)
-                .map(\.id) ?? []
-            for fieldId in secureFieldIds {
-                filteredFields.removeValue(forKey: fieldId)
+            // If plugin metadata is unavailable, omit all fields to avoid leaking secrets
+            let additionalFields: [String: String]?
+            if let snapshot = PluginMetadataRegistry.shared.snapshot(forTypeId: connection.type.pluginTypeId) {
+                var filteredFields = connection.additionalFields
+                let secureFieldIds = snapshot.connection.additionalConnectionFields
+                    .filter(\.isSecure)
+                    .map(\.id)
+                for fieldId in secureFieldIds {
+                    filteredFields.removeValue(forKey: fieldId)
+                }
+                additionalFields = filteredFields.isEmpty ? nil : filteredFields
+            } else {
+                additionalFields = nil
             }
-            let additionalFields: [String: String]? = filteredFields.isEmpty ? nil : filteredFields
 
             let exportable = ExportableConnection(
                 name: connection.name,
@@ -222,10 +226,12 @@ enum ConnectionExportService {
         encoder.outputFormatting = [.prettyPrinted, .sortedKeys]
         encoder.dateEncodingStrategy = .iso8601
 
-        guard let data = try? encoder.encode(envelope) else {
+        do {
+            return try encoder.encode(envelope)
+        } catch {
+            logger.error("Encoding failed: \(error)")
             throw ConnectionExportError.encodingFailed
         }
-        return data
     }
 
     static func exportConnections(_ connections: [DatabaseConnection], to url: URL) throws {

TablePro/TableProApp.swift

@@ -239,11 +239,11 @@ struct AppMenuCommands: Commands {
 
             Divider()
 
-            Button("Export Connections...") {
+            Button(String(localized: "Export Connections...")) {
                 NotificationCenter.default.post(name: .exportConnections, object: nil)
             }
 
-            Button("Import Connections...") {
+            Button(String(localized: "Import Connections...")) {
                 NotificationCenter.default.post(name: .importConnections, object: nil)
             }
 

TablePro/Views/Connection/WelcomeWindowView.swift

@@ -518,7 +518,7 @@ struct WelcomeWindowView: View {
                         let envelope = ConnectionExportService.buildEnvelope(for: [connection])
                         let data = try ConnectionExportService.encode(envelope)
                         let tempURL = FileManager.default.temporaryDirectory
-                            .appendingPathComponent("\(connection.name).tablepro")
+                            .appendingPathComponent("\(connection.name)-\(connection.id.uuidString).tablepro")
                         try data.write(to: tempURL, options: .atomic)
                         completion(tempURL, true, nil)
                     } catch {