fix: batch delete favorites with single notification to prevent partial deletion

Author: datlechin

TablePro/Core/Storage/SQLFavoriteManager.swift

@@ -51,6 +51,18 @@ final class SQLFavoriteManager {
         return result
     }
 
+    func deleteFavorites(ids: [UUID]) async {
+        for id in ids {
+            let result = await storage.deleteFavorite(id: id)
+            if result {
+                SyncChangeTracker.shared.markDeleted(.favorite, id: id.uuidString)
+            }
+        }
+        if !ids.isEmpty {
+            postUpdateNotification()
+        }
+    }
+
     func fetchFavorites(
         connectionId: UUID? = nil,
         folderId: UUID? = nil,

TablePro/ViewModels/FavoritesSidebarViewModel.swift

@@ -128,6 +128,12 @@ final class FavoritesSidebarViewModel {
         }
     }
 
+    func deleteFavorites(_ favorites: [SQLFavorite]) {
+        Task {
+            await manager.deleteFavorites(ids: favorites.map(\.id))
+        }
+    }
+
     func createFolder(parentId: UUID? = nil) {
         if let parentId {
             expandedFolderIds.insert(parentId)

TablePro/Views/Sidebar/FavoritesTabView.swift

@@ -101,9 +101,8 @@ struct FavoritesTabView: View {
     private func deleteSelectedFavorites() {
         let allFavorites = collectFavorites(from: viewModel.treeItems)
         let toDelete = allFavorites.filter { selectedFavoriteIds.contains("fav-\($0.id)") }
-        for fav in toDelete {
-            viewModel.deleteFavorite(fav)
-        }
+        guard !toDelete.isEmpty else { return }
+        viewModel.deleteFavorites(toDelete)
         selectedFavoriteIds.removeAll()
     }