Address code review feedback

- Rename TableOperationType.delete to .drop for clarity
- Reset dialog state (ignoreForeignKeys, cascade) on open
- Restore pending operations on failure for retry capability
- Include SQLite in transaction wrapping
- Rename 'opts' variable to 'tableOptions' for readability
- Add note when multiple tables selected (same options apply to all)
- Use SET CONSTRAINTS ALL DEFERRED for PostgreSQL (no superuser required)

Author: datlechin

TablePro/Models/TableOperationOptions.swift

@@ -17,5 +17,5 @@ struct TableOperationOptions: Codable, Equatable {
 /// Type of table operation
 enum TableOperationType: String, Codable {
     case truncate
-    case delete
+    case drop
 }

TablePro/Views/Main/MainContentCoordinator.swift

@@ -613,8 +613,8 @@ final class MainContentCoordinator: ObservableObject {
             options[tableName]?.ignoreForeignKeys == true
         }
 
-        // Wrap in transaction for atomicity (except SQLite which handles differently)
-        let needsTransaction = (sortedTruncates.count + sortedDeletes.count) > 1 && dbType != .sqlite
+        // Wrap in transaction for atomicity
+        let needsTransaction = (sortedTruncates.count + sortedDeletes.count) > 1
         if needsTransaction {
             statements.append("BEGIN")
         }
@@ -625,14 +625,14 @@ final class MainContentCoordinator: ObservableObject {
 
         for tableName in sortedTruncates {
             let quotedName = dbType.quoteIdentifier(tableName)
-            let opts = options[tableName] ?? TableOperationOptions()
-            statements.append(truncateStatement(tableName: quotedName, options: opts, dbType: dbType))
+            let tableOptions = options[tableName] ?? TableOperationOptions()
+            statements.append(truncateStatement(tableName: quotedName, options: tableOptions, dbType: dbType))
         }
 
         for tableName in sortedDeletes {
             let quotedName = dbType.quoteIdentifier(tableName)
-            let opts = options[tableName] ?? TableOperationOptions()
-            statements.append(dropTableStatement(tableName: quotedName, options: opts, dbType: dbType))
+            let tableOptions = options[tableName] ?? TableOperationOptions()
+            statements.append(dropTableStatement(tableName: quotedName, options: tableOptions, dbType: dbType))
         }
 
         if needsDisableFK {
@@ -700,11 +700,16 @@ final class MainContentCoordinator: ObservableObject {
         let truncatedTables = Set(pendingTruncates)
         let conn = connection
 
-        // Clear operations immediately (before async execution)
+        // Capture options before clearing (for potential restore on failure)
+        var capturedOptions: [String: TableOperationOptions] = [:]
+        for table in deletedTables.union(truncatedTables) {
+            capturedOptions[table] = tableOperationOptions[table]
+        }
+
+        // Clear operations immediately (to prevent double-execution)
         if clearTableOps {
             pendingTruncates.removeAll()
             pendingDeletes.removeAll()
-            // Clear options for processed tables
             for table in deletedTables.union(truncatedTables) {
                 tableOperationOptions.removeValue(forKey: table)
             }
@@ -791,6 +796,17 @@ final class MainContentCoordinator: ObservableObject {
                     if let index = tabManager.selectedTabIndex {
                         tabManager.tabs[index].errorMessage = "Save failed: \(error.localizedDescription)"
                     }
+
+                    // Restore operations on failure so user can retry
+                    if clearTableOps {
+                        DatabaseManager.shared.updateSession(conn.id) { session in
+                            session.pendingTruncates = truncatedTables
+                            session.pendingDeletes = deletedTables
+                            for (table, opts) in capturedOptions {
+                                session.tableOperationOptions[table] = opts
+                            }
+                        }
+                    }
                 }
             }
         }

TablePro/Views/Sidebar/SidebarView.swift

@@ -321,7 +321,7 @@ struct SidebarView: View {
             pendingDeletes = updated
         } else {
             // Show dialog to confirm operation
-            pendingOperationType = .delete
+            pendingOperationType = .drop
             pendingOperationTables = tablesToToggle
             showOperationDialog = true
         }

TablePro/Views/Sidebar/TableOperationDialog.swift

@@ -28,8 +28,8 @@ struct TableOperationDialog: View {
 
     private var title: String {
         switch operationType {
-        case .delete:
-            return "Delete table '\(tableName)'"
+        case .drop:
+            return "Drop table '\(tableName)'"
         case .truncate:
             return "Truncate table '\(tableName)'"
         }
@@ -40,10 +40,14 @@ struct TableOperationDialog: View {
         databaseType != .sqlite
     }
 
+    private var isMultipleTables: Bool {
+        tableName.contains("tables")
+    }
+
     private var cascadeDescription: String {
         switch operationType {
-        case .delete:
-            return "Delete all rows linked by foreign keys"
+        case .drop:
+            return "Drop all tables that depend on this table"
         case .truncate:
             if databaseType == .mysql || databaseType == .mariadb {
                 return "Not supported for TRUNCATE in MySQL/MariaDB"
@@ -74,6 +78,13 @@ struct TableOperationDialog: View {
 
             // Options
             VStack(alignment: .leading, spacing: 16) {
+                // Note for multiple tables
+                if isMultipleTables {
+                    Text("Same options will be applied to all selected tables.")
+                        .font(.system(size: 11))
+                        .foregroundStyle(.secondary)
+                }
+
                 // Ignore foreign key checks
                 Toggle(isOn: $ignoreForeignKeys) {
                     Text("Ignore foreign key checks")
@@ -120,6 +131,11 @@ struct TableOperationDialog: View {
         }
         .frame(width: 320)
         .background(Color(nsColor: .windowBackgroundColor))
+        .onAppear {
+            // Reset state when dialog opens
+            ignoreForeignKeys = false
+            cascade = false
+        }
         .onExitCommand {
             isPresented = false
         }
@@ -137,11 +153,11 @@ struct TableOperationDialog: View {
 
 // MARK: - Preview
 
-#Preview("Delete Table - MySQL") {
+#Preview("Drop Table - MySQL") {
     TableOperationDialog(
         isPresented: .constant(true),
         tableName: "users",
-        operationType: .delete,
+        operationType: .drop,
         databaseType: .mysql,
         onConfirm: { options in
             print("Options: \(options)")
@@ -161,11 +177,11 @@ struct TableOperationDialog: View {
     )
 }
 
-#Preview("Delete Table - SQLite") {
+#Preview("Drop Table - SQLite") {
     TableOperationDialog(
         isPresented: .constant(true),
         tableName: "products",
-        operationType: .delete,
+        operationType: .drop,
         databaseType: .sqlite,
         onConfirm: { options in
             print("Options: \(options)")