fix: use correct error message when user-installed plugin is outdated (#518)

Author: datlechin

TablePro/Core/Plugins/PluginError.swift

@@ -10,6 +10,7 @@ enum PluginError: LocalizedError {
     case signatureInvalid(detail: String)
     case checksumMismatch
     case incompatibleVersion(required: Int, current: Int)
+    case pluginOutdated(pluginVersion: Int, requiredVersion: Int)
     case cannotUninstallBuiltIn
     case notFound
     case noCompatibleBinary
@@ -31,6 +32,8 @@ enum PluginError: LocalizedError {
             return String(localized: "Plugin checksum does not match expected value")
         case .incompatibleVersion(let required, let current):
             return String(localized: "Plugin requires PluginKit version \(required), but app provides version \(current)")
+        case .pluginOutdated(let pluginVersion, let requiredVersion):
+            return String(localized: "Plugin was built with PluginKit version \(pluginVersion), but version \(requiredVersion) is required. Please update the plugin.")
         case .cannotUninstallBuiltIn:
             return String(localized: "Built-in plugins cannot be uninstalled")
         case .notFound:

TablePro/Core/Plugins/PluginManager.swift

@@ -182,7 +182,7 @@ final class PluginManager {
 
             if entry.source == .userInstalled {
                 if pluginKitVersion < currentPluginKitVersion {
-                    logger.error("User plugin \(entry.url.lastPathComponent) has outdated PluginKit v\(pluginKitVersion)")
+                    logger.error("User plugin \(entry.url.lastPathComponent) was built with PluginKit v\(pluginKitVersion), but v\(currentPluginKitVersion) is required")
                     continue
                 }
             }
@@ -383,9 +383,9 @@ final class PluginManager {
             // have stale witness tables — accessing protocol properties crashes with
             // EXC_BAD_ACCESS. Reject them before loading the bundle.
             if pluginKitVersion < Self.currentPluginKitVersion {
-                throw PluginError.incompatibleVersion(
-                    required: Self.currentPluginKitVersion,
-                    current: pluginKitVersion
+                throw PluginError.pluginOutdated(
+                    pluginVersion: pluginKitVersion,
+                    requiredVersion: Self.currentPluginKitVersion
                 )
             }
             try verifyCodeSignature(bundle: bundle)
@@ -419,9 +419,9 @@ final class PluginManager {
 
         if source == .userInstalled {
             if pluginKitVersion < Self.currentPluginKitVersion {
-                throw PluginError.incompatibleVersion(
-                    required: Self.currentPluginKitVersion,
-                    current: pluginKitVersion
+                throw PluginError.pluginOutdated(
+                    pluginVersion: pluginKitVersion,
+                    requiredVersion: Self.currentPluginKitVersion
                 )
             }
             try verifyCodeSignature(bundle: bundle)

TablePro/Resources/Localizable.xcstrings

@@ -9393,9 +9393,6 @@
           }
         }
       }
-    },
-    "DataGridView placeholder for: %@" : {
-
     },
     "Date format:" : {
       "localizations" : {
@@ -14166,9 +14163,6 @@
           }
         }
       }
-    },
-    "Fix with AI" : {
-
     },
     "Focus Border" : {
       "localizations" : {
@@ -25645,6 +25639,9 @@
           }
         }
       }
+    },
+    "Results" : {
+
     },
     "Retention" : {
       "localizations" : {
@@ -26102,9 +26099,6 @@
           }
         }
       }
-    },
-    "Run a query to see results" : {
-
     },
     "Run in New Tab" : {
       "localizations" : {
@@ -32302,6 +32296,9 @@
     },
     "Toggle Results" : {
 
+    },
+    "Toggle Results (⌘⌥R)" : {
+
     },
     "Toggle Table Browser" : {
       "localizations" : {