test: add NSView focus tests and fix pre-existing test compilation errors

Author: datlechin

TableProTests/Core/ChangeTracking/DataChangeManagerExtendedTests.swift

@@ -240,7 +240,7 @@ struct DataChangeManagerExtendedTests {
         let state = manager.saveState()
         manager.clearChanges()
         #expect(!manager.hasChanges)
-        manager.restoreState(from: state, tableName: "test_table")
+        manager.restoreState(from: state, tableName: "test_table", databaseType: .mysql)
         #expect(manager.hasChanges)
     }
 
@@ -250,7 +250,7 @@ struct DataChangeManagerExtendedTests {
         manager.recordRowDeletion(rowIndex: 2, originalRow: ["3", "Charlie", "c@test.com"])
         let state = manager.saveState()
         manager.clearChanges()
-        manager.restoreState(from: state, tableName: "test_table")
+        manager.restoreState(from: state, tableName: "test_table", databaseType: .mysql)
         #expect(manager.isRowDeleted(2))
     }
 
@@ -263,7 +263,7 @@ struct DataChangeManagerExtendedTests {
         )
         let state = manager.saveState()
         manager.clearChanges()
-        manager.restoreState(from: state, tableName: "test_table")
+        manager.restoreState(from: state, tableName: "test_table", databaseType: .mysql)
         #expect(manager.isCellModified(rowIndex: 0, columnIndex: 1))
     }
 
@@ -276,7 +276,7 @@ struct DataChangeManagerExtendedTests {
         )
         let state = manager.saveState()
         manager.clearChanges()
-        manager.restoreState(from: state, tableName: "test_table")
+        manager.restoreState(from: state, tableName: "test_table", databaseType: .mysql)
         manager.recordCellChange(
             rowIndex: 0, columnIndex: 2, columnName: "email",
             oldValue: "a@test.com", newValue: "b@test.com"
@@ -289,7 +289,7 @@ struct DataChangeManagerExtendedTests {
     func emptyStateRoundTrip() {
         let manager = makeManager()
         let state = manager.saveState()
-        manager.restoreState(from: state, tableName: "test_table")
+        manager.restoreState(from: state, tableName: "test_table", databaseType: .mysql)
         #expect(!manager.hasChanges)
         #expect(manager.changes.isEmpty)
     }

TableProTests/Core/ChangeTracking/SQLStatementGeneratorMSSQLTests.swift

@@ -23,7 +23,7 @@ struct SQLStatementGeneratorMSSQLTests {
             columns: columns,
             primaryKeyColumn: primaryKeyColumn,
             databaseType: .mssql,
-            dialect: PluginManager.shared.sqlDialect(for: .mssql)
+            dialect: nil
         )
     }
 

TableProTests/Core/ChangeTracking/SQLStatementGeneratorNoPKTests.swift

@@ -24,7 +24,7 @@ struct SQLStatementGeneratorNoPKTests {
             columns: columns,
             primaryKeyColumn: primaryKeyColumn,
             databaseType: databaseType,
-            dialect: PluginManager.shared.sqlDialect(for: databaseType)
+            dialect: nil
         )
     }
 

TableProTests/Core/ChangeTracking/SQLStatementGeneratorPKRegressionTests.swift

@@ -22,7 +22,7 @@ struct SQLStatementGeneratorPKRegressionTests {
             columns: columns,
             primaryKeyColumn: primaryKeyColumn,
             databaseType: databaseType,
-            dialect: PluginManager.shared.sqlDialect(for: databaseType)
+            dialect: nil
         )
     }
 

TableProTests/Core/ChangeTracking/SQLStatementGeneratorParameterStyleTests.swift

@@ -28,7 +28,7 @@ struct SQLStatementGeneratorParameterStyleTests {
             primaryKeyColumn: primaryKeyColumn,
             databaseType: databaseType,
             parameterStyle: parameterStyle,
-            dialect: PluginManager.shared.sqlDialect(for: databaseType)
+            dialect: nil
         )
     }
 

TableProTests/Core/ChangeTracking/SQLStatementGeneratorTests.swift

@@ -25,7 +25,7 @@ struct SQLStatementGeneratorTests {
             columns: columns,
             primaryKeyColumn: primaryKeyColumn,
             databaseType: databaseType,
-            dialect: PluginManager.shared.sqlDialect(for: databaseType)
+            dialect: nil
         )
     }
 

TableProTests/Extensions/NSViewFocusTests.swift

@@ -0,0 +1,92 @@
+//
+//  NSViewFocusTests.swift
+//  TableProTests
+//
+
+import AppKit
+import Testing
+@testable import TablePro
+
+@Suite("NSView+Focus")
+struct NSViewFocusTests {
+    @Test("Returns nil for empty container view")
+    func emptyView() {
+        let container = NSView(frame: .zero)
+        #expect(container.firstEditableTextField() == nil)
+    }
+
+    @Test("Finds direct editable text field")
+    func directTextField() {
+        let textField = NSTextField(frame: .zero)
+        #expect(textField.firstEditableTextField() === textField)
+    }
+
+    @Test("Finds editable text field in subviews")
+    func nestedTextField() {
+        let container = NSView(frame: .zero)
+        let child = NSView(frame: .zero)
+        let textField = NSTextField(frame: .zero)
+        child.addSubview(textField)
+        container.addSubview(child)
+        #expect(container.firstEditableTextField() === textField)
+    }
+
+    @Test("Skips non-editable text field")
+    func skipsNonEditable() {
+        let container = NSView(frame: .zero)
+        let label = NSTextField(labelWithString: "Label")
+        container.addSubview(label)
+        #expect(container.firstEditableTextField() == nil)
+    }
+
+    @Test("Returns first editable text field in depth-first order")
+    func depthFirstOrder() {
+        let container = NSView(frame: .zero)
+        let first = NSTextField(frame: .zero)
+        let second = NSTextField(frame: .zero)
+        container.addSubview(first)
+        container.addSubview(second)
+
+        let found = container.firstEditableTextField()
+        #expect(found === first)
+    }
+
+    @Test("Finds editable text field among mixed subviews")
+    func mixedSubviews() {
+        let container = NSView(frame: .zero)
+        let button = NSButton(frame: .zero)
+        let label = NSTextField(labelWithString: "Label")
+        let editable = NSTextField(frame: .zero)
+
+        container.addSubview(button)
+        container.addSubview(label)
+        container.addSubview(editable)
+
+        #expect(container.firstEditableTextField() === editable)
+    }
+
+    @Test("Returns nil when only non-editable text fields exist")
+    func onlyLabels() {
+        let container = NSView(frame: .zero)
+        let label1 = NSTextField(labelWithString: "A")
+        let label2 = NSTextField(labelWithString: "B")
+        container.addSubview(label1)
+        container.addSubview(label2)
+        #expect(container.firstEditableTextField() == nil)
+    }
+
+    @Test("Finds deeply nested text field")
+    func deeplyNested() {
+        let root = NSView(frame: .zero)
+        var current = root
+        for _ in 0 ..< 5 {
+            let child = NSView(frame: .zero)
+            current.addSubview(child)
+            current = child
+        }
+        let textField = NSTextField(frame: .zero)
+        current.addSubview(textField)
+
+        #expect(root.firstEditableTextField() === textField)
+    }
+}