Merge branch 'main' into feat/cassandra-support

Author: datlechin

.claude/skills/write-tests/SKILL.md

@@ -304,6 +304,7 @@ private func makeCoordinator(database: String = "db_a", type: DatabaseType = .my
         tabManager: QueryTabManager(),
         changeManager: DataChangeManager(),
         filterStateManager: FilterStateManager(),
+        columnVisibilityManager: ColumnVisibilityManager(),
         toolbarState: ConnectionToolbarState()
     )
 }

CHANGELOG.md

@@ -9,15 +9,31 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Changed
 
+- Redesigned Plugins settings tab with HSplitView master-detail layout: plugin list on the left, detail pane on the right, matching macOS conventions
+- Replaced ~40 hardcoded `DatabaseType` switches across ~20 UI files with dynamic plugin property lookups via `PluginManager`, so third-party plugins get correct UI behavior (colors, labels, editor language, feature toggles) automatically
+- ConnectionFormView now fully dynamic: pgpass toggle, password visibility, and SSH/SSL tab visibility all driven by plugin metadata (`FieldSection`, `hidesPassword`, `supportsSSH`/`supportsSSL`) instead of hardcoded type checks
+- Replaced `AppState.isMongoDB`/`isRedis` booleans with `AppState.editorLanguage: EditorLanguage` for extensible editor language detection
+- Theme colors now derived from plugin `brandColorHex` instead of hardcoded `Theme.mysqlColor` etc.
+- Sidebar labels ("Tables"/"Collections"/"Keys"), toolbar preview labels, and AI prompt language detection now use plugin metadata
+- Connection form, database switcher, type picker, file open handler, and toolbar all use plugin lookups for connection mode, authentication, import support, and system database names
+- Converted `DatabaseType` from closed enum to string-based struct, enabling future plugin-defined database types
 - Moved string literal escaping into plugin drivers via `escapeStringLiteral` on `PluginDatabaseDriver` and `DatabaseDriver` protocols; `SQLEscaping.escapeStringLiteral` now uses ANSI SQL escaping only (doubles single quotes, strips null bytes)
 - SQL autocomplete data types and CREATE TABLE options now use plugin-provided dialect data instead of hardcoded per-database switches
 - `FilterSQLGenerator` now uses `SQLDialectDescriptor` data (regex syntax, boolean literals, LIKE escape style, pagination style) instead of `DatabaseType` switch statements
+- Moved identifier quoting, autocomplete statement completions, view templates, and FK disable/enable into plugin system
+- Removed `DatabaseType` switches from `FilterSQLGenerator`, `SQLCompletionProvider`, `ImportDataSinkAdapter`, and `MainContentCoordinator+SidebarActions`
+- Replaced hardcoded `DatabaseType` switches in ExportDialog, DataChangeManager, SafeModeGuard, ExportService, DataGridView, HighlightedSQLTextView, ForeignKeyPopoverContentView, QueryTab, SQLRowToStatementConverter, SessionStateFactory, ConnectionToolbarState, and DatabaseSwitcherSheet with dynamic plugin lookups (`databaseGroupingStrategy`, `immutableColumns`, `supportsReadOnlyMode`, `paginationStyle`, `editorLanguage`, `connectionMode`, `supportsSchemaSwitching`)
+- Replaced remaining ~40 hardcoded `DatabaseType` switches in MainContentCoordinator (main + 5 extensions) and StructureRowProvider with plugin metadata lookups (`requiresReconnectForDatabaseSwitch`, `structureColumnFields`, `defaultPrimaryKeyColumn`, `supportsQueryProgress`, `autoLimitStyle`, `allTablesMetadataSQL`)
 
 ### Added
 
+- Column visibility: toggle individual columns on/off via "Columns" button in the status bar or right-click header context menu "Hide Column", with per-tab and per-table persistence
 - `SQLDialectDescriptor` in TableProPluginKit: plugins can now self-describe their SQL dialect (keywords, functions, data types, identifier quoting), with `SQLDialectFactory` preferring plugin-provided dialect info over built-in structs
 - DDL schema generation protocol in TableProPluginKit: plugins can now optionally provide database-specific ALTER TABLE syntax (ADD/MODIFY/DROP COLUMN, ADD/DROP INDEX, ADD/DROP FK, MODIFY PK) via `PluginDatabaseDriver`, with `SchemaStatementGenerator` trying plugin methods first before falling back to built-in logic
 - Plugin-provided table operations: `truncateTableStatements`, `dropObjectStatement`, `foreignKeyDisableStatements`, `foreignKeyEnableStatements` in `PluginDatabaseDriver` protocol, allowing plugins to override TRUNCATE, DROP, and FK handling SQL
+- `CompletionEntry` struct and `statementCompletions` on `DriverPlugin` for plugin-provided autocomplete entries (MongoDB MQL methods, Redis commands)
+- `offsetFetchOrderBy` property on `SQLDialectDescriptor` for plugin-controlled ORDER BY in OFFSET/FETCH pagination
+- `createViewTemplate()`, `editViewFallbackTemplate(viewName:)`, and `castColumnToText(_:)` on `PluginDatabaseDriver` for plugin-provided view DDL templates and column casting
 - `buildExplainQuery` method in `PluginDatabaseDriver` protocol: plugins can now provide database-specific EXPLAIN syntax, with coordinator falling back to built-in logic when plugin returns nil
 - `SettablePlugin` protocol in TableProPluginKit SDK: unified settings pattern for all plugins with automatic persistence via `loadSettings()`/`saveSettings()`, replacing duplicated boilerplate across export/import/driver plugins
 - Plugin UI/capability metadata: each driver plugin now self-declares brand color, connection mode, supported features, column types, URL schemes, and grouping strategy via the `DriverPlugin` protocol
@@ -27,6 +43,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - SQL import options (wrap in transaction, disable FK checks) now persist across launches
 - `needsRestart` banner persists across app quit/relaunch after plugin uninstall
 - Copy as INSERT/UPDATE SQL statements from data grid context menu
+- Configurable font family and size for data grid (Settings > Data Grid > Font)
 - Plugin download count display in Browse Plugins — fetched from GitHub Releases API and cached for 1 hour
 - MSSQL query cancellation (`cancelQuery`) and lock timeout (`applyQueryTimeout`) support
 - `~/.pgpass` file support for PostgreSQL/Redshift connections with live validation in the connection form

CLAUDE.md

@@ -70,6 +70,14 @@ When adding a new driver: create a new plugin bundle under `Plugins/`, implement
 
 When adding a new method to the driver protocol: add to `PluginDatabaseDriver` (with default implementation), then update `PluginDriverAdapter` to bridge it to `DatabaseDriver`.
 
+### DatabaseType (String-Based Struct)
+
+`DatabaseType` is a string-based struct (not an enum). Key rules:
+- All `switch` statements on `DatabaseType` must include `default:` — the type is open
+- Use static constants (`.mysql`, `.postgresql`) for known types
+- Unknown types (from future plugins) are valid — they round-trip through Codable
+- Use `DatabaseType.allKnownTypes` (not `allCases`) for the canonical list of built-in types
+
 ### Editor Architecture (CodeEditSourceEditor)
 
 - **`SQLEditorTheme`** — single source of truth for editor colors/fonts

Plugins/ClickHouseDriverPlugin/ClickHousePlugin.swift

@@ -42,6 +42,9 @@ final class ClickHousePlugin: NSObject, TableProPlugin, DriverPlugin {
         "Geo": ["Point", "Ring", "Polygon", "MultiPolygon"]
     ]
 
+    static let structureColumnFields: [StructureColumnField] = [.name, .type, .nullable, .defaultValue, .comment]
+    static let supportsQueryProgress = true
+
     static let sqlDialect: SQLDialectDescriptor? = SQLDialectDescriptor(
         identifierQuote: "`",
         keywords: [
@@ -91,7 +94,8 @@ final class ClickHousePlugin: NSObject, TableProPlugin, DriverPlugin {
         regexSyntax: .match,
         booleanLiteralStyle: .numeric,
         likeEscapeStyle: .implicit,
-        paginationStyle: .limit
+        paginationStyle: .limit,
+        requiresBackslashEscaping: true
     )
 
     func createDriver(config: DriverConnectionConfig) -> any PluginDatabaseDriver {
@@ -570,6 +574,23 @@ final class ClickHousePluginDriver: PluginDatabaseDriver, @unchecked Sendable {
         _ = try await execute(query: "CREATE DATABASE `\(escapedName)`")
     }
 
+    // MARK: - All Tables Metadata
+
+    func allTablesMetadataSQL(schema: String?) -> String? {
+        """
+        SELECT
+            database as `schema`,
+            name,
+            engine as kind,
+            total_rows as estimated_rows,
+            formatReadableSize(total_bytes) as total_size,
+            comment
+        FROM system.tables
+        WHERE database = currentDatabase()
+        ORDER BY name
+        """
+    }
+
     // MARK: - DML Statement Generation
 
     func generateStatements(
@@ -724,6 +745,17 @@ final class ClickHousePluginDriver: PluginDatabaseDriver, @unchecked Sendable {
         "EXPLAIN \(sql)"
     }
 
+    // MARK: - View Templates
+
+    func createViewTemplate() -> String? {
+        "CREATE VIEW view_name AS\nSELECT column1, column2\nFROM table_name\nWHERE condition;"
+    }
+
+    func editViewFallbackTemplate(viewName: String) -> String? {
+        let quoted = quoteIdentifier(viewName)
+        return "CREATE OR REPLACE VIEW \(quoted) AS\nSELECT * FROM table_name;"
+    }
+
     // MARK: - Kill Query
 
     private func killQuery(queryId: String) {

Plugins/DuckDBDriverPlugin/DuckDBPlugin.swift

@@ -24,7 +24,7 @@ final class DuckDBPlugin: NSObject, TableProPlugin, DriverPlugin {
     static let requiresAuthentication = false
     static let connectionMode: ConnectionMode = .fileBased
     static let urlSchemes: [String] = ["duckdb"]
-    static let fileExtensions: [String] = ["duckdb", "db"]
+    static let fileExtensions: [String] = ["duckdb", "ddb"]
     static let brandColorHex = "#FFD900"
     static let supportsDatabaseSwitching = false
     static let systemDatabaseNames: [String] = ["information_schema", "pg_catalog"]
@@ -821,6 +821,32 @@ final class DuckDBPluginDriver: PluginDatabaseDriver, @unchecked Sendable {
         "EXPLAIN \(sql)"
     }
 
+    // MARK: - View Templates
+
+    func createViewTemplate() -> String? {
+        "CREATE OR REPLACE VIEW view_name AS\nSELECT column1, column2\nFROM table_name\nWHERE condition;"
+    }
+
+    func editViewFallbackTemplate(viewName: String) -> String? {
+        let quoted = quoteIdentifier(viewName)
+        return "CREATE OR REPLACE VIEW \(quoted) AS\nSELECT * FROM table_name;"
+    }
+
+    // MARK: - All Tables Metadata
+
+    func allTablesMetadataSQL(schema: String?) -> String? {
+        let s = schema ?? currentSchema ?? "main"
+        return """
+        SELECT
+            table_schema as schema_name,
+            table_name as name,
+            table_type as kind
+        FROM information_schema.tables
+        WHERE table_schema = '\(s)'
+        ORDER BY table_name
+        """
+    }
+
     // MARK: - Private Helpers
 
     nonisolated private func setInterruptHandle(_ handle: duckdb_connection?) {

Plugins/MSSQLDriverPlugin/MSSQLPlugin.swift

@@ -26,6 +26,7 @@ final class MSSQLPlugin: NSObject, TableProPlugin, DriverPlugin {
 
     static let brandColorHex = "#E34517"
     static let systemDatabaseNames: [String] = ["master", "tempdb", "model", "msdb"]
+    static let defaultSchemaName = "dbo"
     static let databaseGroupingStrategy: GroupingStrategy = .bySchema
     static let columnTypesByCategory: [String: [String]] = [
         "Integer": ["TINYINT", "SMALLINT", "INT", "BIGINT"],
@@ -87,7 +88,8 @@ final class MSSQLPlugin: NSObject, TableProPlugin, DriverPlugin {
         regexSyntax: .unsupported,
         booleanLiteralStyle: .numeric,
         likeEscapeStyle: .explicit,
-        paginationStyle: .offsetFetch
+        paginationStyle: .offsetFetch,
+        autoLimitStyle: .top
     )
 
     func createDriver(config: DriverConnectionConfig) -> any PluginDatabaseDriver {
@@ -428,6 +430,21 @@ final class MSSQLPluginDriver: PluginDatabaseDriver, @unchecked Sendable {
         return "[\(escaped)]"
     }
 
+    // MARK: - View Templates
+
+    func createViewTemplate() -> String? {
+        "CREATE OR ALTER VIEW view_name AS\nSELECT column1, column2\nFROM table_name\nWHERE condition;"
+    }
+
+    func editViewFallbackTemplate(viewName: String) -> String? {
+        let quoted = quoteIdentifier(viewName)
+        return "CREATE OR ALTER VIEW \(quoted) AS\nSELECT * FROM table_name;"
+    }
+
+    func castColumnToText(_ column: String) -> String {
+        "CAST(\(column) AS NVARCHAR(MAX))"
+    }
+
     init(config: DriverConnectionConfig) {
         self.config = config
         self._currentSchema = config.additionalFields["mssqlSchema"]?.isEmpty == false
@@ -1160,6 +1177,27 @@ final class MSSQLPluginDriver: PluginDatabaseDriver, @unchecked Sendable {
         _ = try await execute(query: "CREATE DATABASE \(quotedName)")
     }
 
+    // MARK: - All Tables Metadata
+
+    func allTablesMetadataSQL(schema: String?) -> String? {
+        """
+        SELECT
+            s.name as schema_name,
+            t.name as name,
+            CASE WHEN v.object_id IS NOT NULL THEN 'VIEW' ELSE 'TABLE' END as kind,
+            p.rows as estimated_rows,
+            CAST(ROUND(SUM(a.total_pages) * 8 / 1024.0, 2) AS VARCHAR) + ' MB' as total_size
+        FROM sys.tables t
+        INNER JOIN sys.schemas s ON t.schema_id = s.schema_id
+        INNER JOIN sys.indexes i ON t.object_id = i.object_id AND i.index_id IN (0, 1)
+        INNER JOIN sys.partitions p ON i.object_id = p.object_id AND i.index_id = p.index_id
+        INNER JOIN sys.allocation_units a ON p.partition_id = a.container_id
+        LEFT JOIN sys.views v ON t.object_id = v.object_id
+        GROUP BY s.name, t.name, p.rows, v.object_id
+        ORDER BY t.name
+        """
+    }
+
     // MARK: - Query Building
 
     func buildBrowseQuery(

Plugins/MongoDBDriverPlugin/MongoDBPlugin.swift

@@ -53,6 +53,10 @@ final class MongoDBPlugin: NSObject, TableProPlugin, DriverPlugin {
     static let supportsForeignKeys = false
     static let supportsSchemaEditing = false
     static let systemDatabaseNames: [String] = ["admin", "local", "config"]
+    static let tableEntityName = "Collections"
+    static let supportsForeignKeyDisable = false
+    static let immutableColumns: [String] = ["_id"]
+    static let supportsReadOnlyMode = false
     static let databaseGroupingStrategy: GroupingStrategy = .flat
     static let columnTypesByCategory: [String: [String]] = [
         "String": ["string", "objectId", "regex"],
@@ -66,8 +70,38 @@ final class MongoDBPlugin: NSObject, TableProPlugin, DriverPlugin {
         "Other": ["javascript", "minKey", "maxKey"]
     ]
 
+    static let structureColumnFields: [StructureColumnField] = [.name, .type, .nullable]
+    static let defaultPrimaryKeyColumn: String? = "_id"
+
     static let sqlDialect: SQLDialectDescriptor? = nil
 
+    static var statementCompletions: [CompletionEntry] {
+        [
+            CompletionEntry(label: "db.", insertText: "db."),
+            CompletionEntry(label: "db.runCommand", insertText: "db.runCommand"),
+            CompletionEntry(label: "db.adminCommand", insertText: "db.adminCommand"),
+            CompletionEntry(label: "db.createView", insertText: "db.createView"),
+            CompletionEntry(label: "db.createCollection", insertText: "db.createCollection"),
+            CompletionEntry(label: "show dbs", insertText: "show dbs"),
+            CompletionEntry(label: "show collections", insertText: "show collections"),
+            CompletionEntry(label: ".find", insertText: ".find"),
+            CompletionEntry(label: ".findOne", insertText: ".findOne"),
+            CompletionEntry(label: ".aggregate", insertText: ".aggregate"),
+            CompletionEntry(label: ".insertOne", insertText: ".insertOne"),
+            CompletionEntry(label: ".insertMany", insertText: ".insertMany"),
+            CompletionEntry(label: ".updateOne", insertText: ".updateOne"),
+            CompletionEntry(label: ".updateMany", insertText: ".updateMany"),
+            CompletionEntry(label: ".deleteOne", insertText: ".deleteOne"),
+            CompletionEntry(label: ".deleteMany", insertText: ".deleteMany"),
+            CompletionEntry(label: ".replaceOne", insertText: ".replaceOne"),
+            CompletionEntry(label: ".findOneAndUpdate", insertText: ".findOneAndUpdate"),
+            CompletionEntry(label: ".findOneAndReplace", insertText: ".findOneAndReplace"),
+            CompletionEntry(label: ".findOneAndDelete", insertText: ".findOneAndDelete"),
+            CompletionEntry(label: ".countDocuments", insertText: ".countDocuments"),
+            CompletionEntry(label: ".createIndex", insertText: ".createIndex")
+        ]
+    }
+
     func createDriver(config: DriverConnectionConfig) -> any PluginDatabaseDriver {
         MongoDBPluginDriver(config: config)
     }

Plugins/MongoDBDriverPlugin/MongoDBPluginDriver.swift

@@ -499,6 +499,17 @@ final class MongoDBPluginDriver: PluginDatabaseDriver {
         }
     }
 
+    // MARK: - View Templates
+
+    func createViewTemplate() -> String? {
+        "db.createView(\"view_name\", \"source_collection\", [\n  {\"$match\": {}},\n  {\"$project\": {\"_id\": 1}}\n])"
+    }
+
+    func editViewFallbackTemplate(viewName: String) -> String? {
+        let escaped = viewName.replacingOccurrences(of: "\"", with: "\\\"")
+        return "db.runCommand({\"collMod\": \"\(escaped)\", \"viewOn\": \"source_collection\", \"pipeline\": [{\"$match\": {}}]})"
+    }
+
     // MARK: - Query Building
 
     func buildBrowseQuery(

Plugins/MySQLDriverPlugin/MySQLPlugin.swift

@@ -81,7 +81,8 @@ final class MySQLPlugin: NSObject, TableProPlugin, DriverPlugin {
         regexSyntax: .regexp,
         booleanLiteralStyle: .numeric,
         likeEscapeStyle: .implicit,
-        paginationStyle: .limit
+        paginationStyle: .limit,
+        requiresBackslashEscaping: true
     )
 
     func createDriver(config: DriverConnectionConfig) -> any PluginDatabaseDriver {

Plugins/MySQLDriverPlugin/MySQLPluginDriver.swift

@@ -602,6 +602,54 @@ final class MySQLPluginDriver: PluginDatabaseDriver, @unchecked Sendable {
         "EXPLAIN \(sql)"
     }
 
+    // MARK: - View Templates
+
+    func createViewTemplate() -> String? {
+        "CREATE VIEW view_name AS\nSELECT column1, column2\nFROM table_name\nWHERE condition;"
+    }
+
+    func editViewFallbackTemplate(viewName: String) -> String? {
+        let quoted = quoteIdentifier(viewName)
+        return "ALTER VIEW \(quoted) AS\nSELECT * FROM table_name;"
+    }
+
+    func castColumnToText(_ column: String) -> String {
+        "CAST(\(column) AS CHAR)"
+    }
+
+    // MARK: - Foreign Key Checks
+
+    func foreignKeyDisableStatements() -> [String]? {
+        ["SET FOREIGN_KEY_CHECKS=0"]
+    }
+
+    func foreignKeyEnableStatements() -> [String]? {
+        ["SET FOREIGN_KEY_CHECKS=1"]
+    }
+
+    // MARK: - All Tables Metadata
+
+    func allTablesMetadataSQL(schema: String?) -> String? {
+        """
+        SELECT
+            TABLE_SCHEMA as `schema`,
+            TABLE_NAME as name,
+            TABLE_TYPE as kind,
+            IFNULL(CCSA.CHARACTER_SET_NAME, '') as charset,
+            TABLE_COLLATION as collation,
+            TABLE_ROWS as estimated_rows,
+            CONCAT(ROUND((DATA_LENGTH + INDEX_LENGTH) / 1024 / 1024, 2), ' MB') as total_size,
+            CONCAT(ROUND(DATA_LENGTH / 1024 / 1024, 2), ' MB') as data_size,
+            CONCAT(ROUND(INDEX_LENGTH / 1024 / 1024, 2), ' MB') as index_size,
+            TABLE_COMMENT as comment
+        FROM information_schema.TABLES
+        LEFT JOIN information_schema.COLLATION_CHARACTER_SET_APPLICABILITY CCSA
+            ON TABLE_COLLATION = CCSA.COLLATION_NAME
+        WHERE TABLE_SCHEMA = DATABASE()
+        ORDER BY TABLE_NAME
+        """
+    }
+
     // MARK: - Private Helpers
 
     private func extractTableName(from query: String) -> String? {