Merge pull request #256 from datlechin/feat/plugin-system-phase2-security-performance

feat: implement plugin system

Author: datlechin

CHANGELOG.md

@@ -14,8 +14,19 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Redis sidebar click showing data briefly then going empty due to double-navigation race condition (#251)
 - MongoDB showing "Invalid database name: ''" when connecting without a database name
 
+### Changed
+
+- NoSQL query building moved from Core to MongoDB/Redis plugins via optional `PluginDatabaseDriver` protocol methods
+- Standardized parameter binding across all database drivers with improved default escaping (type-aware numeric handling, NUL byte stripping, NULL literal support)
+
 ### Added
 
+- True prepared statements for MSSQL (`sp_executesql`) and ClickHouse (HTTP query parameters), eliminating string interpolation for parameterized queries
+- Batch query operations for MSSQL, Oracle, and ClickHouse, eliminating N+1 query patterns for column, foreign key, and database metadata fetching; SQLite adds a batched `fetchAllForeignKeys` override within PRAGMA limitations
+- `PluginDriverError` protocol in TableProPluginKit for structured error reporting from driver plugins, with richer connection error messages showing error codes and SQL states
+- `pluginDispatchAsync` concurrency helper in TableProPluginKit for standardized async bridging in plugins
+- Shared `PluginRowLimits` constant in TableProPluginKit with 100K row default, enforced across all 8 driver plugins (ClickHouse, MSSQL, Oracle previously had no cap)
+- `driverVariant(for:)` method on `DriverPlugin` protocol for dynamic multi-type plugin dispatch, replacing hardcoded variant mapping
 - Safe mode levels: per-connection setting with 6 levels (Silent, Alert, Alert Full, Safe Mode, Safe Mode Full, Read-Only) replacing the boolean read-only toggle, with confirmation dialogs and Touch ID/password authentication for stricter levels
 - Preview tabs: single-click opens a temporary preview tab, double-click or editing promotes it to a permanent tab
 - Import plugin system: SQL import extracted into a `.tableplugin` bundle, matching the export plugin architecture

Plugins/ClickHouseDriverPlugin/ClickHousePlugin.swift

@@ -25,10 +25,11 @@ final class ClickHousePlugin: NSObject, TableProPlugin, DriverPlugin {
 
 // MARK: - Error Types
 
-private struct ClickHouseError: Error, LocalizedError {
+private struct ClickHouseError: Error, PluginDriverError {
     let message: String
 
     var errorDescription: String? { "ClickHouse Error: \(message)" }
+    var pluginErrorMessage: String { message }
 
     static let notConnected = ClickHouseError(message: "Not connected to database")
     static let connectionFailed = ClickHouseError(message: "Failed to establish connection")
@@ -142,6 +143,26 @@ final class ClickHousePluginDriver: PluginDatabaseDriver, @unchecked Sendable {
         )
     }
 
+    func executeParameterized(query: String, parameters: [String?]) async throws -> PluginQueryResult {
+        guard !parameters.isEmpty else {
+            return try await execute(query: query)
+        }
+
+        let startTime = Date()
+        let queryId = UUID().uuidString
+        let (convertedQuery, paramMap) = Self.buildClickHouseParams(query: query, parameters: parameters)
+        let result = try await executeRawWithParams(convertedQuery, params: paramMap, queryId: queryId)
+        let executionTime = Date().timeIntervalSince(startTime)
+
+        return PluginQueryResult(
+            columns: result.columns,
+            columnTypeNames: result.columnTypeNames,
+            rows: result.rows,
+            rowsAffected: result.affectedRows,
+            executionTime: executionTime
+        )
+    }
+
     func fetchRowCount(query: String) async throws -> Int {
         let countQuery = "SELECT count() FROM (\(query)) AS __cnt"
         let result = try await execute(query: countQuery)
@@ -431,6 +452,22 @@ final class ClickHousePluginDriver: PluginDatabaseDriver, @unchecked Sendable {
         return PluginDatabaseMetadata(name: database)
     }
 
+    func fetchAllDatabaseMetadata() async throws -> [PluginDatabaseMetadata] {
+        let sql = """
+            SELECT database, count() AS table_count, sum(total_bytes) AS size_bytes
+            FROM system.tables
+            GROUP BY database
+            ORDER BY database
+            """
+        let result = try await execute(query: sql)
+        return result.rows.compactMap { row -> PluginDatabaseMetadata? in
+            guard let name = row[safe: 0] ?? nil else { return nil }
+            let tableCount = (row[safe: 1] ?? nil).flatMap { Int($0) } ?? 0
+            let sizeBytes = (row[safe: 2] ?? nil).flatMap { Int64($0) }
+            return PluginDatabaseMetadata(name: name, tableCount: tableCount, sizeBytes: sizeBytes)
+        }
+    }
+
     func createDatabase(name: String, charset: String, collation: String?) async throws {
         let escapedName = name.replacingOccurrences(of: "`", with: "``")
         _ = try await execute(query: "CREATE DATABASE `\(escapedName)`")
@@ -550,7 +587,64 @@ final class ClickHousePluginDriver: PluginDatabaseDriver, @unchecked Sendable {
         return CHQueryResult(columns: [], columnTypeNames: [], rows: [], affectedRows: 0)
     }
 
-    private func buildRequest(query: String, database: String, queryId: String? = nil) throws -> URLRequest {
+    private func executeRawWithParams(_ query: String, params: [String: String?], queryId: String? = nil) async throws -> CHQueryResult {
+        lock.lock()
+        guard let session = self.session else {
+            lock.unlock()
+            throw ClickHouseError.notConnected
+        }
+        let database = _currentDatabase
+        if let queryId {
+            _lastQueryId = queryId
+        }
+        lock.unlock()
+
+        let request = try buildRequest(query: query, database: database, queryId: queryId, params: params)
+        let isSelect = Self.isSelectLikeQuery(query)
+
+        let (data, response) = try await withTaskCancellationHandler {
+            try await withCheckedThrowingContinuation { (continuation: CheckedContinuation<(Data, URLResponse), Error>) in
+                let task = session.dataTask(with: request) { data, response, error in
+                    if let error {
+                        continuation.resume(throwing: error)
+                        return
+                    }
+                    guard let data, let response else {
+                        continuation.resume(throwing: ClickHouseError(message: "Empty response from server"))
+                        return
+                    }
+                    continuation.resume(returning: (data, response))
+                }
+                self.lock.lock()
+                self.currentTask = task
+                self.lock.unlock()
+                task.resume()
+            }
+        } onCancel: {
+            self.lock.lock()
+            self.currentTask?.cancel()
+            self.currentTask = nil
+            self.lock.unlock()
+        }
+
+        lock.lock()
+        currentTask = nil
+        lock.unlock()
+
+        if let httpResponse = response as? HTTPURLResponse, httpResponse.statusCode >= 400 {
+            let body = String(data: data, encoding: .utf8) ?? "Unknown error"
+            Self.logger.error("ClickHouse HTTP \(httpResponse.statusCode): \(body)")
+            throw ClickHouseError(message: body.trimmingCharacters(in: .whitespacesAndNewlines))
+        }
+
+        if isSelect {
+            return parseTabSeparatedResponse(data)
+        }
+
+        return CHQueryResult(columns: [], columnTypeNames: [], rows: [], affectedRows: 0)
+    }
+
+    private func buildRequest(query: String, database: String, queryId: String? = nil, params: [String: String?]? = nil) throws -> URLRequest {
         let useTLS = config.additionalFields["sslMode"] != nil
             && config.additionalFields["sslMode"] != "Disabled"
 
@@ -568,6 +662,11 @@ final class ClickHousePluginDriver: PluginDatabaseDriver, @unchecked Sendable {
             queryItems.append(URLQueryItem(name: "query_id", value: queryId))
         }
         queryItems.append(URLQueryItem(name: "send_progress_in_http_headers", value: "1"))
+        if let params {
+            for (key, value) in params.sorted(by: { $0.key < $1.key }) {
+                queryItems.append(URLQueryItem(name: "param_\(key)", value: value))
+            }
+        }
         if !queryItems.isEmpty {
             components.queryItems = queryItems
         }
@@ -631,6 +730,9 @@ final class ClickHousePluginDriver: PluginDatabaseDriver, @unchecked Sendable {
                 return Self.unescapeTsvField(field)
             }
             rows.append(row)
+            if rows.count >= PluginRowLimits.defaultMax {
+                break
+            }
         }
 
         return CHQueryResult(
@@ -699,6 +801,49 @@ final class ClickHousePluginDriver: PluginDatabaseDriver, @unchecked Sendable {
         return query
     }
 
+    /// Convert `?` placeholders to `{p1:String}` and build parameter map for ClickHouse HTTP params.
+    private static func buildClickHouseParams(
+        query: String,
+        parameters: [String?]
+    ) -> (String, [String: String?]) {
+        var converted = ""
+        var paramIndex = 0
+        var inSingleQuote = false
+        var inDoubleQuote = false
+        var isEscaped = false
+
+        for char in query {
+            if isEscaped {
+                isEscaped = false
+                converted.append(char)
+                continue
+            }
+            if char == "\\" && (inSingleQuote || inDoubleQuote) {
+                isEscaped = true
+                converted.append(char)
+                continue
+            }
+            if char == "'" && !inDoubleQuote {
+                inSingleQuote.toggle()
+            } else if char == "\"" && !inSingleQuote {
+                inDoubleQuote.toggle()
+            }
+            if char == "?" && !inSingleQuote && !inDoubleQuote && paramIndex < parameters.count {
+                paramIndex += 1
+                converted.append("{p\(paramIndex):String}")
+            } else {
+                converted.append(char)
+            }
+        }
+
+        var paramMap: [String: String?] = [:]
+        for i in 0..<paramIndex where i < parameters.count {
+            paramMap["p\(i + 1)"] = parameters[i]
+        }
+
+        return (converted, paramMap)
+    }
+
     // MARK: - TLS Delegate
 
     private class InsecureTLSDelegate: NSObject, URLSessionDelegate {