revert: remove statement highlighting feature (keep large doc safety caps)

datlechin · datlechin · commit 37ca68e39eab · 2026-03-24T20:41:59.000+07:00
The statement highlighting fought CodeEditSourceEditor's rendering pipeline
at every turn — EmphasisManager overwrites text colors, NSTextStorage
attributes conflict with the highlighter, CALayer stacks with current-line
highlight. The feature needs native CESS support (TextSelectionManager
background ranges) to work correctly.

Kept: large document safety caps (5MB skip, 50KB throttle), theme color
definition, scanner located tests, theme definition tests.
diff --git a/.claude/worktrees/agent-a1a2c85e b/.claude/worktrees/agent-a1a2c85e
@@ -0,0 +1 @@
+Subproject commit 48e706ed534dfa3d3784267ea94191da8c89cda6
diff --git a/.claude/worktrees/agent-a45fa581 b/.claude/worktrees/agent-a45fa581
@@ -0,0 +1 @@
+Subproject commit ebcded6d18ab66158eca4492cb5907bd88e6c4f8
diff --git a/.claude/worktrees/agent-a47a2ae2 b/.claude/worktrees/agent-a47a2ae2
@@ -0,0 +1 @@
+Subproject commit 6e018092e187f6b59782e1f18874b673912c4ed2
diff --git a/.claude/worktrees/agent-a52204c8 b/.claude/worktrees/agent-a52204c8
@@ -0,0 +1 @@
+Subproject commit 6e018092e187f6b59782e1f18874b673912c4ed2
diff --git a/.claude/worktrees/agent-a9fb7d7e b/.claude/worktrees/agent-a9fb7d7e
@@ -0,0 +1 @@
+Subproject commit 6e018092e187f6b59782e1f18874b673912c4ed2
diff --git a/.claude/worktrees/agent-ab285578 b/.claude/worktrees/agent-ab285578
@@ -0,0 +1 @@
+Subproject commit cb9a2721ff9f83a2af724d0fb009f98792770083
diff --git a/.claude/worktrees/agent-afb913a6 b/.claude/worktrees/agent-afb913a6
@@ -0,0 +1 @@
+Subproject commit 48e706ed534dfa3d3784267ea94191da8c89cda6
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,7 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Added
 
-- Current SQL statement background highlighting in query editor
+- Large document safety caps for syntax highlighting (skip >5MB, throttle >50KB)
 
 ## [0.23.2] - 2026-03-24 main
 
diff --git a/Sequel-Ace b/Sequel-Ace
@@ -0,0 +1 @@
+Subproject commit 175ae46749d5c1d72b094e3b4d085a9b0dae15e2
diff --git a/TablePro/Views/Editor/CurrentStatementHighlighter.swift b/TablePro/Views/Editor/CurrentStatementHighlighter.swift
diff --git a/TablePro/Views/Editor/SQLEditorCoordinator.swift b/TablePro/Views/Editor/SQLEditorCoordinator.swift
@@ -29,7 +29,6 @@ final class SQLEditorCoordinator: TextViewCoordinator {
     /// Debounce work item for frame-change notification to avoid
     /// triggering syntax highlight viewport recalculation on every keystroke.
     @ObservationIgnored private var frameChangeWorkItem: DispatchWorkItem?
-    @ObservationIgnored private var statementHighlighter: CurrentStatementHighlighter?
     @ObservationIgnored private var wasEditorFocused = false
     @ObservationIgnored private var didDestroy = false
 
@@ -87,8 +86,6 @@ final class SQLEditorCoordinator: TextViewCoordinator {
             self.applyHorizontalScrollFix(controller: controller)
             self.installAIContextMenu(controller: controller)
             self.installInlineSuggestionManager(controller: controller)
-            self.statementHighlighter = CurrentStatementHighlighter()
-            self.statementHighlighter?.install(controller: controller)
             self.installVimModeIfEnabled(controller: controller)
             if let textView = controller.textView {
                 EditorEventRouter.shared.register(self, textView: textView)
@@ -104,7 +101,6 @@ final class SQLEditorCoordinator: TextViewCoordinator {
         DispatchQueue.main.async { [weak self] in
             self?.inlineSuggestionManager?.handleTextChange()
             self?.vimCursorManager?.updatePosition()
-            self?.statementHighlighter?.handleTextChange()
         }
 
         // Throttle frame-change notification — during rapid typing, only the
@@ -126,7 +122,6 @@ final class SQLEditorCoordinator: TextViewCoordinator {
     }
 
     func textViewDidChangeSelection(controller: TextViewController, newPositions: [CursorPosition]) {
-        statementHighlighter?.handleCursorChange()
         inlineSuggestionManager?.handleSelectionChange()
         vimCursorManager?.updatePosition()
 
@@ -148,9 +143,6 @@ final class SQLEditorCoordinator: TextViewCoordinator {
 
         uninstallVimKeyInterceptor()
 
-        statementHighlighter?.uninstall()
-        statementHighlighter = nil
-
         inlineSuggestionManager?.uninstall()
         inlineSuggestionManager = nil
 
diff --git a/TableProTests/Views/Editor/CurrentStatementHighlighterTests.swift b/TableProTests/Views/Editor/CurrentStatementHighlighterTests.swift
diff --git a/docs/development/sequel-ace-learnings.md b/docs/development/sequel-ace-learnings.md
diff --git a/licenseapp b/licenseapp
diff --git a/sequel-ace-vs-tablepro-analysis.md b/sequel-ace-vs-tablepro-analysis.md

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Subproject commit 48e706ed534dfa3d3784267ea94191da8c89cda6`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Subproject commit ebcded6d18ab66158eca4492cb5907bd88e6c4f8`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Subproject commit 6e018092e187f6b59782e1f18874b673912c4ed2`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Subproject commit cb9a2721ff9f83a2af724d0fb009f98792770083`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Subproject commit 175ae46749d5c1d72b094e3b4d085a9b0dae15e2`