Incongruity between MSVC and gcc7 for simulating robot

[FarkasJoseph]

Prevents me from compiling for some reason after installing Visual Studio to install Robot Sim (maybe a newer version of C++ which has multiple overloads of fabs?)
Simple fix is just casting to double: fabs((double) HOOD::POSITION::SAFE_TO_TURN))
Can I implement it? (lines 192 & 396)

[FarkasJoseph]

I did make it a commit to velocity branch for right now

[FarkasJoseph]

I might end up having to uninstall visual studio bc now the code will not compile:

Task :runFrcUserProgramTestWindowsx86-64DebugGoogleTestExe FAILED
HAL Extensions: No extensions found
Invalid Button Assignment: 3
Invalid Button Assignment: 4
Invalid Button Assignment: 5
Invalid Button Assignment: 8
Invalid Button Assignment: 10
Invalid Button Assignment: 2
Invalid Button Assignment: 6
Invalid Button Assignment: 1
Invalid Button Assignment: 11

FAILURE: Build failed with an exception.

• What went wrong:
  Execution failed for task ':runFrcUserProgramTestWindowsx86-64DebugGoogleTestExe'.

There were failing tests. See the results at: file:///C:/Users/josep/OneDrive/Documents/Robotics/2021-Code/build/test-results/frcUserProgramTest/windowsx86-64/debug/

• Try:
  Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

• Get more help at https://help.gradle.org

Deprecated Gradle features were used in this build, making it incompatible with Gradle 7.0.
Use '--warning-mode all' to show the individual deprecation warnings.
See https://docs.gradle.org/6.0.1/userguide/command_line_interface.html#sec:command_line_warnings

BUILD FAILED in 5m 32s

[CrashTestCoder]

instead, you should just remove ngr::fabs(double), it was added because for whatever reason the compiler couldn't find std::fabs
also https://www.youtube.com/watch?v=DAvZ3OG9cNo

[FarkasJoseph]

Where would I find ngr::fabs(double)?

[CrashTestCoder]

after thinking about it more, the more correct answer would probably be to just explicitly call ngr::fabs instead of just fabs and casting