Cancel state order not working proprely if table sylius_payment is too big

[sloury]

SyliusPayPalPlugin version affected: master

Description
Hi everyone, i had a problem with the cancelation or abort payment step. I have a big database sylius with about more 400000 entries into 'sylius_payment' table. During the cancel process to get all payments, the retriving the id transaction paypal take so much time that cannot work proprely. That redirect me to the payment methods page without the 'cancelled' state or worst get an error 500 'OutofMemory' if you had limited in memory PHP. If i go to the payment methods page, i can't go re-attempt to validate an another transaction.

Steps to reproduce

• Try to get more 10000 entries in 'sylius_payment' table
• Go to the popin Paypal Checkout and click to 'Cancel and return to Test Store' or exit the popin to trigger the cancel state.
• See the time between line 32 - 34 in PaymentProvider.php (too long)

Possible Solution

• Create a new route, like create and complete route, with the orderid sylius
• Pass this new route into PaypalButtonsController.php (line 139) with the orderid sylius
• Modify CancelPaypalPaymentAction line 29 -31 to retrieve the order sylius and the last payment.

[Chrysweel]

How is it possible to make a query like this?

$payments = $this->paymentRepository->findAll();

https://github.com/Sylius/PayPalPlugin/blob/1.5/src/Provider/PaymentProvider.php#L32

🤯🤯🤯🤯🤯

[migo315]

This definitely needs to be changed.

[wadjeroudi]

better solution could be retrieve the payment with sql json function to filter on the details attribute paypal_order_id

[Prometee]

I did not search into the PayPal API but there is always a way to set some additional metadata on the PayPal transaction to set a PaymentID, a Token hash or everything allowing to link the transaction to a Sylius related object.
The Sylius Stripe Plugin for example is doing this kind of thing and it allows to always know what it's the related Sylius Payment or Order when a Stripe payment is processed.

@Zales0123 can you explain why findAll has been chosen here? Does my comment can be a way to fix this?

[NoResponseMate]

Hi everyone 👋

A fix has been merged into 1.7 (#392) and will be available soonish.
Tested on ~1,000,000 payments, and it works fine.

That being said, it's more of a workaround than a proper fix due to BC concerns, and since it's on the 1.x version, there are additional limitations (at the very least, findAll is gone 💃).

To actually have it fixed, probably the simplest way would be to introduce a reference object, similar to what Francis mentioned, but on Sylius side, so we are independent from the PayPal API changes, but that's something that can be added at the latest in 2.1.

I'll leave this issue open so we have a point of reference for future work.

Cheers 🍻

[NoResponseMate]

Closed via automation 🤦