From c8bf57323026dfd226a920d0d3996bb7a3187699 Mon Sep 17 00:00:00 2001 From: LigLig Date: Thu, 25 Aug 2022 21:46:20 -0700 Subject: [PATCH 1/3] Fix unit test broken by update to tgbotapi See Syfaro/tgbotapi-rs@3bdfa356c51aca7feeccb84e6df520479d9b78fd --- src/execute/telegram/handlers/error_reply.rs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/execute/telegram/handlers/error_reply.rs b/src/execute/telegram/handlers/error_reply.rs index 9fa9b42..89206df 100644 --- a/src/execute/telegram/handlers/error_reply.rs +++ b/src/execute/telegram/handlers/error_reply.rs @@ -123,6 +123,8 @@ mod tests { length: 36, url: None, user: None, + language: None, + custom_emoji_id: None, }]; let text = "e52569fa-99a0-44fc-ae9d-2477177b550b"; From 9e1adbcc2c8c31a461c2e8accefaaae116cf35a1 Mon Sep 17 00:00:00 2001 From: LigLig Date: Thu, 25 Aug 2022 21:08:30 -0700 Subject: [PATCH 2/3] Remove unneeded clone inside format! macro --- src/sites/mod.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/sites/mod.rs b/src/sites/mod.rs index 1c58237..f8161db 100644 --- a/src/sites/mod.rs +++ b/src/sites/mod.rs @@ -773,7 +773,7 @@ impl Site for Twitter { Some(video_url) => Some(PostInfo { file_type: get_file_ext(video_url)?.to_owned(), url: video_url.to_string(), - thumb: Some(format!("{}:thumb", item.media_url_https.clone())), + thumb: Some(format!("{}:thumb", item.media_url_https)), source_link: Some(item.expanded_url), personal: user.protected, title: Some(user.screen_name.clone()), @@ -786,7 +786,7 @@ impl Site for Twitter { None => Some(PostInfo { file_type: get_file_ext(&item.media_url_https)?.to_owned(), url: item.media_url_https.clone(), - thumb: Some(format!("{}:thumb", item.media_url_https.clone())), + thumb: Some(format!("{}:thumb", item.media_url_https)), source_link: Some(item.expanded_url), personal: user.protected, site_name: self.name().into(), From ca6031b3f88b389eab9ce5d661a19ca47f2fb185 Mon Sep 17 00:00:00 2001 From: LigLig Date: Thu, 25 Aug 2022 21:27:44 -0700 Subject: [PATCH 3/3] Prefer :orig Twitter images to default By default Twitter presents images at "medium" size, but it is possible to obtain a higher quality "original" with the `:orig` name. Note: Twitter will resize the image at upload time so that no one edge is greater than 4096 px. --- src/sites/mod.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/sites/mod.rs b/src/sites/mod.rs index f8161db..7b72f4d 100644 --- a/src/sites/mod.rs +++ b/src/sites/mod.rs @@ -785,7 +785,7 @@ impl Site for Twitter { }), None => Some(PostInfo { file_type: get_file_ext(&item.media_url_https)?.to_owned(), - url: item.media_url_https.clone(), + url: format!("{}:orig", item.media_url_https), thumb: Some(format!("{}:thumb", item.media_url_https)), source_link: Some(item.expanded_url), personal: user.protected,