Bundling capabilities (webpack, ...)

[paztis]

Currently, dependency gpt-3-encoder blocks the capacity of bundling vectra inside a standalone app
This is because of fs.readFileSync inside (see this issue: latitudegames/GPT-3-Encoder#32)

I create a PR to fix it and deliver it also in module @paztis/gpt-3-encoder

Is is possible to adopt it until they accept the fix (if they do as it is a 3 years old unmaintained module) ?

[Stevenic]

Sorry for the delay @paztis... I went back to work for Microsoft and have been swamped.

Do you have a PR with your fixes that I can review?

[paztis]

I've no PR. What you have to do is use the dependency @paztis/gpt-3-encoder instead of the original gpt-3-encoder.

Code structure under is the same.
The problem was gpt-3-encoder has been released 3 years ago and they will not accept m'y fix in their module. That's why I fork their module

[Stevenic]

@paztis I'll take a look at making the switch tomorrow...

[Stevenic]

@hggz I was thinking of just switching to gpt-tokenizer as well. It didn't exist when I wrote this... Let me publish a patch for you guys to test...

[Stevenic]

I just published v0.12.2 that uses gpt-tokenizer instead. Can one of you verify that it bundles now? @paztis @hggz

[Stevenic]

I'm going to try and work on flushing out a bunch of unit tests this weekend since the projects getting more popular then I ever thought it would...

[JLambertazzo]

@Stevenic let me know if you'd like help with filling out the unit tests. I've got some time this weekend and have really enjoyed using Vectra. Would love to pitch in

[Stevenic]

@JLambertazzo that would be awesome... I had to tweak where the unit tests live because of NYC and ESM issues. I prefer tests that live near the code they're testing. So I put them right next to the source file and just add a .spec.ts extension.

[Stevenic]

@JLambertazzo I just invited you to the project as a collaborator... I'm just going to add a policy that locks main and requires a PR with at least one review.

If anyone else wants to be a collaborator happy to add you... @hggz ?

[Stevenic]

Main should be protected now... A PR is required with at least one review... I'll working on setting up a build verification check... For now, I'll manage publishing new packages...