functions in er.helpers:: need to be checked/reviewed #11
Description
The functions needs to be reviewed generally. Apparently Dave looked into these - but need to clarify whether his review was thorough and complete?
In the meantime, er.helpers::calc_annual_anomaly() needs to be revised so that reference is calculated by taking the average of each month over the reference period and then taking the average of those months. Currently, the reference is calculated by averaging the months to get annual averages and then taking the average of those annual averages.
Currently, given that there is not missing data for annual rainfall - or temperature - this issue should not create any differences in figures - but this is something that we should tighten up in the future.
Thanks