Skip to content

fix: ignore changelog from oxfmt#232

Merged
ryoppippi merged 2 commits intomainfrom
fix-lint
Dec 15, 2025
Merged

fix: ignore changelog from oxfmt#232
ryoppippi merged 2 commits intomainfrom
fix-lint

Conversation

@ryoppippi
Copy link
Copy Markdown
Contributor

@ryoppippi ryoppippi commented Dec 15, 2025

Summary by cubic

Switch pnpm lint/format docs from Biome to oxfmt/oxlint/knip to reflect current tooling. Also update .oxfmtrc to ignore CHANGELOG.md so release notes aren't reformatted.

Written for commit 6e0cf19. Summary will update automatically on new commits.

Copilot AI review requested due to automatic review settings December 15, 2025 13:00
@ryoppippi ryoppippi requested a review from a team as a code owner December 15, 2025 13:00
@ryoppippi ryoppippi enabled auto-merge (squash) December 15, 2025 13:01
@ryoppippi ryoppippi changed the title fix(rule): biome -> oxlint fix: ignore changelog from oxfmt Dec 15, 2025
@ryoppippi ryoppippi disabled auto-merge December 15, 2025 13:01
@ryoppippi ryoppippi enabled auto-merge (squash) December 15, 2025 13:01
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Dec 15, 2025

Open in StackBlitz

npm i https://pkg.pr.new/StackOneHQ/stackone-ai-node/@stackone/ai@232

commit: 6e0cf19

@ryoppippi ryoppippi merged commit 8ae4480 into main Dec 15, 2025
14 checks passed
@ryoppippi ryoppippi deleted the fix-lint branch December 15, 2025 13:01
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates documentation to reflect the migration from Biome to oxfmt/oxlint/knip tooling for code quality checks. The changes update a Claude rules documentation file to reflect the correct tool names and adds CHANGELOG.md to the formatter's ignore patterns.

Key changes:

  • Updated command descriptions from "Biome" to "oxfmt/oxlint/knip"
  • Added CHANGELOG.md to oxfmt's ignore patterns

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
.oxfmtrc.jsonc Adds CHANGELOG.md to the ignore patterns for formatting
.claude/rules/pnpm-usage.md Updates tool references from Biome to oxfmt/oxlint/knip in command descriptions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- `pnpm lint` - Run Biome linter
- `pnpm format` - Format code with Biome
- `pnpm lint` - Run oxfmt/oxlint/knip linter
- `pnpm format` - Format code with oxfmt/oxlint/knip
Copy link

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description is inaccurate. The format command formats code with oxfmt, not with oxfmt/oxlint/knip as stated. According to package.json, the format command runs oxfmt for formatting, oxlint with --fix flag, and knip with --fix flag. Only oxfmt is a code formatter - oxlint is a linter (though it can auto-fix some issues), and knip is a tool for detecting unused code. The description should be more accurate about what these tools do, such as "Format code and apply auto-fixes with oxfmt/oxlint/knip".

Suggested change
- `pnpm format` - Format code with oxfmt/oxlint/knip
- `pnpm format` - Format code and apply auto-fixes with oxfmt/oxlint/knip

Copilot uses AI. Check for mistakes.

- `pnpm lint` - Run Biome linter
- `pnpm format` - Format code with Biome
- `pnpm lint` - Run oxfmt/oxlint/knip linter
Copy link

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description is misleading. The lint command runs oxfmt in check mode, oxlint, and knip, but only oxlint is actually a linter. oxfmt is a formatter (in check mode here), and knip detects unused code. A more accurate description would be "Run code quality checks with oxfmt/oxlint/knip" or similar.

Suggested change
- `pnpm lint` - Run oxfmt/oxlint/knip linter
- `pnpm lint` - Run code quality checks with oxfmt/oxlint/knip

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants