Conversation
commit: |
There was a problem hiding this comment.
Pull request overview
This PR updates documentation to reflect the migration from Biome to oxfmt/oxlint/knip tooling for code quality checks. The changes update a Claude rules documentation file to reflect the correct tool names and adds CHANGELOG.md to the formatter's ignore patterns.
Key changes:
- Updated command descriptions from "Biome" to "oxfmt/oxlint/knip"
- Added CHANGELOG.md to oxfmt's ignore patterns
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .oxfmtrc.jsonc | Adds CHANGELOG.md to the ignore patterns for formatting |
| .claude/rules/pnpm-usage.md | Updates tool references from Biome to oxfmt/oxlint/knip in command descriptions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - `pnpm lint` - Run Biome linter | ||
| - `pnpm format` - Format code with Biome | ||
| - `pnpm lint` - Run oxfmt/oxlint/knip linter | ||
| - `pnpm format` - Format code with oxfmt/oxlint/knip |
There was a problem hiding this comment.
The description is inaccurate. The format command formats code with oxfmt, not with oxfmt/oxlint/knip as stated. According to package.json, the format command runs oxfmt for formatting, oxlint with --fix flag, and knip with --fix flag. Only oxfmt is a code formatter - oxlint is a linter (though it can auto-fix some issues), and knip is a tool for detecting unused code. The description should be more accurate about what these tools do, such as "Format code and apply auto-fixes with oxfmt/oxlint/knip".
| - `pnpm format` - Format code with oxfmt/oxlint/knip | |
| - `pnpm format` - Format code and apply auto-fixes with oxfmt/oxlint/knip |
|
|
||
| - `pnpm lint` - Run Biome linter | ||
| - `pnpm format` - Format code with Biome | ||
| - `pnpm lint` - Run oxfmt/oxlint/knip linter |
There was a problem hiding this comment.
The description is misleading. The lint command runs oxfmt in check mode, oxlint, and knip, but only oxlint is actually a linter. oxfmt is a formatter (in check mode here), and knip detects unused code. A more accurate description would be "Run code quality checks with oxfmt/oxlint/knip" or similar.
| - `pnpm lint` - Run oxfmt/oxlint/knip linter | |
| - `pnpm lint` - Run code quality checks with oxfmt/oxlint/knip |
Summary by cubic
Switch pnpm lint/format docs from Biome to oxfmt/oxlint/knip to reflect current tooling. Also update .oxfmtrc to ignore CHANGELOG.md so release notes aren't reformatted.
Written for commit 6e0cf19. Summary will update automatically on new commits.