Skip to content

Latest commit

 

History

History
79 lines (67 loc) · 11 KB

AGENTS.md

File metadata and controls

79 lines (67 loc) · 11 KB

Agentic Current Task (Readonly Section)

Our current task is to audit the code for logic errors, typos, or other silly mistakes.

Architecture Plan

[Readonly line] Modify sparingly as new information is learned. Keep minimal and simple. The goal is to keep the architecture in mind and not drift into minefields. If over ~40 lines, compact to ~20 lines and remove anything tangential to the current task.

[Writable List]

Current Tasklist (ordered)

[Readonly line] (Remove as completed, add remaining concrete tasks.)

[Writable List]

  • None (current audit/fix/validation pass completed).

Notes from Owner (Readonly Section)

[Writable List]

Critical Questions and Blockers for Owner

[Readonly line] Append difficult decisions here that the owner can come back to for providing guidance. If stuck on a problem, try to infer from the README.md what the owner would have wanted, and make note of it here.

[Writable List]

Important Information

[Readonly line] Append important discoveries relevant to the task at hand. If over ~40 lines, compact to ~20 lines and remove anything tangential to the current task.

[Writable List]

  • Confirmed and fixed key logic/typo regressions in this audit stream: StateGameEnd.cpp loss-key reads, caged toucan map key consistency (caged-toucan), and compile-time duplicated scope in SpriterAnimationTimelineEventAnimation::advance.
  • Confirmed Data Mines tier 1-3 getWinLossSaveKey() overrides (olive-hexus, bonnie-hexus, burch-hexus) are intentional backward-compatibility mappings.
  • Confirmed broad first-party typo/comment cleanup completed across touched engine/platformer/Hexus files with no intended runtime behavior changes.
  • Follow-up audit sweeps repeatedly revalidated tracked regressions (caged-tucan/caged-Toucan, winsKey/lossesKey, collisonObject, duplicated SpriterAnimationTimelineEventAnimation::...::advance) with no additional issues found.
  • Latest follow-up audit pass (2026-02-13) reran first-party key/typo sweeps plus narrowed typo-pattern checks; no additional logic or typo issues found.
  • Additional audit finding/fix (2026-02-13): corrected WarlocksHeaddress canonical save key typo (warlocks-headress -> warlocks-headdress) and preserved backward compatibility through legacy deserializer aliasing.
  • Validation status remains unchanged (2026-02-13): ctest --test-dir build -C Debug --output-on-failure reports no discovered tests, and cmake --build build --config Debug fails in the local MSVC environment with missing standard/system headers (assert.h, set, map, string).
  • Follow-up audit pass (2026-02-13) reviewed staged and unstaged first-party diffs for regression risk (analytics keys, caged-toucan map keys, collision signature cleanups, Spriter timeline changes, WarlocksHeaddress key aliasing); no additional logic or typo issues found.
  • Additional follow-up audit pass (2026-02-13) reran first-party typo-pattern sweeps and targeted regression checks; only intentional legacy key alias usage (warlocks-headress) was found, with no new actionable logic or typo issues.
  • Latest follow-up audit pass (2026-02-13) re-reviewed staged and unstaged first-party diffs plus tracked typo/key regression patterns (caged-tucan/caged-Toucan, winsKey/lossesKey, collisonObject, duplicated SpriterAnimationTimelineEventAnimation::...::advance); no additional actionable logic or typo issues found.
  • Validation rerun remains unchanged (2026-02-13): ctest --test-dir build -C Debug --output-on-failure reports no discovered tests, and cmake --build build --config Debug fails with local MSVC C1083 missing standard/system headers (assert.h, set, map, string).
  • Latest follow-up audit pass (2026-02-13) reran first-party typo-pattern sweeps with vendored paths excluded and rechecked tracked key patterns; only intentional WarlocksHeaddress::LegacySaveKey alias usage (warlocks-headress) was found.
  • Validation rerun remains unchanged (2026-02-13): ctest --test-dir build -C Debug --output-on-failure reports no discovered tests, and cmake --build build --config Debug continues to fail with local MSVC C1083 missing standard/system headers (assert.h, set, map, string).
  • Latest follow-up audit pass (2026-02-13) rechecked staged and unstaged first-party diffs plus tracked regression signatures (caged-tucan/caged-Toucan, winsKey/lossesKey, collisonObject, duplicated SpriterAnimationTimelineEventAnimation::...::advance); no additional actionable logic or typo issues found.
  • Validation rerun remains unchanged (2026-02-13): ctest --test-dir build -C Debug --output-on-failure reports no discovered tests, and cmake --build build --config Debug still fails with local MSVC C1083 missing standard/system headers (assert.h, set, map, string).
  • Latest follow-up audit pass (2026-02-13) revalidated tracked key/signature regressions (caged-tucan/caged-Toucan, winsKey/lossesKey, duplicated SpriterAnimationTimelineEventAnimation::...::advance) and confirmed the intentional WarlocksHeaddress::LegacySaveKey alias (warlocks-headress); no new actionable logic or typo issues found.
  • Validation rerun remains unchanged (2026-02-13): ctest --test-dir build -C Debug --output-on-failure reports no discovered tests, and cmake --build build --config Debug still fails in local MSVC with C1083 missing standard/system headers (assert.h, set, map, string).
  • Latest follow-up audit pass (2026-02-13) rechecked staged/unstaged first-party diffs and reran tracked typo/key sweeps (caged-tucan/caged-Toucan, winsKey/lossesKey, SpriterAnimationTimelineEventAnimation::...::advance, warlocks-headress alias) with no new actionable logic or typo issues found.
  • Validation rerun remains unchanged (2026-02-13): ctest --test-dir build -C Debug --output-on-failure reports no discovered tests, and cmake --build build --config Debug fails in local MSVC with repeated C1083 missing standard/system headers (assert.h, set, map, string).
  • Latest follow-up audit pass (2026-02-13) reran tracked regression signatures plus narrowed typo sweeps over first-party sources/maps; only intentional WarlocksHeaddress::LegacySaveKey alias usage (warlocks-headress) and non-actionable multilingual string matches were observed.
  • Validation rerun remains unchanged (2026-02-13): ctest --test-dir build -C Debug --output-on-failure reports no discovered tests, and cmake --build build --config Debug still fails in local MSVC with C1083 missing standard/system headers (assert.h, set, map, string).

Agent Scratchpad and Notes

[Readonly line] Append below and compact regularly to relevant recent notes. If over ~30 lines, compact to ~15 lines.

[Writable List]

  • Current pass reran first-party tracked key/typo sweeps (caged-tucan/caged-Toucan, winsKey/lossesKey, collisonObject, duplicated SpriterAnimationTimelineEventAnimation::...::advance) and found no actionable matches.
  • Current pass reran narrowed first-party typo-pattern checks across Source/Engine, Source/Scenes, Source/Objects, and Source/Entities; no actionable typo findings.
  • Current pass found and fixed first-party save-key typo in WarlocksHeaddress by introducing a corrected canonical key and keeping warlocks-headress as a deserialization compatibility alias.
  • Current pass revalidated Data Mines tier 1-3 getWinLossSaveKey() compatibility overrides (olive-hexus, bonnie-hexus, burch-hexus) as intentional.
  • Validation rerun is unchanged in this pass: ctest --test-dir build -C Debug --output-on-failure reports no tests discovered in build.
  • Validation rerun is unchanged in this pass: cmake --build build --config Debug fails with local MSVC C1083 missing standard/system headers (assert.h, set, map, string).
  • Current pass additionally reviewed both index and working-tree diffs across touched first-party files and found no new actionable logic/typo regressions.
  • Current pass additionally reran narrowed typo-pattern checks (including prior regressions and common spelling slips) and only matched the intentional WarlocksHeaddress::LegacySaveKey alias (warlocks-headress).
  • Current pass re-reviewed staged and unstaged first-party diffs after the WarlocksHeaddress alias fix and confirmed no new logic/key regressions.
  • Current pass reran tracked exact-pattern checks (caged-tucan/caged-Toucan, winsKey/lossesKey, collisonObject, duplicated SpriterAnimationTimelineEventAnimation::...::advance) and found no actionable matches.
  • Current pass reran narrowed typo-pattern checks excluding vendored paths and only matched the intentional WarlocksHeaddress::LegacySaveKey alias (warlocks-headress).
  • Current pass revalidated caged toucan key consistency between CagedToucan::MapKey and touched TMX maps (caged-toucan) with no regressions found.
  • Current pass re-reviewed staged and unstaged first-party diffs plus tracked typo/key patterns and found no new actionable logic or typo regressions.
  • Validation rerun is unchanged in this pass: ctest --test-dir build -C Debug --output-on-failure reports no tests discovered, and cmake --build build --config Debug fails with local MSVC C1083 missing standard/system headers (assert.h, set, map, string).
  • Current pass reran tracked regression checks and confirmed no new issues in caged-toucan key usage, winsKey/lossesKey, or SpriterAnimationTimelineEventAnimation::advance signature usage.
  • Current pass reconfirmed WarlocksHeaddress canonical key (warlocks-headdress) plus legacy deserializer alias (warlocks-headress) are intentional and consistent.
  • Validation rerun is unchanged in this pass: ctest --test-dir build -C Debug --output-on-failure reports no tests discovered, and cmake --build build --config Debug fails with local MSVC C1083 missing standard/system headers (assert.h, set, map, string).
  • Current pass re-reviewed staged and unstaged first-party diffs and reran tracked typo/key sweeps; only intentional WarlocksHeaddress::LegacySaveKey alias usage (warlocks-headress) was found.
  • Current pass confirmed no new actionable logic/typo regressions in tracked hotspots (StateGameEnd win/loss keys, CagedToucan::MapKey, and SpriterAnimationTimelineEventAnimation::advance).
  • Validation rerun is unchanged in this pass: ctest --test-dir build -C Debug --output-on-failure reports no tests discovered, and cmake --build build --config Debug fails in local MSVC with repeated C1083 missing standard/system headers (assert.h, set, map, string).
  • Current pass reran tracked key/signature checks and narrowed typo-pattern scans across first-party source/map paths; no new actionable logic or typo regressions were found.
  • Current pass observed typo-pattern hits in Source/Strings/Strings.cpp that are multilingual content and treated them as non-actionable for this audit scope.
  • Validation rerun is unchanged in this pass: ctest --test-dir build -C Debug --output-on-failure reports no tests discovered, and cmake --build build --config Debug fails in local MSVC with C1083 missing standard/system headers (assert.h, set, map, string).