Sync with eshell history?

[krisbalintona]

Hello,

Thank you for the great package.

I was wondering how infeasible it would be for eshell's native history to just pull from eshell-atuin's history? (Or the reverse: for eshell-atuin to push its history to eshell's history.)

[SqrtMinusOne]

Hey,

Sorry for the late reply.

Well, eshell-history-ring' is just a collection of strings. So making eshell-autinpush there doesn't seem hard, but wouldn'teshell-hist-mode` do that anyway?

Or, I suppose, it's possible to just replace the history ring with atuin history? I've tried implementing that:

(defun eshell-atuin-replace-history-ring ()
  "Replace `eshell-history-ring' with data from atuin."
  (interactive)
  (eshell-atuin--history-rotate-cache)
  (eshell-atuin--history-update)
  (when (= 0 (ring-size eshell-history-ring))
    (user-error "The history ring is empty.  Not running in eshell?"))
  (let ((commands
         (seq-take
          (mapcar (lambda (e) (alist-get 'command e))
                  eshell-atuin--history-cache)
          (ring-size eshell-history-ring)))
        (ring (make-ring eshell-history-size)))
    (mapc (lambda (c)
            (ring-insert-at-beginning ring c))
          commands)
    (setq eshell-history-ring ring)))

This seems to work for small values of eshell-history-size, but breaks for larger ones with an error coming from completion--insert-strings. This part of Emacs is a mystery to me, unfortunately... Maybe it's getting confused with bash-isms in the history somewhere?

Anyway, I guess I'll put that on a shelf for now. Feel free to experiment though.