♻️Refactor: 가입 신청 목록 조회 응답을 경량 DTO(JoinClubRequestSummaryResponse)로 분리

Author: 안훈기

src/main/java/com/be/sportizebe/domain/notification/controller/JoinClubRequestController.java

@@ -2,6 +2,7 @@
 
 import com.be.sportizebe.domain.notification.dto.request.JoinClubApplicationRequest;
 import com.be.sportizebe.domain.notification.dto.response.JoinClubRequestResponse;
+import com.be.sportizebe.domain.notification.dto.response.JoinClubRequestSummaryResponse;
 import com.be.sportizebe.domain.notification.service.JoinClubRequestService;
 import com.be.sportizebe.global.cache.dto.UserAuthInfo;
 import com.be.sportizebe.global.response.BaseResponse;
@@ -75,10 +76,10 @@ public ResponseEntity<BaseResponse<JoinClubRequestResponse>> rejectRequest(
 
   @GetMapping("/{clubId}/join-requests")
   @Operation(summary = "대기 중인 가입 신청 목록", description = "동호회의 대기 중인 가입 신청 목록을 조회합니다. 동호회장만 가능합니다.")
-  public ResponseEntity<BaseResponse<List<JoinClubRequestResponse>>> getPendingRequests(
+  public ResponseEntity<BaseResponse<List<JoinClubRequestSummaryResponse>>> getPendingRequests(
       @Parameter(description = "동호회 ID") @PathVariable Long clubId,
       @AuthenticationPrincipal UserAuthInfo userAuthInfo) {
-    List<JoinClubRequestResponse> response = joinClubRequestService.getPendingRequests(clubId, userAuthInfo.getId());
+    List<JoinClubRequestSummaryResponse> response = joinClubRequestService.getPendingRequests(clubId, userAuthInfo.getId());
     return ResponseEntity.ok(BaseResponse.success("가입 신청 목록 조회 성공", response));
   }
 

src/main/java/com/be/sportizebe/domain/notification/dto/response/JoinClubRequestSummaryResponse.java

@@ -0,0 +1,25 @@
+package com.be.sportizebe.domain.notification.dto.response;
+
+import com.be.sportizebe.domain.notification.entity.JoinClubRequest;
+import io.swagger.v3.oas.annotations.media.Schema;
+import lombok.Builder;
+
+@Builder
+@Schema(title = "JoinClubRequestSummaryResponse DTO", description = "가입 신청 목록 응답 (요약)")
+public record JoinClubRequestSummaryResponse(
+    @Schema(description = "가입 신청 ID") Long id,
+    @Schema(description = "신청자 ID") Long userId,
+    @Schema(description = "신청자 닉네임") String userNickname,
+    @Schema(description = "동호회 ID") Long clubId,
+    @Schema(description = "동호회 이름") String clubName
+) {
+  public static JoinClubRequestSummaryResponse from(JoinClubRequest request) {
+    return JoinClubRequestSummaryResponse.builder()
+        .id(request.getId())
+        .userId(request.getUser().getId())
+        .userNickname(request.getUser().getNickname())
+        .clubId(request.getClub().getId())
+        .clubName(request.getClub().getName())
+        .build();
+  }
+}

src/main/java/com/be/sportizebe/domain/notification/service/JoinClubRequestService.java

@@ -1,6 +1,7 @@
 package com.be.sportizebe.domain.notification.service;
 
 import com.be.sportizebe.domain.notification.dto.response.JoinClubRequestResponse;
+import com.be.sportizebe.domain.notification.dto.response.JoinClubRequestSummaryResponse;
 
 import java.util.List;
 
@@ -22,7 +23,7 @@ public interface JoinClubRequestService {
   JoinClubRequestResponse rejectRequest(Long requestId, Long leaderId);
 
   // 동호회의 대기 중인 가입 신청 목록 조회 (동호회장만)
-  List<JoinClubRequestResponse> getPendingRequests(Long clubId, Long leaderId);
+  List<JoinClubRequestSummaryResponse> getPendingRequests(Long clubId, Long leaderId);
 
   // 내 가입 신청 목록 조회
   List<JoinClubRequestResponse> getMyRequests(Long userId);

src/main/java/com/be/sportizebe/domain/notification/service/JoinClubRequestServiceImpl.java

@@ -6,6 +6,7 @@
 import com.be.sportizebe.domain.club.repository.ClubMemberRepository;
 import com.be.sportizebe.domain.club.repository.ClubRepository;
 import com.be.sportizebe.domain.notification.dto.response.JoinClubRequestResponse;
+import com.be.sportizebe.domain.notification.dto.response.JoinClubRequestSummaryResponse;
 import com.be.sportizebe.domain.notification.entity.JoinClubRequest;
 import com.be.sportizebe.domain.notification.exception.JoinClubRequestErrorCode;
 import com.be.sportizebe.domain.notification.repository.JoinClubRequestRepository;
@@ -82,7 +83,7 @@ public JoinClubRequestResponse getJoinRequest(Long requestId, Long userId) {
 
     // 동호회장 또는 신청자 본인만 조회 가능
     boolean isLeader = request.getClub().isLeader(userId);
-    boolean isApplicant = request.getUser().getId().equals(userId);
+    boolean isApplicant = userId.equals(request.getUser().getId());
     if (!isLeader && !isApplicant) {
       throw new CustomException(ClubErrorCode.CLUB_UPDATE_DENIED);
     }
@@ -175,7 +176,7 @@ public JoinClubRequestResponse rejectRequest(Long requestId, Long leaderId) {
   }
 
   @Override
-  public List<JoinClubRequestResponse> getPendingRequests(Long clubId, Long leaderId) {
+  public List<JoinClubRequestSummaryResponse> getPendingRequests(Long clubId, Long leaderId) {
     Club club = findClubById(clubId);
 
     // 동호회장만 조회 가능
@@ -186,7 +187,7 @@ public List<JoinClubRequestResponse> getPendingRequests(Long clubId, Long leader
     return joinClubRequestRepository
         .findByClubAndStatus(club, JoinClubRequest.JoinClubRequestStatus.PENDING)
         .stream()
-        .map(JoinClubRequestResponse::from)
+        .map(JoinClubRequestSummaryResponse::from)
         .toList();
   }