UOGateway status request

[GladieUO]

22:06:c5:UOG Status request from
22:06:c5:Client disconnected [Total:16]. Connection Type: 'Just connected'. IP=''.
22:06:CRITICAL:Assert severity=2: 'history.m_iPendingConnectionRequests > 0' file 'D:\Sphere-X-Work\Source-X-DEV-\src\game\clients\CClient.cpp', line 99, in ExcType=CAssert catched in SUB: CClient::m_iPendingConnectionRequests() ("m_iPendingConnectionRequests")
22:06:DEBUG:Printing STACK TRACE for debugging purposes.
22:06:DEBUG: ______ thread (id) name _____ |   # | _____________ function _____________ |
22:06:DEBUG:(f1c)          T_Main |   0 |                      CWorld::_OnTick | 
22:06:DEBUG:(f1c)          T_Main |   1 |                    CClient::~CClient | <-- exception catch point (below is guessed and could be incorrect!)
22:06:DEBUG:(f1c)          T_Main |   2 |                       CLog::EventStr | 
22:06:DEBUG:(f1c)          T_Main |   3 |             CSFileText::_WriteString | 
22:06:DEBUG:(f1c)          T_Main |   4 |                   CSFileText::_Write | 
22:06:DEBUG:(f1c)          T_Main |   5 |                  CChar::Stat_GetBase | 
22:06:DEBUG:(f1c)          T_Main |   6 |                   CChar::Stat_GetMax | 
22:06:DEBUG:(f1c)          T_Main |   7 |                      CClient::CanSee | 
22:06:DEBUG:(f1c)          T_Main |   8 |                        CChar::CanSee | 
22:06:DEBUG:(f1c)          T_Main |   9 |            CResourceLink::HasTrigger | 
22:06:DEBUG:(f1c)          T_Main |  10 |      CScriptFileContext::_OpenScript | 
22:06:DEBUG:(f1c)          T_Main |  11 |           CScriptFileContext::_Close | 
22:06:DEBUG:(f1c)          T_Main |  12 |                         CSFile::Read | 
22:06:DEBUG:(f1c)          T_Main |  13 |                        CSFile::_Seek | 
22:06:DEBUG:(f1c)          T_Main |  14 |                        CSFile::_Seek | 
22:06:DEBUG:(f1c)          T_Main |  15 |             CScriptObj::r_GetRefFull | 
22:06:DEBUG:(f1c)          T_Main |  16 |                      CChar::r_GetRef | 
22:06:DEBUG:(f1c)          T_Main |  17 |                    CChar::r_WriteVal | 
22:06:DEBUG:(f1c)          T_Main |  18 |                 CObjBase::r_WriteVal | 
22:06:DEBUG:(f1c)          T_Main |  19 |                   CObjBase::r_GetRef | 
22:06:DEBUG:(f1c)          T_Main |  20 |                 CScriptObj::r_GetRef | 
22:06:DEBUG:(f1c)          T_Main |  21 |                  CExpression::GetVal | 
22:06:DEBUG:(f1c)          T_Main |  22 |              CExpression::GetValMath | 
22:06:DEBUG:(f1c)          T_Main |  23 |                    CChar::r_WriteVal | 
22:06:DEBUG:(f1c)          T_Main |  24 |                 CObjBase::r_WriteVal | 
22:06:DEBUG:(f1c)          T_Main |  25 |               CScriptObj::r_WriteVal | 
22:06:DEBUG:(f1c)          T_Main |  26 |                  CExpression::GetVal | 
22:06:DEBUG:(f1c)          T_Main |  27 |              CExpression::GetValMath | 
22:06:DEBUG:(f1c)          T_Main |  28 |                  CExpression::GetVal | 
22:06:DEBUG:(f1c)          T_Main |  29 |              CExpression::GetValMath | 
22:06:DEBUG:(f1c)          T_Main |  30 |                  CExpression::GetVal | 
22:06:DEBUG:(f1c)          T_Main |  31 |              CExpression::GetValMath | 
22:06:DEBUG:(f1c)          T_Main |  32 |              CExpression::GetValMath | 
22:06:DEBUG:(f1c)          T_Main |  33 |      CComponentProps::GetPropertyNum | 
22:06:DEBUG:(f1c)          T_Main |  34 |                 CScriptObj::r_GetRef | 
22:06:DEBUG:(f1c)          T_Main |  35 |                 CScriptObj::r_GetRef | 
22:06:DEBUG:(f1c)          T_Main |  36 |        CResourceDef::GetResourceName | 
22:06:DEBUG:(f1c)          T_Main |  37 | CServerConfig::RegisteredResourceGet | 
22:06:DEBUG:(f1c)          T_Main |  38 |   CResourceHolder::ResourceGetDefRef | 
22:06:DEBUG:(f1c)          T_Main |  39 |                 CScriptObj::r_GetRef | 
22:06:DEBUG:(f1c)          T_Main |  40 |              CExpression::GetValMath | 
22:06:DEBUG:(f1c)          T_Main |  41 |              CExpression::GetValMath | 
22:06:DEBUG:(f1c)          T_Main |  42 |               CItem::IsResourceMatch | 
22:06:DEBUG:(f1c)          T_Main |  43 |   CResourceHolder::ResourceGetDefRef | 
22:06:DEBUG:(f1c)          T_Main |  44 |                 CScriptObj::r_GetRef | 
22:06:DEBUG:(f1c)          T_Main |  45 |                CItemBase::r_WriteVal | 
22:06:DEBUG:(f1c)          T_Main |  46 |        CResourceQtyArray::WriteNames | 
22:06:DEBUG:(f1c)          T_Main |  47 |        CResourceQty::WriteNameSingle | 
22:06:DEBUG:(f1c)          T_Main |  48 | CServerConfig::RegisteredResourceGet | 
22:06:DEBUG:(f1c)          T_Main |  49 | CServerConfig::RegisteredResourceGet | 
22:06:DEBUG:(f1c)          T_Main |  50 | CResourceHolder::ResourceGetID_EatSt | 
22:06:DEBUG:(f1c)          T_Main |  51 |                  CExpression::GetVal | 
22:06:DEBUG:(f1c)          T_Main |  52 |              CExpression::GetValMath | 
22:06:DEBUG:(f1c)          T_Main |  53 |              CExpression::GetValMath | 
22:06:DEBUG:(f1c)          T_Main |  54 |              CExpression::GetValMath | 
22:06:DEBUG:(f1c)          T_Main |  55 | CServerConfig::RegisteredResourceGet | 
22:06:DEBUG:(f1c)          T_Main |  56 |   CResourceHolder::ResourceGetDefRef | 
22:06:DEBUG:(f1c)          T_Main |  57 |                  CExpression::GetVal | 
22:06:DEBUG:(f1c)          T_Main |  58 |              CExpression::GetValMath | 
22:06:DEBUG:(f1c)          T_Main |  59 |                   CObjBase::r_GetRef | 
22:06:DEBUG:(f1c)          T_Main |  60 |                 CScriptObj::r_GetRef | 
22:06:DEBUG:(f1c)          T_Main |  61 |                 CScriptObj::r_GetRef | 
22:06:DEBUG:(f1c)          T_Main |  62 |                   CObjBase::r_GetRef | 
22:06:DEBUG:(f1c)          T_Main |  63 |                 CScriptObj::r_GetRef | 
22:06:DEBUG:(f1c)          T_Main |  64 |                 CScriptObj::r_GetRef | 
22:06:DEBUG:(f1c)          T_Main |  65 |                 CScriptObj::r_GetRef | 
22:06:DEBUG:(f1c)          T_Main |  66 |                    CClient::r_GetRef | 
22:06:DEBUG:(f1c)          T_Main |  67 |                 CScriptObj::r_GetRef | 
22:06:DEBUG:(f1c)          T_Main |  68 |                   CObjBase::r_GetRef | 
22:06:DEBUG:(f1c)          T_Main |  69 |                 CScriptObj::r_GetRef | 
22:06:DEBUG:(f1c)          T_Main |  70 |                 CScriptObj::r_GetRef | 
22:06:DEBUG:(f1c)          T_Main |  71 |                 CScriptObj::r_GetRef | 
22:06:DEBUG:(f1c)          T_Main |  72 |                 CScriptObj::r_GetRef | 
22:06:DEBUG:(f1c)          T_Main |  73 |                 CScriptObj::r_GetRef | 
22:06:DEBUG:(f1c)          T_Main |  74 |                 CScriptObj::r_GetRef | 
22:06:DEBUG:(f1c)          T_Main |  75 |                    CClient::r_GetRef | 
22:06:DEBUG:(f1c)          T_Main |  76 |                 CScriptObj::r_GetRef | 
22:06:DEBUG:(f1c)          T_Main |  77 |                   CObjBase::r_GetRef | 
22:06:DEBUG:(f1c)          T_Main |  78 |                 CScriptObj::r_GetRef | 
22:06:DEBUG:(f1c)          T_Main |  79 |                 CScriptObj::r_GetRef | 
22:06:DEBUG:(f1c)          T_Main |  80 |                 CScriptObj::r_GetRef | 
22:06:DEBUG:(f1c)          T_Main |  81 |                 CScriptObj::r_GetRef | 

[mtwango]

Same as #1451

[canerksk]

A similar problem also applies to telnet connections.

14:08:4c:Client disconnected [Total:0]. Connection Type: 'Telnet'. IP='<secret>'.
14:08:CRITICAL:Assert severity=2: 'history.m_iPendingConnectionRequests > 0' file 'D:\a\Source-X\Source-X\src\game\clients\CClient.cpp', line 99, in ExcType=CAssert catched in SUB: CClient::m_iPendingConnectionRequests() ("m_iPendingConnectionRequests")
14:08:DEBUG:Printing STACK TRACE for debugging purposes.
14:08:DEBUG: ______ thread (id) name _____ |   # | _____________ function _____________ |
14:08:DEBUG:(145c)          T_Main |   0 |                      CWorld::_OnTick | 
14:08:DEBUG:(145c)          T_Main |   1 |                    CClient::~CClient | <-- exception catch point (below is guessed and could be incorrect!)
14:08:DEBUG:(145c)          T_Main |   2 |                       CLog::EventStr | 
14:08:DEBUG:(145c)          T_Main |   3 |             CSFileText::_WriteString | 
14:08:DEBUG:(145c)          T_Main |   4 |                   CSFileText::_Write | 
14:08:DEBUG:(145c)          T_Main |   5 |                   CChar::Skill_Start | 
14:08:DEBUG:(145c)          T_Main |   6 |               CChar::Skill_OnTrigger | 
14:08:DEBUG:(145c)          T_Main |   7 |                 CChar::Skill_Cleanup | 
14:08:DEBUG:(145c)          T_Main |   8 |             CSectorBase::GetTeleport | 
14:08:DEBUG:(145c)          T_Main |   9 |            CResourceLink::HasTrigger | 
14:08:DEBUG:(145c)          T_Main |  10 |                  CServer::r_WriteVal | 
14:08:DEBUG:(145c)          T_Main |  11 |            CServerConfig::r_WriteVal | 
14:08:DEBUG:(145c)          T_Main |  12 |                 CScriptObj::r_GetRef | 
14:08:DEBUG:(145c)          T_Main |  13 |             CScriptObj::OnTriggerRun | 
14:08:DEBUG:(145c)          T_Main |  14 | CExpression::EvaluateConditionalSing | 
14:08:DEBUG:(145c)          T_Main |  15 |                  CExpression::GetVal | 

[GladieUO]

Wouldnt something like this help?

if (history.m_iPendingConnectionRequests > 0)
{
    --history.m_iPendingConnectionRequests;
}
else
{
    g_Log.EventDebug("Skipped m_iPendingConnectionRequests decrement for UOG/status request from %s\n", GetPeerStr());
}