refactor(OG): Update schema_rel_finding db methods to schema_finding#2405
Closed
mistahj67 wants to merge 2 commits intorefactor-rel-findings-to-findingsfrom
Closed
refactor(OG): Update schema_rel_finding db methods to schema_finding#2405mistahj67 wants to merge 2 commits intorefactor-rel-findings-to-findingsfrom
mistahj67 wants to merge 2 commits intorefactor-rel-findings-to-findingsfrom
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
mistahj67
force-pushed
the
refactor-rel-findings-to-findings-2
branch
2 times, most recently
from
d930769 to
f2ee71c
Compare
mistahj67
force-pushed
the
refactor-rel-findings-to-findings-2
branch
from
f2ee71c to
b7dd62e
Compare
mistahj67
added
the
api
sirisjo
reviewed
Feb 25, 2026
| // CreateSchemaRelationshipFinding - creates a new schema relationship finding. | ||
| func (s *BloodhoundDB) CreateSchemaRelationshipFinding(ctx context.Context, extensionId int32, relationshipKindId int32, environmentId int32, name string, displayName string) (model.SchemaRelationshipFinding, error) { | ||
| var finding model.SchemaRelationshipFinding | ||
| // CreateSchemaFinding - creates a new schema relationship finding. |
Contributor
There was a problem hiding this comment.
Suggested change
| // CreateSchemaFinding - creates a new schema relationship finding. | |
| // CreateSchemaFinding - creates a new schema finding. |
sirisjo
reviewed
Feb 25, 2026
| // GetSchemaRelationshipFindingById - retrieves a schema relationship finding by id. | ||
| func (s *BloodhoundDB) GetSchemaRelationshipFindingById(ctx context.Context, findingId int32) (model.SchemaRelationshipFinding, error) { | ||
| var finding model.SchemaRelationshipFinding | ||
| // GetSchemaFindingById - retrieves a schema relationship finding by id. |
Contributor
There was a problem hiding this comment.
Suggested change
| // GetSchemaFindingById - retrieves a schema relationship finding by id. | |
| // GetSchemaFindingById - retrieves a schema finding by id. |
sirisjo
reviewed
Feb 25, 2026
| // GetSchemaRelationshipFindingByName - retrieves a schema relationship finding by finding name. | ||
| func (s *BloodhoundDB) GetSchemaRelationshipFindingByName(ctx context.Context, name string) (model.SchemaRelationshipFinding, error) { | ||
| var finding model.SchemaRelationshipFinding | ||
| // GetSchemaFindingByName - retrieves a schema relationship finding by finding name. |
Contributor
There was a problem hiding this comment.
Suggested change
| // GetSchemaFindingByName - retrieves a schema relationship finding by finding name. | |
| // GetSchemaFindingByName - retrieves a schema finding by finding name. |
sirisjo
reviewed
Feb 25, 2026
| // DeleteSchemaRelationshipFinding - deletes a schema relationship finding by id. | ||
| func (s *BloodhoundDB) DeleteSchemaRelationshipFinding(ctx context.Context, findingId int32) error { | ||
| var finding model.SchemaRelationshipFinding | ||
| // DeleteSchemaFinding - deletes a schema relationship finding by id. |
Contributor
There was a problem hiding this comment.
Suggested change
| // DeleteSchemaFinding - deletes a schema relationship finding by id. | |
| // DeleteSchemaFinding - deletes a schema finding by id. |
mistahj67
force-pushed
the
refactor-rel-findings-to-findings
branch
2 times, most recently
from
9b40fdb to
2d31431
Compare
Contributor
Author
|
Closing because this changeset is needed by #2404 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rename / refactor for new schema_findings table
Motivation and Context
Resolves <TICKET_OR_ISSUE_NUMBER>
Why is this change required? What problem does it solve?
How Has This Been Tested?
Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc.
Screenshots (optional):
Types of changes
Checklist: