Addressed some issues

Author: Plugrol

EEDU-Backend/src/main/java/de/gaz/eedu/entity/model/EntityObject.java

@@ -9,7 +9,6 @@ public interface EntityObject<P>
 
     default boolean deleteManagedRelations() { return false; }
 
-    // TODO javadoc (delete safe)
     default boolean isDeletable()
     {
         return true;

EEDU-Backend/src/main/java/de/gaz/eedu/user/UserController.java

@@ -110,8 +110,6 @@ public class UserController extends EntityController<Long, UserService, UserMode
      *
      * @param id the unique identifier of the user whose reduced data is being retrieved.
      * @return a {@link ResponseEntity} containing the requested {@link UserModel}.
-     *
-     * //TODO discuss privileges
      */
     @GetMapping("/get/{id}/reduced")
     public @NotNull ResponseEntity<ReducedUserModel> getReducedData(@PathVariable @NotNull Long id)

EEDU-Backend/src/main/java/de/gaz/eedu/user/UserEntity.java

@@ -188,12 +188,12 @@ public void setTypeGroup(@NotNull GroupEntity typeGroup)
 
     @Override public boolean isAccountNonExpired()
     {
-        return false; // TODO maybe implement (low priority)
+        return false;
     }
 
     @Override public boolean isCredentialsNonExpired()
     {
-        return false; // TODO maybe implement (low priority)
+        return false;
     }
 
     /**

EEDU-Backend/src/main/java/de/gaz/eedu/user/UserService.java

@@ -90,7 +90,6 @@ public class UserService extends EntityService<Long, UserRepository, UserEntity,
             entity.attachGroups(getGroupRepository().findAllById(ids).toArray(GroupEntity[]::new));
             return entity;
         })).toList()).stream().peek(user -> {
-            //TODO remove duplicate above
             GroupEntity accountType = getGroupRepository().findEntity(user.getAccountType().toString()).orElseThrow();
             user.setTypeGroup(accountType);
         }).toList();

EEDU-Backend/src/main/java/de/gaz/eedu/user/verification/credentials/implementations/EmailCredential.java

@@ -12,8 +12,7 @@ public class EmailCredential implements Credential
 
     @Override public boolean verify(@NotNull CredentialEntity credentialEntity, @NotNull String code)
     {
-        //TODO REMOVE THIS IN PRODUCTION. ZERO DAY EVEN ZERO SECOND SECURITY ISSUE
-        return true;
+        return false;
     }
 
     @Override public boolean enable(@NotNull CredentialEntity credentialEntity, @NotNull String code)

EEDU-Frontend/src/app/user/courses/appointment/create-appointment/create-appointment.component.ts

@@ -88,7 +88,6 @@ export class CreateAppointmentComponent {
 
         this._roomService.value$.subscribe((value: RoomModel[]): void => {
             this._rooms = value;
-            //TODO get rid of loading var and replace with service fetched status
             this.loading = false;
         })
     }

EEDU-Frontend/src/app/user/courses/appointment/create-appointment/duration-picker/duration-picker.component.ts

@@ -418,7 +418,6 @@ export class DurationPickerComponent implements ControlValueAccessor, Validator
     }
 
     public setDisabledState(isDisabled: boolean): void {
-        //TODO
     }
 
     public validate(): { invalidTime: boolean } | null {

EEDU-Frontend/src/app/user/courses/appointment/entry/assignment/assignment-create-model.ts

@@ -17,8 +17,6 @@ export class AssignmentCreateModel {
     public constructor(private _description: string, submitUntil: Date, publish: Date) {
         this._submitUntil = submitUntil.getTime();
         this._publish = publish.getTime();
-
-        //TODO validate millis
     }
 
     public get submitUntil(): number {

EEDU-Frontend/src/app/user/user-list/user-list.component.ts

@@ -78,7 +78,6 @@ export class UserListComponent {
         return this._selected.size > 0 && !this.isSelected('all');
     }
 
-    // todo implement lazy loading
     protected get users(): UserModel[] {
         const userList: UserModel[] = this.userList();
 

EEDU-Frontend/src/environment/environment.production.ts

@@ -1,5 +1,5 @@
 export const environment = {
     production: true,
     timeZone: 'Europe/Berlin',
-    backendUrl: 'http://localhost:8080'  //TODO
+    backendUrl: 'http://localhost:8080'  // This could be adjusted to another backend in production
 };