From fd926b976e174b87478629c00d6792da97aab076 Mon Sep 17 00:00:00 2001 From: decanus <7621705+decanus@users.noreply.github.com> Date: Wed, 3 Mar 2021 11:51:04 +0100 Subject: [PATCH] started playing around --- pkg/rooms/buffereddatachannel.go | 3 +++ pkg/rooms/room.go | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/pkg/rooms/buffereddatachannel.go b/pkg/rooms/buffereddatachannel.go index e2a35afe..66f90c20 100644 --- a/pkg/rooms/buffereddatachannel.go +++ b/pkg/rooms/buffereddatachannel.go @@ -6,6 +6,9 @@ import ( "github.com/pion/webrtc/v3" ) +// @TODO: Probably for restarts, we do not want to close this channel. +// Instead we want to start and stop buffering depending on the state. + type BufferedDataChannel struct { channel *webrtc.DataChannel msgQueue chan []byte diff --git a/pkg/rooms/room.go b/pkg/rooms/room.go index 2d73695f..848279b7 100644 --- a/pkg/rooms/room.go +++ b/pkg/rooms/room.go @@ -283,7 +283,7 @@ func (r *Room) Handle(me *Member) { Joined: &pb.Event_Joined{User: me.ToProto()}, }, }) - case webrtc.ICEConnectionStateClosed, webrtc.ICEConnectionStateFailed: + case webrtc.ICEConnectionStateClosed: r.onDisconnected(int64(me.id)) } }