[Win32] clang-cl warnings

[gvanem]

Building with clang-cl on Win-10, shows some important warnings:

src/sandbox-windows.c(370,9): warning: variable 'sync' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
    if (!instance->waited)
        ^~~~~~~~~~~~~~~~~
src/sandbox-windows.c(584,9): note: uninitialized use occurs here
    if (sync)
        ^~~~
src/sandbox-windows.c(370,5): note: remove the 'if' if its condition is always false
    if (!instance->waited)
    ^~~~~~~~~~~~~~~~~~~~~~
src/sandbox-windows.c(363,9): warning: variable 'sync' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
    if (!instance)
        ^~~~~~~~~
src/sandbox-windows.c(584,9): note: uninitialized use occurs here
    if (sync)
        ^~~~
src/sandbox-windows.c(363,5): note: remove the 'if' if its condition is always false
    if (!instance)
    ^~~~~~~~~~~~~~
src/sandbox-windows.c(383,5): note: variable 'sync' is declared here
    HANDLE sync = CreateEvent(&inherit_handle, FALSE, FALSE, NULL);
    ^
2 warnings generated.

Which I fixed by:

--- a/src/sandbox-windows.c 2022-09-18 12:05:05
+++ b/src/sandbox-windows.c 2022-09-19 12:00:35
@@ -346,6 +346,7 @@
     int errnum = 0;
     struct bxfi_sandbox *instance = NULL;
     BOOL success = FALSE;
+    HANDLE sync = NULL;

     struct bxfi_prepare_ctx prep = {
         .handles = NULL,
@@ -380,7 +381,7 @@
         .bInheritHandle = TRUE
     };

-    HANDLE sync = CreateEvent(&inherit_handle, FALSE, FALSE, NULL);
+    sync = CreateEvent(&inherit_handle, FALSE, FALSE, NULL);
     errnum = -EPROTO;
     if (!sync)
         goto error;

[gvanem]

Besides the size-argument to _sntprintf() in case of -D_UNICODE is wrong.
These lines should be:

--- a/src/sandbox-windows.c 2022-09-19 12:05:05
+++ b/src/sandbox-windows.c 2025-05-01 08:59:44
@@ -34,6 +34,10 @@
 #include "timestamp.h"
 #include "timeout.h"

+#ifndef _countof
+#define _countof(array) (sizeof(array) / sizeof(array[0]))
+#endif
+
 int bxfi_check_sandbox_ctx(void)
 {
     int is_sandbox = !!_tcsstr(GetCommandLine(), TEXT("BXFI_MAP="));
@@ -399,11 +403,11 @@
     uint64_t mts_start = bxfi_timestamp_monotonic();

     TCHAR map_name[sizeof ("Local\\bxfi_") + 21];
-    _sntprintf(map_name, sizeof (map_name), TEXT("Local\\bxfi_%lu"), (unsigned long)GetCurrentProcessId());
+    _sntprintf(map_name, _countof (map_name), TEXT("Local\\bxfi_%lu"), (unsigned long)GetCurrentProcessId());

     TCHAR env_map[sizeof ("BXFI_MAP=") + sizeof (map_name) + 2];
     memset(env_map, 0, sizeof (env_map));
-    _sntprintf(env_map, sizeof (env_map), "BXFI_MAP=%s", map_name);
+    _sntprintf(env_map, _countof (env_map), TEXT("BXFI_MAP=%s"), map_name);

Ref. what Microsofts docs says:

sizeOfBuffer The size of the storage location for output. Size in bytes for the functions that take char,
and words for those that take wchar_t.