Harden admin integrations against drifting engagement and university contracts

The admin UI still had a few runtime assumptions left after the earlier
contract cleanup: engagement stats were returned flat while the dashboard
expected a nested `stats` object, and one university department lookup
still called a route shape that no longer exists in admin-v2. This
change normalizes the engagement payload and points department lookups at
the live nested university route.

Constraint: The dashboard component expects a nested engagement payload and the admin-v2 backend only exposes departments under /universities/:id/departments
Rejected: Patch the dashboard component only | the service layer is the shared normalization point and should absorb backend shape differences
Confidence: high
Scope-risk: narrow
Reversibility: clean
Directive: Keep admin service modules responsible for normalizing backend payload shapes before UI components consume them
Tested: pnpm exec jest --runInBand --watchman=false __tests__/app/services/dashboard-bff.test.ts; pnpm build
Not-tested: Live dashboard and university department interactions in production

Author: Smartnewb

__tests__/app/services/dashboard-bff.test.ts

@@ -17,23 +17,23 @@ describe('dashboard and kpi services use BFF client', () => {
 
     await dashboardService.getSummary();
 
-    expect(adminGet).toHaveBeenCalledWith('/admin/dashboard/summary');
+    expect(adminGet).toHaveBeenCalledWith('/admin/v2/dashboard/summary');
   });
 
   it('loads latest KPI report through adminGet', async () => {
     (adminGet as jest.Mock).mockResolvedValue({ week: 10, year: 2026 });
 
     await AdminService.kpiReport.getLatest();
 
-    expect(adminGet).toHaveBeenCalledWith('/admin/kpi-report/latest');
+    expect(adminGet).toHaveBeenCalledWith('/admin/v2/kpi-report/latest');
   });
 
   it('generates KPI report through adminPost', async () => {
     (adminPost as jest.Mock).mockResolvedValue({ week: 10, year: 2026 });
 
     await AdminService.kpiReport.generate(2026, 10);
 
-    expect(adminPost).toHaveBeenCalledWith('/admin/kpi-report/generate', {
+    expect(adminPost).toHaveBeenCalledWith('/admin/v2/kpi-report/generate', {
       year: 2026,
       week: 10,
     });
@@ -47,11 +47,49 @@ describe('dashboard and kpi services use BFF client', () => {
       limit: 1,
     });
 
-    expect(adminGet).toHaveBeenCalledWith('/admin/university-verification/pending', {
+    expect(adminGet).toHaveBeenCalledWith('/admin/v2/profile-review/university-verification/pending', {
       page: '1',
       limit: '1',
-      name: undefined,
-      university: undefined,
+      name: '',
+      university: '',
+    });
+  });
+
+  it('normalizes engagement stats into the nested dashboard shape', async () => {
+    (adminGet as jest.Mock).mockResolvedValue({
+      data: {
+        likesPerUser: { mean: 3.2, median: 2 },
+        mutualLikesPerUser: { mean: 1.4, median: 1 },
+        chatOpensPerUser: { mean: 0.8, median: 0 },
+        likeEngagement: { activeUsers: 10, totalUsers: 20, rate: 50 },
+        mutualLikeEngagement: { activeUsers: 6, totalUsers: 20, rate: 30 },
+        chatOpenEngagement: { activeUsers: 4, totalUsers: 20, rate: 20 },
+        startDate: '2026-04-01',
+        endDate: '2026-04-05',
+      },
+    });
+
+    await expect(
+      AdminService.userEngagement.getStats('2026-04-01', '2026-04-05', false),
+    ).resolves.toEqual({
+      stats: {
+        likesPerUser: { mean: 3.2, median: 2 },
+        mutualLikesPerUser: { mean: 1.4, median: 1 },
+        chatOpensPerUser: { mean: 0.8, median: 0 },
+        likeEngagement: { activeUsers: 10, totalUsers: 20, rate: 50 },
+        mutualLikeEngagement: { activeUsers: 6, totalUsers: 20, rate: 30 },
+        chatOpenEngagement: { activeUsers: 4, totalUsers: 20, rate: 20 },
+        periodEngagement: undefined,
+      },
+      startDate: '2026-04-01',
+      endDate: '2026-04-05',
+      periodType: 'custom',
+    });
+
+    expect(adminGet).toHaveBeenCalledWith('/admin/v2/stats/engagement', {
+      from: '2026-04-01',
+      to: '2026-04-05',
+      includeDeleted: 'false',
     });
   });
 });

app/services/admin/system.ts

@@ -213,8 +213,8 @@ export const universities = {
 		return result.data.clusters;
 	},
 
-	getDepartments: async (university: string) => {
-		const result = await adminGet<{ data: any }>('/admin/v2/universities/departments', { university });
+	getDepartments: async (universityId: string) => {
+		const result = await adminGet<{ data: any }>(`/admin/v2/universities/${universityId}/departments`);
 		return result.data;
 	},
 

app/services/admin/users.ts

@@ -922,7 +922,26 @@ export const userEngagement = {
 			if (includeDeleted !== undefined) params.includeDeleted = String(includeDeleted);
 
 			const res = await adminGet<{ data: any }>('/admin/v2/stats/engagement', params);
-			return res.data;
+			const payload = res.data ?? {};
+			return {
+				stats: {
+					likesPerUser: payload.likesPerUser ?? { mean: 0, median: 0 },
+					mutualLikesPerUser: payload.mutualLikesPerUser ?? { mean: 0, median: 0 },
+					chatOpensPerUser: payload.chatOpensPerUser ?? { mean: 0, median: 0 },
+					likeEngagement: payload.likeEngagement ?? { activeUsers: 0, totalUsers: 0, rate: 0 },
+					mutualLikeEngagement:
+						payload.mutualLikeEngagement ?? { activeUsers: 0, totalUsers: 0, rate: 0 },
+					chatOpenEngagement:
+						payload.chatOpenEngagement ?? { activeUsers: 0, totalUsers: 0, rate: 0 },
+					periodEngagement: payload.periodEngagement,
+				},
+				startDate: payload.startDate ?? startDate ?? null,
+				endDate:
+					payload.endDate ??
+					endDate ??
+					new Date().toISOString().split('T')[0],
+				periodType: payload.periodType ?? (startDate || endDate ? 'custom' : 'all'),
+			};
 		} catch (error: any) {
 			throw error;
 		}