Merge pull request #130 from Smartling/release-3-9-1

release 3.9.1

Author: vsolovei-smartling

composer.json

@@ -1,5 +1,6 @@
 {
   "name": "smartling/api-sdk-php",
+  "version": "3.9.1",
   "type": "library",
   "description": "PHP library to communicate with SmartlingAPI",
   "keywords": [
@@ -14,6 +15,7 @@
   "require": {
     "psr/log": "~1.0",
     "php": ">=5.5",
+    "ext-json": "*",
     "guzzlehttp/guzzle": "~6"
   },
   "require-dev": {

src/BaseApiAbstract.php

@@ -23,7 +23,7 @@ abstract class BaseApiAbstract
 
     const CLIENT_LIB_ID_SDK = 'smartling-api-sdk-php';
 
-    const CLIENT_LIB_ID_VERSION = '3.9.0';
+    const CLIENT_LIB_ID_VERSION = '3.9.1';
 
     const CLIENT_USER_AGENT_EXTENSION = '(no extensions)';
 

tests/unit/BaseApiAbstractTest.php

@@ -25,11 +25,11 @@ public function testNoUserAgentExtensions()
         $instance = FileApi::create($this->authProvider, 'test');
         $http_client = $this->invokeMethod($instance, 'getHttpClient');
 
-        $this->assertTrue(
+        $this->assertNotFalse(
             \strpos(
                 $http_client->getConfig()['headers']['User-Agent'],
-                'smartling-api-sdk-php/3.9.0 (no extensions) GuzzleHttp/6'
-            ) !== FALSE
+                'smartling-api-sdk-php/3.9.1 (no extensions) GuzzleHttp/6'
+            )
         );
     }
 
@@ -44,11 +44,11 @@ public function testCurrentClientIdAndVersionSpecifiedUserAgentExtensionNotSpeci
         $instance = FileApi::create($this->authProvider, 'test');
         $http_client = $this->invokeMethod($instance, 'getHttpClient');
 
-        $this->assertTrue(
+        $this->assertNotFalse(
             \strpos(
                 $http_client->getConfig()['headers']['User-Agent'],
                 'php-connector/1.2.3 (no extensions) GuzzleHttp/6'
-            ) !== FALSE
+            )
         );
     }
 
@@ -64,11 +64,11 @@ public function testClientIdAndClientVersionAndUserAgentExtensionsSpecified()
         $instance = FileApi::create($this->authProvider, 'test');
         $http_client = $this->invokeMethod($instance, 'getHttpClient');
 
-        $this->assertTrue(
+        $this->assertNotFalse(
             \strpos(
                 $http_client->getConfig()['headers']['User-Agent'],
                 'php-connector/1.2.3 dependency-1/version-1 dependency-2/version-2 GuzzleHttp/6'
-            ) !== FALSE
+            )
         );
     }
 }

tests/unit/FileApiTest.php

@@ -120,7 +120,7 @@ public function testUploadFile()
                     ],
                     [
                         'name' => 'smartling.client_lib_id',
-                        'contents' => '{"client":"smartling-api-sdk-php","version":"3.9.0"}',
+                        'contents' => '{"client":"smartling-api-sdk-php","version":"3.9.1"}',
                     ],
                     [
                         'name' => 'localeIdsToAuthorize[]',
@@ -148,7 +148,7 @@ public function testUploadFile()
 
         $params = new UploadFileParameters();
         $params->setAuthorized(true);
-        $params->setLocalesToApprove('es');
+        $params->setLocalesToApprove(['es']);
         $params->setNamespace('namespace_for_deduplication');
 
         $this->object->uploadFile('tests/resources/test.xml', 'test.xml', 'xml', $params);
@@ -171,7 +171,7 @@ public function testFileUploadParams()
         $exportedSettings = $fileUploadParams->exportToArray();
         $this->assertEquals($exportedSettings['authorize'], true);
 
-        $fileUploadParams->setLocalesToApprove('locale');
+        $fileUploadParams->setLocalesToApprove(['locale']);
 
         $fileUploadParams->setAuthorized(false);
         $exportedSettings = $fileUploadParams->exportToArray();