From 30c3049f6b59dda4f3209a1cb15d9dd24c709123 Mon Sep 17 00:00:00 2001 From: Alex Rabisse Date: Tue, 16 Sep 2025 16:09:30 -0500 Subject: [PATCH 1/6] IRN-6174 BpkCardList Height Scroll --- .../BpkCardListCarousel.module.scss | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/packages/bpk-component-card-list/src/BpkCardListRowRail/BpkCardListCarousel.module.scss b/packages/bpk-component-card-list/src/BpkCardListRowRail/BpkCardListCarousel.module.scss index 4895f264f0..88cbd4b89d 100644 --- a/packages/bpk-component-card-list/src/BpkCardListRowRail/BpkCardListCarousel.module.scss +++ b/packages/bpk-component-card-list/src/BpkCardListRowRail/BpkCardListCarousel.module.scss @@ -26,16 +26,16 @@ display: flex; padding-top: tokens.bpk-spacing-sm(); padding-bottom: tokens.bpk-spacing-lg(); - overflow-x: hidden; + overflow-x: scroll; box-sizing: border-box; gap: tokens.bpk-spacing-sm(); + -webkit-overflow-scrolling: touch; scroll-snap-stop: always; scroll-snap-type: x mandatory; scrollbar-width: none; @include breakpoints.bpk-breakpoint-mobile { padding-bottom: tokens.bpk-spacing-base(); - overflow-x: scroll; } &::-webkit-scrollbar { @@ -83,10 +83,10 @@ } } } - } - } - &__rail { - -webkit-overflow-scrolling: touch; + > * { + height: 100%; + } + } } } From eda4e4cb4b7d56dd629fe56edf80188466a71159 Mon Sep 17 00:00:00 2001 From: Alex Rabisse Date: Thu, 25 Sep 2025 12:30:48 -0500 Subject: [PATCH 2/6] remove scroll stuff --- .../src/BpkCardListRowRail/BpkCardListCarousel.module.scss | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/bpk-component-card-list/src/BpkCardListRowRail/BpkCardListCarousel.module.scss b/packages/bpk-component-card-list/src/BpkCardListRowRail/BpkCardListCarousel.module.scss index 88cbd4b89d..f50c861942 100644 --- a/packages/bpk-component-card-list/src/BpkCardListRowRail/BpkCardListCarousel.module.scss +++ b/packages/bpk-component-card-list/src/BpkCardListRowRail/BpkCardListCarousel.module.scss @@ -26,16 +26,16 @@ display: flex; padding-top: tokens.bpk-spacing-sm(); padding-bottom: tokens.bpk-spacing-lg(); - overflow-x: scroll; + overflow-x: hidden; box-sizing: border-box; gap: tokens.bpk-spacing-sm(); - -webkit-overflow-scrolling: touch; scroll-snap-stop: always; scroll-snap-type: x mandatory; scrollbar-width: none; @include breakpoints.bpk-breakpoint-mobile { padding-bottom: tokens.bpk-spacing-base(); + overflow-x: scroll; } &::-webkit-scrollbar { From 5c447bc228ae789f35f7d92ad15ff2f0744ab130 Mon Sep 17 00:00:00 2001 From: Alex Rabisse Date: Thu, 25 Sep 2025 12:34:36 -0500 Subject: [PATCH 3/6] remove scroll stuff2 --- .../BpkCardListRowRail/BpkCardListCarousel.module.scss | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/packages/bpk-component-card-list/src/BpkCardListRowRail/BpkCardListCarousel.module.scss b/packages/bpk-component-card-list/src/BpkCardListRowRail/BpkCardListCarousel.module.scss index f50c861942..0ad7b189de 100644 --- a/packages/bpk-component-card-list/src/BpkCardListRowRail/BpkCardListCarousel.module.scss +++ b/packages/bpk-component-card-list/src/BpkCardListRowRail/BpkCardListCarousel.module.scss @@ -83,10 +83,14 @@ } } } + } + } - > * { - height: 100%; - } + &__rail { + -webkit-overflow-scrolling: touch; + + > * { + height: 100%; } } } From 03d01e4dd72ffd6731e66cebebc1d9cfed2f5e0c Mon Sep 17 00:00:00 2001 From: Alex Rabisse Date: Thu, 25 Sep 2025 20:50:20 -0500 Subject: [PATCH 4/6] lol --- .../BpkCardListRowRail/BpkCardListCarousel.module.scss | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/bpk-component-card-list/src/BpkCardListRowRail/BpkCardListCarousel.module.scss b/packages/bpk-component-card-list/src/BpkCardListRowRail/BpkCardListCarousel.module.scss index 0ad7b189de..f6e53f3521 100644 --- a/packages/bpk-component-card-list/src/BpkCardListRowRail/BpkCardListCarousel.module.scss +++ b/packages/bpk-component-card-list/src/BpkCardListRowRail/BpkCardListCarousel.module.scss @@ -83,14 +83,14 @@ } } } + + > * { + height: 100%; + } } } &__rail { -webkit-overflow-scrolling: touch; - - > * { - height: 100%; - } } } From fdd1aa2582cdb7f80fd4cdbe5d34d1b6d69ceb1a Mon Sep 17 00:00:00 2001 From: Alex Rabisse Date: Thu, 25 Sep 2025 21:30:56 -0500 Subject: [PATCH 5/6] min-height --- .../src/BpkCardListRowRail/BpkCardListCarousel.module.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/bpk-component-card-list/src/BpkCardListRowRail/BpkCardListCarousel.module.scss b/packages/bpk-component-card-list/src/BpkCardListRowRail/BpkCardListCarousel.module.scss index f6e53f3521..3648c41eb0 100644 --- a/packages/bpk-component-card-list/src/BpkCardListRowRail/BpkCardListCarousel.module.scss +++ b/packages/bpk-component-card-list/src/BpkCardListRowRail/BpkCardListCarousel.module.scss @@ -85,7 +85,7 @@ } > * { - height: 100%; + min-height: 100%; } } } From 6c11beac06693ea4bfc4b6981590281e11d29392 Mon Sep 17 00:00:00 2001 From: Alex Rabisse Date: Fri, 26 Sep 2025 10:44:28 -0500 Subject: [PATCH 6/6] back to height --- .../src/BpkCardListRowRail/BpkCardListCarousel.module.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/bpk-component-card-list/src/BpkCardListRowRail/BpkCardListCarousel.module.scss b/packages/bpk-component-card-list/src/BpkCardListRowRail/BpkCardListCarousel.module.scss index 3648c41eb0..f6e53f3521 100644 --- a/packages/bpk-component-card-list/src/BpkCardListRowRail/BpkCardListCarousel.module.scss +++ b/packages/bpk-component-card-list/src/BpkCardListRowRail/BpkCardListCarousel.module.scss @@ -85,7 +85,7 @@ } > * { - min-height: 100%; + height: 100%; } } }