Config File
Currently the config is saved as SkyblockCoreConfig.json, which is already in conflict with our naming scheme and should be SkyBlockCoreConfig.json if we're keeping that style.
Some users have proposed we change the naming style to camelCase instead. We should have a quick discussion about which is preferred, or if we should have another change altogether.
Config Classes
The files ModConfig.java and ConfigManager.java are both stored in the events package - I don't feel like this is a good design, they should probably have their own package (config?) or be moved somewhere more fitting (even the util package is a better fit).
Also, personally - I'm unsure of the name ModConfig considering we've decided this shouldn't be treated as a standalone mod. New class names for that are also being accepted.
Checklist
Config File
Currently the config is saved as
SkyblockCoreConfig.json, which is already in conflict with our naming scheme and should beSkyBlockCoreConfig.jsonif we're keeping that style.Some users have proposed we change the naming style to
camelCaseinstead. We should have a quick discussion about which is preferred, or if we should have another change altogether.Config Classes
The files
ModConfig.javaandConfigManager.javaare both stored in theeventspackage - I don't feel like this is a good design, they should probably have their own package (config?) or be moved somewhere more fitting (even theutilpackage is a better fit).Also, personally - I'm unsure of the name
ModConfigconsidering we've decided this shouldn't be treated as a standalone mod. New class names for that are also being accepted.Checklist