Use colorjs.io to represent CSS4 colors.
#1975
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a8b12ee The changes in this PR will be included in the next version bump. This PR includes changesets to release 80 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Jym77
added
major
Jym77
commented
Jan 15, 2026
| const serialize = serializer(Gradient.Linear.parse); | ||
|
|
||
| const red = color(1, 0, 0); | ||
| const lime = color(0, 1, 0); |
Contributor
Author
There was a problem hiding this comment.
Remark: Tests that used green now switch to lime. This is because lime is #00FF00, or rgb(0% 100% 0%) while green is #008000, or rgb(0% 50.19607843137255% 0%) (128/255). For the sake of avoiding messy floating point arithmetic in tests, lime is just simpler…
Comment on lines
+8
to
+10
| * The old `RGB`, `Named`, `Hex`, … classes no longer exist. Everything is bundled into a `CC4Color` class. The `#red`, `#green`, `#blue`, `#alpha` getters still exist, returning the components in the sRGB color space. | ||
| * The constructors `Color.hsl`, `Color.hex`, … have similarly been removed. | ||
| * The `Color.rgb` constructor has been kept as it is used in many places. |
Contributor
Author
There was a problem hiding this comment.
This will require changes in Dory which is using RGB.of in a few places, notably when building oracles and when marshalling color related diagnostics.
RGB.of will need to be replaced by Color.rgb. The RGBtoColorJSON helper will also need some adaptation, but that should be simplification since the sRGB components are now guaranteed to be Percentage (cannot be Number anymore).
@mvy-siteimprove FYI.
| 1: Outcomes.IsDistinguishable( | ||
| [style, Err.of(spanStyle)], | ||
| [addCursor(Ok.of(spanStyle)), addCursor(style)], | ||
| [addCursor(style), addCursor(Ok.of(spanStyle))], |
Contributor
Author
There was a problem hiding this comment.
I believe the swapping of elements was already present, but simpler color representation made .deepEqual able to ignore it 🤔
Contributor
Author
|
!pr extract |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare for #1966