Add Pin Clustering & Filter Options to Silph League Map

[fortepc]

Your issue may already be reported! Please search on the issue tracker before creating one.

Note: for support questions, please use /r/TheSilphRoad. This repository's issues are reserved for feature requests and bug reports.

I'm submitting a ...

• bug report
• feature request

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem

Try to include screenshots, or any other material to help us understand how to reproduce
https://i.imgur.com/Y0BSG5x.png Larger 58 Member Group
https://i.imgur.com/NuTRLm8.png Smaller 15 Member Group
https://i.imgur.com/mRZxlx8.png The smaller 15 member group is layered above the larger one,

What is the expected behavior or new feature?

Either there needs to be a more reasonable and intentional default layer shorting option, or it should be user configurable.

Sort Layer by:
-Member Count
-Recently Active
-Discord First
-Telegram First
-etc

Filter Communities:
-Team Neutral (only servers with all three team checked),
-Instinct Inclusive (only servers with at least instinct checked),
-Instinct Exclusive (only servers that with only instinct checked),
-Uses 3rd Party Scanners
-Does not use 3rd Party Scanners
-More than number members

What is the motivation / use case for changing the behavior?

To make viewing a dense area easier. To discourage and minimize map abuse from preventing usability. If someone makes a bunch of fake pins in an area, or a bunch of competing groups, users can use layer sort options, and filter options, to make sure they can still find a group worth joining.

Please tell us about your environment, for bugs:

left out environment for feature request.

[marcoceppi]

I don't think I would want to penalize smaller or larger groups. Of the suggestions above I think the only ones that we'd consider implementing are filter by communities. I'd suggest it works as follows:

If you're not authenticated, you can choose a team. That will show all markers that support that team (including neutral servers).

As far as sorting goes, this again is disingenuous and penalizes groups. Instead we'll be implementing a clustering algorithm that better shows multiple groups.

[fortepc]

I see what you mean about penalizing them, and that sounds like a great alternative solution to the problem! I feel like this should be slightly higher priority than wishlist though considering how right now it's just so easy to intentionally hide someone else's community pin by choosing coords a small amount south of the other pin. I played around with it, intentionally covering the team neutral server's pin with our team exclusive one, and their pin became totally inaccessible. At the very least maybe the member count layer sort option could be a temporary band aid if it would be easier to implement.

[marcoceppi]

We have two priorities on github, wishlist and high. High priorities are for breaks :) Something is in the works to address this

[fortepc]

Oh! Fair enough~

[fortepc]

Just to follow up, since it's been a while, it may be worth re-visiting the layer sorting, there are quite a lot of totally dormant pins of communities that aren't join-able now that are really cluttering up some areas of the map.

Or maybe just some way for communities to go "stale" if the bot doesn't detect any activity at all in the server for 6months+ or some reasonable amount of time. The bot could just give the heads up to the admins in their silph-league channel their community has gone stale, and is not currently visible on the community map, and offer a simple "I'm still here" response from the server owner to re-enable their pin.