Skip to content

Conversation

@paracycle
Copy link
Member

No description provided.

@paracycle paracycle requested a review from a team as a code owner January 12, 2026 23:38
Copy link
Contributor

@Morriar Morriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a bundler test is failing:

Spoom::Context::BundleTest#test_context_bundle_install! 
Expected "Bundler version 4.0.3 (2025-12-23 commit 28c66ecc1e)\n\nBundler commands:\n\n  Primary commands:\n    bundle install [OPTIONS]    # Install the current environment to the system\n    bundle update [OPTIONS]     # Update the current environment\n    bundle cache [OPTIONS]      # Locks and then caches all of the gems into ...\n    bundle exec [OPTIONS]       # Run the command in context of the bundle\n    bundle config NAME [VALUE]  # Retrieve or set a configuration value\n    bundle help [COMMAND]       # Describe available commands or one specific...\n\n  Utilities:\n    bundle add GEM VERSION         # Add gem to Gemfile and run bundle install\n    bundle binstubs GEM [OPTIONS]  # Install the binstubs of the listed gem\n    bundle check [OPTIONS]         # Checks if the dependencies listed in Gem...\n    bundle clean [OPTIONS]         # Cleans up unused gems in your bundler directory\n    bundle console [GROUP]         # Opens an IRB session with the bundle pre-loaded\n    bundle doctor [OPTIONS]        # Checks the bundle for common problems\n    bundle env                     # Print information about the environment ...\n    bundle fund [OPTIONS]          # Lists information about gems seeking fun...\n    bundle gem NAME [OPTIONS]      # Creates a skeleton for creating a rubygem\n    bundle info GEM [OPTIONS]      # Show information for the given gem\n    bundle init [OPTIONS]          # Generates a Gemfile into the current wor...\n    bundle issue                   # Learn how to report an issue in Bundler\n    bundle licenses                # Prints the license of all gems in the bundle\n    bundle list                    # List all gems in the bundle\n    bundle lock                    # Creates a lockfile without installing\n    bundle open GEM                # Opens the source directory of the given ...\n    bundle outdated GEM [OPTIONS]  # List installed gems with newer versions ...\n    bundle platform [OPTIONS]      # Displays platform compatibility information\n    bundle plugin                  # Manage the bundler plugins\n    bundle pristine [GEMS...]      # Restores installed gems to pristine condition\n    bundle remove [GEM [GEM ...]]  # Removes gems from the Gemfile\n    bundle show GEM [OPTIONS]      # Shows all gems that are part of the bund...\n    bundle version                 # Prints Bundler version information\n\nOptions:\n      [--no-color]                                   # Disable colorization in output\n  -r, [--retry=NUM]                                  # Specify the number of times you wish to attempt network commands\n  -V, [--verbose], [--no-verbose], [--skip-verbose]  # Enable verbose output mode\n\n" to be empty.

Also the output of the minitest reporter looks different, is it related to the bump?

image

@paracycle
Copy link
Member Author

Looks like a bundler test is failing:

Spoom::Context::BundleTest#test_context_bundle_install! 
Expected "Bundler version 4.0.3 (2025-12-23 commit 28c66ecc1e)\n\nBundler commands:\n\n  Primary commands:\n    bundle install [OPTIONS]    # Install the current environment to the system\n    bundle update [OPTIONS]     # Update the current environment\n    bundle cache [OPTIONS]      # Locks and then caches all of the gems into ...\n    bundle exec [OPTIONS]       # Run the command in context of the bundle\n    bundle config NAME [VALUE]  # Retrieve or set a configuration value\n    bundle help [COMMAND]       # Describe available commands or one specific...\n\n  Utilities:\n    bundle add GEM VERSION         # Add gem to Gemfile and run bundle install\n    bundle binstubs GEM [OPTIONS]  # Install the binstubs of the listed gem\n    bundle check [OPTIONS]         # Checks if the dependencies listed in Gem...\n    bundle clean [OPTIONS]         # Cleans up unused gems in your bundler directory\n    bundle console [GROUP]         # Opens an IRB session with the bundle pre-loaded\n    bundle doctor [OPTIONS]        # Checks the bundle for common problems\n    bundle env                     # Print information about the environment ...\n    bundle fund [OPTIONS]          # Lists information about gems seeking fun...\n    bundle gem NAME [OPTIONS]      # Creates a skeleton for creating a rubygem\n    bundle info GEM [OPTIONS]      # Show information for the given gem\n    bundle init [OPTIONS]          # Generates a Gemfile into the current wor...\n    bundle issue                   # Learn how to report an issue in Bundler\n    bundle licenses                # Prints the license of all gems in the bundle\n    bundle list                    # List all gems in the bundle\n    bundle lock                    # Creates a lockfile without installing\n    bundle open GEM                # Opens the source directory of the given ...\n    bundle outdated GEM [OPTIONS]  # List installed gems with newer versions ...\n    bundle platform [OPTIONS]      # Displays platform compatibility information\n    bundle plugin                  # Manage the bundler plugins\n    bundle pristine [GEMS...]      # Restores installed gems to pristine condition\n    bundle remove [GEM [GEM ...]]  # Removes gems from the Gemfile\n    bundle show GEM [OPTIONS]      # Shows all gems that are part of the bund...\n    bundle version                 # Prints Bundler version information\n\nOptions:\n      [--no-color]                                   # Disable colorization in output\n  -r, [--retry=NUM]                                  # Specify the number of times you wish to attempt network commands\n  -V, [--verbose], [--no-verbose], [--skip-verbose]  # Enable verbose output mode\n\n" to be empty.

Also the output of the minitest reporter looks different, is it related to the bump?

image

Yeah, that's because Bundler's behaviour has changed slightly for when it can't find a Gemfile in a directory. It still prints the Could not locate Gemfile message, but also prints the bundler usage/commands before that.

@paracycle
Copy link
Member Author

Ugh, it prints the usage to the STDOUT 😞

Since Bundler 4, when no Gemfile is found in the currect directory,
Bundler prints the usage to STDOUT, followed by the `Could not locate
Gemfile` message to STDERR.

Previously our test was expecting an empty STDOUT for this case, which
is no longer true.
@paracycle
Copy link
Member Author

@Morriar the test output is probably related to minitest being bumped to v6. I'm not going to touch that as part of this PR.

@paracycle
Copy link
Member Author

@Morriar I have the minitest related stuff fixed here: #850

@paracycle paracycle requested a review from Morriar January 13, 2026 19:05
@paracycle paracycle merged commit b024c5a into main Jan 13, 2026
10 checks passed
@paracycle paracycle deleted the uk-bump-to-ruby-4 branch January 13, 2026 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants