Feedback

[wiebekaai]

Hey, we've been fully embracing theme blocks and I thought I'd share some feedback:

• With many nested blocks, the theme editor gets laggy. It gets better when you collapse all sections, but by default they are all open. Could we maybe only open the first level of blocks by default? Or none at all?
  • Related: Global expand/collapse buttons in theme editor #79
• Passing arguments to blocks ({% content_for 'block', with: item %}). This will allow us to use theme blocks for cart items in the cart, but also set the right sizes for images by being aware of columns for example.
• Support CSS variables for the spacing style settings. This way we can set all the horizontal padding of sections evenly for example. I like the size setting, where you can select auto or custom and then enter your px value. Please consider this for paddings and margins too.
• Exceeding 256kb template JSON files! With our setup we can now create any content section with theme blocks, but we're running into a maximum file size. A landing or homepage can have quite a few sections, with all these block settings the file grows too big.

Overall I'm really happy with the productivity boost these features will give us as an agency. Great job team :).

Thank you.

Wiebe

(I'll probably add on to this thread as we find more)

[wiebekaai]

@stephanie-shopify @tyleralsbury please take a look. The 256kb file limit is a blocker for us, is this something you're also running into with style settings - we now use our own version of this? Or do you store those more efficiently (excluding default values)?

Update: If I minify the file it uploads fine. Can the Shopfiy theme CLI do this by default? Haha