Replies: 1 comment 1 reply
-
|
This would be much preferred over the underscore prefix. Would make backwards compatibility with existing sites WAY easier. At the moment, it seems easier to make all of their blocks public to keep a clean upgrade path. Adding this property would allow us to keep the same JSON for templates because as long as the block names in blocks/**.liquid remain the same as they are defined in "type", everything works smoothly. But if we're forced to add a __ to those file names, then the JSON block references also have to be updated everywhere. |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Everything is in the title. I was pretty surprised to find the private blocks managed using a prefix in the file name instead of leveraging a property inside the schema, where it would be more logic in my opinion. I was wondering if said property was on the roadmap ?
It would look like that:
Instead of:
Of course, for backward compatibility, legacy underscore prefix shall remain, I'm just curious if this prefix convention may appear elsewhere in the future ?
Beta Was this translation helpful? Give feedback.
All reactions