Skip to content

Eagerly open file for appending in OrderReporter #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shioyama wants to merge 1 commit into from
Closed

Eagerly open file for appending in OrderReporter #358

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions ruby/lib/minitest/queue/order_reporter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
class Minitest::Queue::OrderReporter < Minitest::Reporters::BaseReporter
def initialize(options = {})
@path = options.delete(:path)
@file = nil
@file = File.open(@path, 'a+')
super
end

Expand All @@ -25,8 +25,6 @@ def report

private

def file
@file ||= File.open(@path, 'a+')
end
attr_reader :file
end

Loading