Skip to content

Fix increment_test_failed #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisBr merged 1 commit into from
Jul 9, 2025
Merged

Fix increment_test_failed #351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ruby/lib/ci/queue/redis/build_record.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,12 @@ def record_warning(type, attributes)
end

def record_error(id, payload, stats: nil)
redis.pipelined do |pipeline|
acknowledged, _ = redis.pipelined do |pipeline|
@queue.acknowledge(id, error: payload, pipeline: pipeline)
record_stats(stats, pipeline: pipeline)
@queue.increment_test_failed(pipeline: pipeline)
end

@queue.increment_test_failed if acknowledged == 1
nil
end

Expand Down
2 changes: 2 additions & 0 deletions ruby/test/minitest/queue/build_status_recorder_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ def test_retrying_test
reserve(second_queue, "a")
second_reporter.record(result("a"))
assert_equal 0, summary.error_reports.size
assert_equal 1, @queue.test_failed
end

def test_retrying_test_reverse
Expand Down Expand Up @@ -102,6 +103,7 @@ def test_retrying_test_reverse
reserve(second_queue, "a")
second_reporter.record(result("a", failure: "Something went wrong"))
assert_equal 0, summary.error_reports.size
assert_equal 0, @queue.test_failed
end

def test_static_queue_record_success
Expand Down
4 changes: 2 additions & 2 deletions ruby/test/minitest/queue/build_status_reporter_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ def test_timing_out_waiting_for_tests

@supervisor.instance_variable_set(:@time_left, 0)

out, err = capture_subprocess_io do
out, _ = capture_subprocess_io do
exit_status = @reporter.report
end

Expand All @@ -44,7 +44,7 @@ def test_all_workers_died
@supervisor.instance_variable_set(:@time_left, 1)
@supervisor.instance_variable_set(:@time_left_with_no_workers, 0)

out, err = capture_subprocess_io do
out, _ = capture_subprocess_io do
exit_status = @reporter.report
end

Expand Down
Loading