From d25df63f5efb1c8c998c39b3f42eddce31e0f6d0 Mon Sep 17 00:00:00 2001 From: Christian Bruckmayer Date: Mon, 9 Jun 2025 11:12:22 -0400 Subject: [PATCH] Improve error message --- ruby/lib/minitest/queue/runner.rb | 2 +- ruby/lib/rspec/queue.rb | 2 +- ruby/test/integration/minitest_redis_test.rb | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/ruby/lib/minitest/queue/runner.rb b/ruby/lib/minitest/queue/runner.rb index 86c0b0ca..fcebf37b 100644 --- a/ruby/lib/minitest/queue/runner.rb +++ b/ruby/lib/minitest/queue/runner.rb @@ -253,7 +253,7 @@ def report_command unless supervisor.wait_for_workers { display_warnings(supervisor.build) } unless supervisor.queue_initialized? - abort! "No master was elected. Did all workers crash?", 40 + abort! "No leader was elected. This typically means no worker was able to start. Were there any errors during application boot?", 40 end unless supervisor.exhausted? diff --git a/ruby/lib/rspec/queue.rb b/ruby/lib/rspec/queue.rb index 32f1a25f..469fa4b4 100644 --- a/ruby/lib/rspec/queue.rb +++ b/ruby/lib/rspec/queue.rb @@ -283,7 +283,7 @@ def call(options, stdout, stderr) unless supervisor.wait_for_workers unless supervisor.queue_initialized? - abort! "No master was elected. Did all workers crash?" + abort! "No leader was elected. This typically means no worker was able to start. Were there any errors during application boot?" end unless supervisor.exhausted? diff --git a/ruby/test/integration/minitest_redis_test.rb b/ruby/test/integration/minitest_redis_test.rb index c38fbb44..0cdd1f00 100644 --- a/ruby/test/integration/minitest_redis_test.rb +++ b/ruby/test/integration/minitest_redis_test.rb @@ -269,7 +269,7 @@ def test_all_workers_died assert_empty err expected = <<~EXPECTED Waiting for workers to complete - No master was elected. Did all workers crash? + No leader was elected. This typically means no worker was able to start. Were there any errors during application boot? EXPECTED assert_equal expected.strip, normalize(out.lines[0..2].join.strip) end